From: "Laszlo Ersek" <lersek@redhat.com>
To: Sami Mujawar <sami.mujawar@arm.com>, devel@edk2.groups.io
Cc: achin.gupta@arm.com, jiewen.yao@intel.com,
supreeth.venkatesh@arm.com, Matteo.Carlini@arm.com,
Laura.Moretta@arm.com, nd@arm.com
Subject: Re: [PATCH v2 1/1] StandaloneMmPkg: Fix build failure - Bug 2253
Date: Mon, 25 Nov 2019 13:14:28 +0100 [thread overview]
Message-ID: <1b7cad39-4781-58db-61b2-1705e6a06a0c@redhat.com> (raw)
In-Reply-To: <20191125090604.2076-1-sami.mujawar@arm.com>
On 11/25/19 10:06, Sami Mujawar wrote:
> The StandaloneMmPkg currently has code for supporting
> Arm architecture only. Support for X64 and IA32 is
> currently under development on a separate branch.
>
> However, StandaloneMmPkg/StandaloneMmPkg.dsc is
> indicating that support for X64 and IA32 is
> available which is causing build failures.
> This has been reported in
> https://bugzilla.tianocore.org/show_bug.cgi?id=2253
>
> This issue has been discussed earlier on the list:
> (1) https://edk2.groups.io/g/devel/message/47276
>
> (2) https://edk2.groups.io/g/devel/message/47283
>
> In light of the above, this patch removes IA32 and X64
> from SUPPORTED_ARCHITECTURES, until support for the
> respective architectures is merged into StandaloneMmPkg.
>
> Cc: Achin Gupta <achin.gupta@arm.com>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: Supreeth Venkatesh <supreeth.venkatesh@arm.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Signed-off-by: Sami Mujawar <sami.mujawar@arm.com>
>
> ---
> The changes can be seen at:
> https://github.com/samimujawar/edk2/tree/697_stmm_disable_unsupported_arch_v1
>
> Notes:
> v2:
> - Fixed patch check failure in commit message, [SAMI]
> changed 'CC' to 'Cc'. No code change.
> v1:
> - Fix for Bug 2253 [SAMI]
> (https://bugzilla.tianocore.org/show_bug.cgi?id=2253)
>
> StandaloneMmPkg/StandaloneMmPkg.dsc | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/StandaloneMmPkg/StandaloneMmPkg.dsc b/StandaloneMmPkg/StandaloneMmPkg.dsc
> index 8a68d397469bdb83586bfeaebedcd52fd528b20f..f9546e182e25fbcd253de0986a1bb554dae1e975 100644
> --- a/StandaloneMmPkg/StandaloneMmPkg.dsc
> +++ b/StandaloneMmPkg/StandaloneMmPkg.dsc
> @@ -2,7 +2,7 @@
> # Standalone MM Platform.
> #
> # Copyright (c) 2015, Intel Corporation. All rights reserved.<BR>
> -# Copyright (c) 2016 - 2018, ARM Limited. All rights reserved.<BR>
> +# Copyright (c) 2016 - 2019, ARM Limited. All rights reserved.<BR>
> #
> # SPDX-License-Identifier: BSD-2-Clause-Patent
> #
> @@ -19,7 +19,7 @@ [Defines]
> PLATFORM_VERSION = 1.0
> DSC_SPECIFICATION = 0x00010011
> OUTPUT_DIRECTORY = Build/StandaloneMm
> - SUPPORTED_ARCHITECTURES = IA32|X64|AARCH64
> + SUPPORTED_ARCHITECTURES = AARCH64
> BUILD_TARGETS = DEBUG|RELEASE
> SKUID_IDENTIFIER = DEFAULT
>
>
Reviewed-by: Laszlo Ersek <lersek@redhat.com>
prev parent reply other threads:[~2019-11-25 12:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-25 9:06 [PATCH v2 1/1] StandaloneMmPkg: Fix build failure - Bug 2253 Sami Mujawar
2019-11-25 11:10 ` Sami Mujawar
2019-11-25 13:03 ` Laszlo Ersek
2019-11-25 13:07 ` [edk2-devel] " Liming Gao
2019-11-25 12:14 ` Laszlo Ersek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1b7cad39-4781-58db-61b2-1705e6a06a0c@redhat.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox