From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-1.mimecast.com (us-smtp-1.mimecast.com [205.139.110.120]) by mx.groups.io with SMTP id smtpd.web11.3138.1574684077307121096 for ; Mon, 25 Nov 2019 04:14:37 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=VhrnwxXk; spf=pass (domain: redhat.com, ip: 205.139.110.120, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1574684076; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Lh7+CineV8/rzgNhFEYt69vvq1Pk2iBS3fkBJVUudbs=; b=VhrnwxXkiKPS0/4uUVRsPS2vpV6fjz04acAZ9pufF0hAriT+gAyNvL3I1l4QoMv1SjmZ8t jdqgxwEDG+8IfmYcLzHMoJyWNtwuu1aF+oqvpaqGXc+kUiBep/I/vhKYWqMQF9o6cX7aMd etiNWBqJhdxZw1YZyiE+epaik7NJAa0= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-156-K9tQTUCsMyuZydPhgzEnjg-1; Mon, 25 Nov 2019 07:14:32 -0500 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 6E9D0184CAA3; Mon, 25 Nov 2019 12:14:31 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-116-167.ams2.redhat.com [10.36.116.167]) by smtp.corp.redhat.com (Postfix) with ESMTP id AF9D25C1D4; Mon, 25 Nov 2019 12:14:29 +0000 (UTC) Subject: Re: [PATCH v2 1/1] StandaloneMmPkg: Fix build failure - Bug 2253 To: Sami Mujawar , devel@edk2.groups.io Cc: achin.gupta@arm.com, jiewen.yao@intel.com, supreeth.venkatesh@arm.com, Matteo.Carlini@arm.com, Laura.Moretta@arm.com, nd@arm.com References: <20191125090604.2076-1-sami.mujawar@arm.com> From: "Laszlo Ersek" Message-ID: <1b7cad39-4781-58db-61b2-1705e6a06a0c@redhat.com> Date: Mon, 25 Nov 2019 13:14:28 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20191125090604.2076-1-sami.mujawar@arm.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-MC-Unique: K9tQTUCsMyuZydPhgzEnjg-1 X-Mimecast-Spam-Score: 0 Content-Language: en-US Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit On 11/25/19 10:06, Sami Mujawar wrote: > The StandaloneMmPkg currently has code for supporting > Arm architecture only. Support for X64 and IA32 is > currently under development on a separate branch. > > However, StandaloneMmPkg/StandaloneMmPkg.dsc is > indicating that support for X64 and IA32 is > available which is causing build failures. > This has been reported in > https://bugzilla.tianocore.org/show_bug.cgi?id=2253 > > This issue has been discussed earlier on the list: > (1) https://edk2.groups.io/g/devel/message/47276 > > (2) https://edk2.groups.io/g/devel/message/47283 > > In light of the above, this patch removes IA32 and X64 > from SUPPORTED_ARCHITECTURES, until support for the > respective architectures is merged into StandaloneMmPkg. > > Cc: Achin Gupta > Cc: Jiewen Yao > Cc: Supreeth Venkatesh > Cc: Laszlo Ersek > Signed-off-by: Sami Mujawar > > --- > The changes can be seen at: > https://github.com/samimujawar/edk2/tree/697_stmm_disable_unsupported_arch_v1 > > Notes: > v2: > - Fixed patch check failure in commit message, [SAMI] > changed 'CC' to 'Cc'. No code change. > v1: > - Fix for Bug 2253 [SAMI] > (https://bugzilla.tianocore.org/show_bug.cgi?id=2253) > > StandaloneMmPkg/StandaloneMmPkg.dsc | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/StandaloneMmPkg/StandaloneMmPkg.dsc b/StandaloneMmPkg/StandaloneMmPkg.dsc > index 8a68d397469bdb83586bfeaebedcd52fd528b20f..f9546e182e25fbcd253de0986a1bb554dae1e975 100644 > --- a/StandaloneMmPkg/StandaloneMmPkg.dsc > +++ b/StandaloneMmPkg/StandaloneMmPkg.dsc > @@ -2,7 +2,7 @@ > # Standalone MM Platform. > # > # Copyright (c) 2015, Intel Corporation. All rights reserved.
> -# Copyright (c) 2016 - 2018, ARM Limited. All rights reserved.
> +# Copyright (c) 2016 - 2019, ARM Limited. All rights reserved.
> # > # SPDX-License-Identifier: BSD-2-Clause-Patent > # > @@ -19,7 +19,7 @@ [Defines] > PLATFORM_VERSION = 1.0 > DSC_SPECIFICATION = 0x00010011 > OUTPUT_DIRECTORY = Build/StandaloneMm > - SUPPORTED_ARCHITECTURES = IA32|X64|AARCH64 > + SUPPORTED_ARCHITECTURES = AARCH64 > BUILD_TARGETS = DEBUG|RELEASE > SKUID_IDENTIFIER = DEFAULT > > Reviewed-by: Laszlo Ersek