From: krishnaLee <sssky307@163.com>
To: "Shenglei Zhang" <shenglei.zhang@intel.com>
Cc: edk2-devel@lists.01.org
Subject: Re: [PATCH] ShellPkg: Correct a parameter's name
Date: Thu, 21 Feb 2019 10:00:19 +0800 (CST) [thread overview]
Message-ID: <1b9465c6.35dc.1690dc837ed.Coremail.sssky307@163.com> (raw)
In-Reply-To: <20190221012807.16740-1-shenglei.zhang@intel.com>
Hi Shenglei,
I am confused some times,see UEFI_Shell_specification_2_2,chapter-3.7:
3.7 File Names
The UEFI Shell supports file names and paths with the following format:
fs-path := [fs-map-name] [fs-divider][fs-dirs][fs-name]
May be if the define name "fs-path" rename to "file-full-path-name" is more clear,:)
thanks,
krishna.
At 2019-02-21 09:28:07, "Shenglei Zhang" <shenglei.zhang@intel.com> wrote:
>The parameter FilePath of ShellOpenFileByName defined in
>ShellLib.h is incorrect. It should be FileName.
>https://bugzilla.tianocore.org/show_bug.cgi?id=1221
>
>Cc: Jaben Carsey <jaben.carsey@intel.com>
>Cc: Ruiyu Ni <ruiyu.ni@intel.com>
>Contributed-under: TianoCore Contribution Agreement 1.1
>Signed-off-by: shenglei <shenglei.zhang@intel.com>
>---
> ShellPkg/Include/Library/ShellLib.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/ShellPkg/Include/Library/ShellLib.h b/ShellPkg/Include/Library/ShellLib.h
>index 2ecc5ee006..78bdcc8c53 100644
>--- a/ShellPkg/Include/Library/ShellLib.h
>+++ b/ShellPkg/Include/Library/ShellLib.h
>@@ -161,7 +161,7 @@ ShellOpenFileByDevicePath(
> otherwise, the Filehandle is NULL. Attributes is valid only for
> EFI_FILE_MODE_CREATE.
>
>- @param[in] FilePath The pointer to file name.
>+ @param[in] FileName The pointer to file name.
> @param[out] FileHandle The pointer to the file handle.
> @param[in] OpenMode The mode to open the file with.
> @param[in] Attributes The file's file attributes.
>@@ -186,7 +186,7 @@ ShellOpenFileByDevicePath(
> EFI_STATUS
> EFIAPI
> ShellOpenFileByName(
>- IN CONST CHAR16 *FilePath,
>+ IN CONST CHAR16 *FileName,
> OUT SHELL_FILE_HANDLE *FileHandle,
> IN UINT64 OpenMode,
> IN UINT64 Attributes
>--
>2.18.0.windows.1
>
>_______________________________________________
>edk2-devel mailing list
>edk2-devel@lists.01.org
>https://lists.01.org/mailman/listinfo/edk2-devel
\x16�&
next prev parent reply other threads:[~2019-02-21 2:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-21 1:28 [PATCH] ShellPkg: Correct a parameter's name Shenglei Zhang
2019-02-21 2:00 ` krishnaLee [this message]
2019-02-26 1:47 ` Zhang, Shenglei
-- strict thread matches above, loose matches on Subject: below --
2019-03-05 2:05 Shenglei Zhang
2019-03-05 15:21 ` Carsey, Jaben
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1b9465c6.35dc.1690dc837ed.Coremail.sssky307@163.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox