public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Laszlo Ersek" <lersek@redhat.com>
To: devel@edk2.groups.io, jianyong.wu@arm.com, Sami.Mujawar@arm.com
Cc: ardb+tianocore@kernel.org
Subject: Re: [edk2-devel] [PATCH] CloudHv: Add CI for CloudHv on AArch64
Date: Fri, 17 Nov 2023 22:53:51 +0100	[thread overview]
Message-ID: <1ba8e2fd-3618-1d46-1c85-89da0f689878@redhat.com> (raw)
In-Reply-To: <20231115062025.513379-1-jianyong.wu@arm.com>

On 11/15/23 07:20, Jianyong Wu wrote:
> Add the long lost CI for CloudHv on AArch64.
> 
> Signed-off-by: Jianyong Wu <jianyong.wu@arm.com>
> ---
>  .../.azurepipelines/Ubuntu-GCC5.yml           | 13 ++++++++
>  ArmVirtPkg/PlatformCI/CloudHvBuild.py         | 32 +++++++++++++++++++
>  2 files changed, 45 insertions(+)
>  create mode 100644 ArmVirtPkg/PlatformCI/CloudHvBuild.py

Please format and document patches such that they are easier to review.
Otherwise reviewers have to dig too much.

> 
> diff --git a/ArmVirtPkg/PlatformCI/.azurepipelines/Ubuntu-GCC5.yml b/ArmVirtPkg/PlatformCI/.azurepipelines/Ubuntu-GCC5.yml
> index d1772a65fc..ab8a2db530 100644
> --- a/ArmVirtPkg/PlatformCI/.azurepipelines/Ubuntu-GCC5.yml
> +++ b/ArmVirtPkg/PlatformCI/.azurepipelines/Ubuntu-GCC5.yml
> @@ -140,6 +140,19 @@ jobs:
>              Build.Target: "RELEASE"
>              Run: false
>  
> +          CLOUDHV_AARCH64_DEBUG:
> +            Build.File: "$(package)/PlatformCI/CloudHvBuild.py"
> +            Build.Arch: "AARCH64"
> +            Build.Flags: ""
> +            Build.Target: "DEBUG"
> +            Run: false
> +          CLOUDHV_AARCH64_RELEASE:
> +            Build.File: "$(package)/PlatformCI/CloudHvBuild.py"
> +            Build.Arch: "AARCH64"
> +            Build.Flags: ""
> +            Build.Target: "RELEASE"
> +            Run: false
> +
>      workspace:
>        clean: all
>  

This seems like a copy of the KVMTOOL stanzas, except with (a) ARM
removed, (b) KVMTOOL replaced by CLOUDHV, (c) KvmToolBuild.py replaced
with CloudHvBuild.py.

OK.

> diff --git a/ArmVirtPkg/PlatformCI/CloudHvBuild.py b/ArmVirtPkg/PlatformCI/CloudHvBuild.py
> new file mode 100644
> index 0000000000..0192cd6577
> --- /dev/null
> +++ b/ArmVirtPkg/PlatformCI/CloudHvBuild.py
> @@ -0,0 +1,32 @@
> +# @file
> +# Script to Build ArmVirtPkg UEFI firmware
> +#
> +# Copyright (c) Microsoft Corporation.
> +# SPDX-License-Identifier: BSD-2-Clause-Patent
> +##
> +import os
> +import sys
> +
> +sys.path.append(os.path.dirname(os.path.abspath(__file__)))
> +from PlatformBuildLib import SettingsManager
> +from PlatformBuildLib import PlatformBuilder
> +
> +    # ####################################################################################### #
> +    #                                Common Configuration                                     #
> +    # ####################################################################################### #
> +class CommonPlatform():
> +    ''' Common settings for this platform.  Define static data here and use
> +        for the different parts of stuart
> +    '''
> +    PackagesSupported = ("ArmVirtPkg",)
> +    ArchSupported = ("AARCH64", "ARM")
> +    TargetsSupported = ("DEBUG", "RELEASE")
> +    Scopes = ('armvirt', 'edk2-build')
> +    WorkspaceRoot = os.path.realpath(os.path.join(
> +        os.path.dirname(os.path.abspath(__file__)), "..", ".."))
> +
> +    DscName = os.path.join("ArmVirtPkg", "ArmVirtCloudHv.dsc")
> +    FvQemuArg = "" # ignored
> +
> +import PlatformBuildLib
> +PlatformBuildLib.CommonPlatform = CommonPlatform

According to

  git show --find-copies-harder

this is a nearly identical copy of
"ArmVirtPkg/PlatformCI/KvmToolBuild.py", the only difference is:

-    DscName = os.path.join("ArmVirtPkg", "ArmVirtKvmTool.dsc")
+    DscName = os.path.join("ArmVirtPkg", "ArmVirtCloudHv.dsc")

It makes sense to me, but (a) this could have been documented in the
commit message; (b) the patch could have been formatted with
--find-copies-harder (and, indeed that option does not interfere with
patch application, as long as the --base=master option is also given to
git-format-patch -- then we know exactly where to check out a local
branch for applying the patch, and to rebase from.)

Anyway:

Reviewed-by: Laszlo Ersek <lersek@redhat.com>



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#111417): https://edk2.groups.io/g/devel/message/111417
Mute This Topic: https://groups.io/mt/102600602/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/1913456212/xyzzy [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



  reply	other threads:[~2023-11-17 21:54 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-15  6:20 [edk2-devel] [PATCH] CloudHv: Add CI for CloudHv on AArch64 Jianyong Wu
2023-11-17 21:53 ` Laszlo Ersek [this message]
2023-11-20  7:14   ` Jianyong Wu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1ba8e2fd-3618-1d46-1c85-89da0f689878@redhat.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox