From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 34D9D78003C for ; Fri, 17 Nov 2023 21:54:01 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=6DEUBlaex12J/uog0Irnn/DQl8bndZOsO5QKu6BFXyU=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1700258039; v=1; b=U0oMUzfoHefU7omyLVsp5z+EZDeXYSZSeZ9GZ7Z9U4gfaWo6gSbY2b5eBWACcKaiX9WUKQ+b aJd/drOhct68ZBADXR1hzaU/RVWStrRIm2rF3LpguWxCpr9waja+QzIxd3hIYEurrm8masyo8hc pCF2xN1l1tr7xUKTnPd+MezM= X-Received: by 127.0.0.2 with SMTP id WeSBYY7687511xQ7fxLYvMD1; Fri, 17 Nov 2023 13:53:59 -0800 X-Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.groups.io with SMTP id smtpd.web10.8783.1700258038885522123 for ; Fri, 17 Nov 2023 13:53:59 -0800 X-Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-186-GlO1PvTLNIW_iJvpemMB4Q-1; Fri, 17 Nov 2023 16:53:54 -0500 X-MC-Unique: GlO1PvTLNIW_iJvpemMB4Q-1 X-Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 0D26E821983; Fri, 17 Nov 2023 21:53:54 +0000 (UTC) X-Received: from [10.39.192.39] (unknown [10.39.192.39]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 07CDDC15881; Fri, 17 Nov 2023 21:53:52 +0000 (UTC) Message-ID: <1ba8e2fd-3618-1d46-1c85-89da0f689878@redhat.com> Date: Fri, 17 Nov 2023 22:53:51 +0100 MIME-Version: 1.0 Subject: Re: [edk2-devel] [PATCH] CloudHv: Add CI for CloudHv on AArch64 To: devel@edk2.groups.io, jianyong.wu@arm.com, Sami.Mujawar@arm.com Cc: ardb+tianocore@kernel.org References: <20231115062025.513379-1-jianyong.wu@arm.com> From: "Laszlo Ersek" In-Reply-To: <20231115062025.513379-1-jianyong.wu@arm.com> X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.8 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,lersek@redhat.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: 7nx3D0LvWrMHBMVT4UiSjttsx7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=U0oMUzfo; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=redhat.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On 11/15/23 07:20, Jianyong Wu wrote: > Add the long lost CI for CloudHv on AArch64. >=20 > Signed-off-by: Jianyong Wu > --- > .../.azurepipelines/Ubuntu-GCC5.yml | 13 ++++++++ > ArmVirtPkg/PlatformCI/CloudHvBuild.py | 32 +++++++++++++++++++ > 2 files changed, 45 insertions(+) > create mode 100644 ArmVirtPkg/PlatformCI/CloudHvBuild.py Please format and document patches such that they are easier to review. Otherwise reviewers have to dig too much. >=20 > diff --git a/ArmVirtPkg/PlatformCI/.azurepipelines/Ubuntu-GCC5.yml b/ArmV= irtPkg/PlatformCI/.azurepipelines/Ubuntu-GCC5.yml > index d1772a65fc..ab8a2db530 100644 > --- a/ArmVirtPkg/PlatformCI/.azurepipelines/Ubuntu-GCC5.yml > +++ b/ArmVirtPkg/PlatformCI/.azurepipelines/Ubuntu-GCC5.yml > @@ -140,6 +140,19 @@ jobs: > Build.Target: "RELEASE" > Run: false > =20 > + CLOUDHV_AARCH64_DEBUG: > + Build.File: "$(package)/PlatformCI/CloudHvBuild.py" > + Build.Arch: "AARCH64" > + Build.Flags: "" > + Build.Target: "DEBUG" > + Run: false > + CLOUDHV_AARCH64_RELEASE: > + Build.File: "$(package)/PlatformCI/CloudHvBuild.py" > + Build.Arch: "AARCH64" > + Build.Flags: "" > + Build.Target: "RELEASE" > + Run: false > + > workspace: > clean: all > =20 This seems like a copy of the KVMTOOL stanzas, except with (a) ARM removed, (b) KVMTOOL replaced by CLOUDHV, (c) KvmToolBuild.py replaced with CloudHvBuild.py. OK. > diff --git a/ArmVirtPkg/PlatformCI/CloudHvBuild.py b/ArmVirtPkg/PlatformC= I/CloudHvBuild.py > new file mode 100644 > index 0000000000..0192cd6577 > --- /dev/null > +++ b/ArmVirtPkg/PlatformCI/CloudHvBuild.py > @@ -0,0 +1,32 @@ > +# @file > +# Script to Build ArmVirtPkg UEFI firmware > +# > +# Copyright (c) Microsoft Corporation. > +# SPDX-License-Identifier: BSD-2-Clause-Patent > +## > +import os > +import sys > + > +sys.path.append(os.path.dirname(os.path.abspath(__file__))) > +from PlatformBuildLib import SettingsManager > +from PlatformBuildLib import PlatformBuilder > + > + # ##################################################################= ##################### # > + # Common Configuration = # > + # ##################################################################= ##################### # > +class CommonPlatform(): > + ''' Common settings for this platform. Define static data here and = use > + for the different parts of stuart > + ''' > + PackagesSupported =3D ("ArmVirtPkg",) > + ArchSupported =3D ("AARCH64", "ARM") > + TargetsSupported =3D ("DEBUG", "RELEASE") > + Scopes =3D ('armvirt', 'edk2-build') > + WorkspaceRoot =3D os.path.realpath(os.path.join( > + os.path.dirname(os.path.abspath(__file__)), "..", "..")) > + > + DscName =3D os.path.join("ArmVirtPkg", "ArmVirtCloudHv.dsc") > + FvQemuArg =3D "" # ignored > + > +import PlatformBuildLib > +PlatformBuildLib.CommonPlatform =3D CommonPlatform According to git show --find-copies-harder this is a nearly identical copy of "ArmVirtPkg/PlatformCI/KvmToolBuild.py", the only difference is: - DscName =3D os.path.join("ArmVirtPkg", "ArmVirtKvmTool.dsc") + DscName =3D os.path.join("ArmVirtPkg", "ArmVirtCloudHv.dsc") It makes sense to me, but (a) this could have been documented in the commit message; (b) the patch could have been formatted with --find-copies-harder (and, indeed that option does not interfere with patch application, as long as the --base=3Dmaster option is also given to git-format-patch -- then we know exactly where to check out a local branch for applying the patch, and to rebase from.) Anyway: Reviewed-by: Laszlo Ersek -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#111417): https://edk2.groups.io/g/devel/message/111417 Mute This Topic: https://groups.io/mt/102600602/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/19134562= 12/xyzzy [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-