From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.81]) by mx.groups.io with SMTP id smtpd.web11.6695.1588078518379501588 for ; Tue, 28 Apr 2020 05:55:18 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=epaF4oMj; spf=pass (domain: redhat.com, ip: 207.211.31.81, mailfrom: philmd@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1588078517; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=TDbQxreO3x/PD3VhvRwgJ4RhX0bJO0vXbQwoQh14co8=; b=epaF4oMjQBubDBPsiDqw9c8UVP0mJ5rTRbTX99NvbXLpLukZo8FCYOPFIwwmic9qjjSHqE sjBX5xlEk8L62/pb0TprJmNMtojPgCpoOqanWh8b3kbT3TZUogY/WzeyucLIJV3Ty+nHjX I4YXz/1di/FzlcZ6zD1ROasnvDAi4AU= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-463-rF_byH7aPJGHbVgX0YnWew-1; Tue, 28 Apr 2020 08:55:15 -0400 X-MC-Unique: rF_byH7aPJGHbVgX0YnWew-1 Received: by mail-wr1-f72.google.com with SMTP id f4so10838566wrp.14 for ; Tue, 28 Apr 2020 05:55:15 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=GWNdUZxbuyHG1nONpkTTXqrI4M8FqtxZRX3mAZ56aE0=; b=g3nvVQ3/wUh3Ut79B3Wk9xPEdXqe163Z7EO5a4Jd4nhFiHtJ1zIlMOeaZDDXWQu3Cl USHwo4h1AmP8IZX4gUX0ctIBsRBagNvLXbUC9YEKs3LDKgsDLLak9/gz7ZfNVlP8gLrV wEJFNevEkRDhbuP3gEKaQewtCEaq1yVgKhL64xWxPV0xMutpR/NxtR4VRkY0vP/j4w3Y 2aNF3hC8ENFhSccWltnAqG7QWC7i8DpJ2NfIZ9rH3DNQVnnW51Lprxkgnq0GS/vA1rPM TDRPNwv6m2536FI0f1jY4RrMFraO4L11NSa5NQQF7UBVhdVGIaJBPMxgaRYgnICx9dAV CDnw== X-Gm-Message-State: AGi0PuYmfmWMaCmP5Qd7ppwVKyxcXK/3CDrXh+IF/tsyibR9+9aYEaOI GXC0qdWU7pmQqrUl0KYQgHO4G6iEawPx0KZX3LOpyRx2tGXuBgn7wzGst4unTN+d69pi6lOiQWc aodPREIoM53MC4g== X-Received: by 2002:a5d:42c7:: with SMTP id t7mr32696203wrr.336.1588078514735; Tue, 28 Apr 2020 05:55:14 -0700 (PDT) X-Google-Smtp-Source: APiQypI+Am3V3YgzXUq1Z0yNVPEK5/YU67zfSGdT8EXyfu8fEgslpBNGo50mrbVOCB0vcPg1rTHtjQ== X-Received: by 2002:a5d:42c7:: with SMTP id t7mr32696178wrr.336.1588078514486; Tue, 28 Apr 2020 05:55:14 -0700 (PDT) Return-Path: Received: from [192.168.1.39] (137.red-88-21-205.staticip.rima-tde.net. [88.21.205.137]) by smtp.gmail.com with ESMTPSA id f23sm3136917wml.4.2020.04.28.05.55.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 28 Apr 2020 05:55:13 -0700 (PDT) Subject: Re: [edk2-devel] [PATCH] OvmfPkg: replace old EFI_D_ debug levels with new DEBUG_ ones To: Laszlo Ersek , devel@edk2.groups.io, rebecca@bsdio.com Cc: Jordan Justen , Ard Biesheuvel References: <20200424221707.183492-1-rebecca@bsdio.com> <6969918a-0948-559e-7679-ba94e8f3bfd8@redhat.com> From: =?UTF-8?B?UGhpbGlwcGUgTWF0aGlldS1EYXVkw6k=?= Message-ID: <1ba99f92-095c-b41e-950a-145d43444306@redhat.com> Date: Tue, 28 Apr 2020 14:55:12 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=WINDOWS-1252; format=flowed Content-Transfer-Encoding: quoted-printable On 4/28/20 2:44 PM, Laszlo Ersek wrote: > On 04/27/20 10:56, Philippe Mathieu-Daud=E9 wrote: >> On 4/25/20 12:17 AM, Rebecca Cran wrote: >>> Signed-off-by: Rebecca Cran >>> Cc: Jordan Justen >>> Cc: Laszlo Ersek >>> Cc: Ard Biesheuvel >>> --- >>> =A0 OvmfPkg/AcpiPlatformDxe/EntryPoint.c=A0=A0=A0=A0=A0=A0=A0=A0=A0 |= =A0 8 +- >>> =A0 OvmfPkg/AcpiPlatformDxe/PciDecoding.c=A0=A0=A0=A0=A0=A0=A0=A0 | 10= +-- >>> =A0 OvmfPkg/AcpiPlatformDxe/QemuFwCfgAcpi.c=A0=A0=A0=A0=A0=A0 | 32 +++= +---- >>> =A0 OvmfPkg/Csm/BiosThunk/VideoDxe/BiosVideo.c=A0=A0=A0 | 16 ++-- >>> =A0 OvmfPkg/Csm/CsmSupportLib/LegacyInterrupt.c=A0=A0 |=A0 2 +- >>> =A0 OvmfPkg/Csm/CsmSupportLib/LegacyPlatform.c=A0=A0=A0 |=A0 2 +- >>> =A0 OvmfPkg/Csm/CsmSupportLib/LegacyRegion.c=A0=A0=A0=A0=A0 |=A0 2 +- >>> =A0 OvmfPkg/Csm/LegacyBiosDxe/LegacyBios.c=A0=A0=A0=A0=A0=A0=A0 | 18 += +--- >>> =A0 OvmfPkg/Csm/LegacyBiosDxe/LegacyBootSupport.c | 80 +++++++++------= ---- >>> =A0 OvmfPkg/Csm/LegacyBiosDxe/LegacyPci.c=A0=A0=A0=A0=A0=A0=A0=A0 | 62= +++++++------- >>> =A0 OvmfPkg/Csm/LegacyBiosDxe/LegacySio.c=A0=A0=A0=A0=A0=A0=A0=A0 |=A0= 2 +- >>> =A0 OvmfPkg/Csm/LegacyBiosDxe/Thunk.c=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0= =A0 |=A0 2 +- >>> =A0 .../LegacyBootMaintUiLib/LegacyBootMaintUi.c=A0 |=A0 2 +- >>> =A0 OvmfPkg/Csm/LegacyBootManagerLib/LegacyBm.c=A0=A0 |=A0 6 +- >>> =A0 OvmfPkg/EmuVariableFvbRuntimeDxe/Fvb.c=A0=A0=A0=A0=A0=A0=A0 | 16 += +-- >>> =A0 .../IncompatiblePciDeviceSupport.c=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0= =A0 |=A0 2 +- >>> =A0 .../Library/AcpiTimerLib/BaseAcpiTimerLib.c=A0=A0 |=A0 2 +- >>> =A0 .../AcpiTimerLib/BaseRomAcpiTimerLib.c=A0=A0=A0=A0=A0=A0=A0 |=A0 4= +- >>> =A0 .../Library/AcpiTimerLib/DxeAcpiTimerLib.c=A0=A0=A0 |=A0 2 +- >>> =A0 OvmfPkg/Library/LoadLinuxLib/Linux.c=A0=A0=A0=A0=A0=A0=A0=A0=A0 |= =A0 8 +- >>> =A0 OvmfPkg/Library/NvVarsFileLib/FsAccess.c=A0=A0=A0=A0=A0 | 16 ++-- >>> =A0 .../PciHostBridgeLib/PciHostBridgeLib.c=A0=A0=A0=A0=A0=A0 | 18 ++-= -- >>> =A0 .../PlatformBootManagerLib/BdsPlatform.c=A0=A0=A0=A0=A0 | 30 +++--= -- >>> =A0 OvmfPkg/Library/QemuFwCfgLib/QemuFwCfgDxe.c=A0=A0 |=A0 6 +- >>> =A0 OvmfPkg/Library/QemuFwCfgLib/QemuFwCfgLib.c=A0=A0 |=A0 2 +- >>> =A0 OvmfPkg/Library/QemuFwCfgLib/QemuFwCfgPei.c=A0=A0 |=A0 6 +- >>> =A0 OvmfPkg/Library/QemuFwCfgLib/QemuFwCfgSec.c=A0=A0 |=A0 8 +- >>> =A0 .../SerializeVariablesLib.c=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0= =A0=A0=A0=A0=A0 |=A0 2 +- >>> =A0 .../SmbiosVersionLib/DetectSmbiosVersionLib.c |=A0 4 +- >>> =A0 .../VirtioMmioDeviceLib/VirtioMmioDevice.c=A0=A0=A0 |=A0 2 +- >>> =A0 .../Library/XenHypercallLib/XenHypercall.c=A0=A0=A0 |=A0 2 +- >>> =A0 OvmfPkg/Library/XenIoMmioLib/XenIoMmioLib.c=A0=A0 |=A0 4 +- >>> =A0 OvmfPkg/PlatformDxe/Platform.c=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0= =A0=A0=A0 |=A0 6 +- >>> =A0 OvmfPkg/PlatformPei/FeatureControl.c=A0=A0=A0=A0=A0=A0=A0=A0=A0 |= =A0 4 +- >>> =A0 OvmfPkg/PlatformPei/Fv.c=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0= =A0=A0=A0=A0=A0=A0=A0 |=A0 2 +- >>> =A0 OvmfPkg/PlatformPei/MemDetect.c=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0= =A0=A0=A0 | 10 +-- >>> =A0 OvmfPkg/PlatformPei/Platform.c=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0= =A0=A0=A0 | 22 ++--- >>> =A0 OvmfPkg/PlatformPei/Xen.c=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0= =A0=A0=A0=A0=A0=A0=A0 |=A0 4 +- >>> =A0 .../FwBlockService.c=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0= =A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 | 10 +-- >>> =A0 .../FwBlockServiceDxe.c=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0= =A0=A0=A0=A0=A0=A0=A0=A0 |=A0 4 +- >>> =A0 .../FwBlockServiceSmm.c=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0= =A0=A0=A0=A0=A0=A0=A0=A0 |=A0 2 +- >>> =A0 .../QemuFlash.c=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0= =A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 | 14 ++-- >>> =A0 OvmfPkg/QemuVideoDxe/Driver.c=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0= =A0=A0=A0=A0 | 10 +-- >>> =A0 OvmfPkg/QemuVideoDxe/Gop.c=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0= =A0=A0=A0=A0=A0=A0 |=A0 4 +- >>> =A0 OvmfPkg/QemuVideoDxe/Initialize.c=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0= =A0 |=A0 8 +- >>> =A0 OvmfPkg/QemuVideoDxe/VbeShim.c=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0= =A0=A0=A0 |=A0 4 +- >>> =A0 OvmfPkg/SataControllerDxe/SataController.c=A0=A0=A0 | 12 +-- >>> =A0 OvmfPkg/Sec/SecMain.c=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0= =A0=A0=A0=A0=A0=A0=A0=A0=A0 | 22 ++--- >>> =A0 OvmfPkg/SmmAccess/SmmAccessPei.c=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0= =A0=A0 |=A0 4 +- >>> =A0 OvmfPkg/SmmControl2Dxe/SmmControl2Dxe.c=A0=A0=A0=A0=A0=A0 | 16 ++-= - >>> =A0 OvmfPkg/VirtioGpuDxe/Commands.c=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0= =A0=A0=A0 |=A0 8 +- >>> =A0 OvmfPkg/VirtioGpuDxe/DriverBinding.c=A0=A0=A0=A0=A0=A0=A0=A0=A0 |= =A0 8 +- >>> =A0 OvmfPkg/VirtioGpuDxe/VirtioGpu.h=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0= =A0=A0 |=A0 2 +- >>> =A0 OvmfPkg/XenBusDxe/EventChannel.c=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0= =A0=A0 |=A0 2 +- >>> =A0 OvmfPkg/XenBusDxe/GrantTable.c=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0= =A0=A0=A0 |=A0 8 +- >>> =A0 OvmfPkg/XenBusDxe/XenBus.c=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0= =A0=A0=A0=A0=A0=A0 | 14 ++-- >>> =A0 OvmfPkg/XenBusDxe/XenBusDxe.c=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0= =A0=A0=A0=A0 |=A0 4 +- >>> =A0 OvmfPkg/XenBusDxe/XenStore.c=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0= =A0=A0=A0=A0=A0 | 28 +++---- >>> =A0 OvmfPkg/XenIoPciDxe/XenIoPciDxe.c=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0= =A0 |=A0 2 +- >>> =A0 OvmfPkg/XenPvBlkDxe/BlockFront.c=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0= =A0=A0 | 50 ++++++------ >>> =A0 OvmfPkg/XenPvBlkDxe/BlockIo.c=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0= =A0=A0=A0=A0 |=A0 6 +- >>> =A0 OvmfPkg/XenPvBlkDxe/XenPvBlkDxe.c=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0= =A0 |=A0 2 +- >>> =A0 62 files changed, 335 insertions(+), 335 deletions(-) >> >> Reviewed-by: Philippe Mathieu-Daude >> >=20 > Thanks Phil, I will take your word on this one. >=20 > I was ready to reject this patch, in this "unstructured dump" form, but > I trust your review. TBH as this is a mechanical patch I first skimmed at the patch, then did: $ git grep EFI_D_INFO OvmfPkg/|wc -l 188 $ fgrep EFI_D_INFO patch.eml|wc -l 188 $ fgrep DEBUG_INFO patch.eml|wc -l 188 and verified indent is identical with: $ echo EFI_D_WARN|wc -c 11 $ echo DEBUG_WARN|wc -c 11 >=20 > Hence: >=20 > Acked-by: Laszlo Ersek >=20 > Rebecca: thanks for the contribution. Personally I'd have preferred a > finer-grained approach here, but Phil removed the review burden on me. >=20 > Regarding the git history, edk2 unfortunately alreay carries a bunch of > similarly large (even huge) coding style update patches, so I I can't > hold that perspective against the patch. >=20 > Thanks, > Laszlo >=20