From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f45.google.com (mail-lf1-f45.google.com [209.85.167.45]) by mx.groups.io with SMTP id smtpd.web11.14670.1682089150190661623 for ; Fri, 21 Apr 2023 07:59:10 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="signature has expired" header.i=@linaro.org header.s=google header.b=OwGoIHxH; spf=pass (domain: linaro.org, ip: 209.85.167.45, mailfrom: marcin.juszkiewicz@linaro.org) Received: by mail-lf1-f45.google.com with SMTP id 2adb3069b0e04-4ec817735a7so1766984e87.3 for ; Fri, 21 Apr 2023 07:59:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1682089148; x=1684681148; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=Bp0DstSFwQzYAH/sUq68ueSuAG1rgnVGIiZLQ4f4CHY=; b=OwGoIHxHsttjpx9kWajUXytSChjFnujCa4AurDR9mVNE0jnT0WlPnelQVSMJ0ea21g aQ1MgWekAXr8QaP4elGMm1DgDpodJNKz2HhX2faIoWSAToJ1R9WlsClSCiR1KERHv5ES +OqlciybZrYJKVdzZE5dI78ekq1GOPyN4UOllqg3vFD65xgNoGaQTvKTuQ+ynf9/h4WM Rt70cffrAylH2m29a+DK683hWsosPUPmkxB4sSqegSD2sKEX4dv9YUeU/rtBVKrhy1/7 PTbK3v8gtWaTnu/xevddiag7xzH+LeYfCLK4Uj9/JoMr/XLqBrfDMEab1kWxtqa8pwBK OcSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682089148; x=1684681148; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Bp0DstSFwQzYAH/sUq68ueSuAG1rgnVGIiZLQ4f4CHY=; b=Xsv5hLs9wgyAubNAhpLk0nk1r+IcONcEOXUcst45eo21qPzjXq8gl8jQaPcCE9LOs7 Azuabbd98+2WC7v+hNDcE2NgpiUKT2PNNetuX2+olythGeXZ0M3hS47o5JE6tpfSamPg WEtc5Wg7Nfa4kGDG6DMXESrGZ5wmitaH2JFUhC7ahYs+WakJl7mWMo4cNV+RMozR+jeb 3gPqQ1YDxxsyXB3loO3uZlD2LyCeeNIOvMF058UP5bVHWr1IJGPEzDhKVReh5HqyucBH j/7eMrPVd90dvk1xT4eNtSVEtY3+kjLfrTEN2UvBnfC7wbTpf+m+szkKsZ07naXtEPS+ hvrg== X-Gm-Message-State: AAQBX9dgNDutFb7KjhJdkHCfmCmq47vUonG42GyXFhtBSPnSMgunywfs y2KxZojC6mVZg8nXFCHuwevc4Q== X-Google-Smtp-Source: AKy350bZpUs/nwX1vtu99IeQCvG+z6z+o6Ta9F+nmKUhdA9wrCCeVg36n7UTEKPdnBCWxiUOm9mA/A== X-Received: by 2002:ac2:4891:0:b0:4ec:8d97:9479 with SMTP id x17-20020ac24891000000b004ec8d979479mr1320400lfc.20.1682089148424; Fri, 21 Apr 2023 07:59:08 -0700 (PDT) Return-Path: Received: from [192.168.200.206] (83.11.213.14.ipv4.supernova.orange.pl. [83.11.213.14]) by smtp.gmail.com with ESMTPSA id q17-20020ac25111000000b004eee27b293bsm352056lfb.298.2023.04.21.07.59.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 21 Apr 2023 07:59:08 -0700 (PDT) Message-ID: <1bdb2272-b5bc-fa76-9e7f-0be48ba36553@linaro.org> Date: Fri, 21 Apr 2023 16:59:07 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [edk2-devel] [PATCH v6 2/2] add ArmCpuInfo EFI application To: Rebecca Cran , devel@edk2.groups.io, quic_llindhol@quicinc.com Cc: Ard Biesheuvel , Pedro Falcato References: <20230420144423.70726-1-marcin.juszkiewicz@linaro.org> <20230420144423.70726-2-marcin.juszkiewicz@linaro.org> <98e2cf1d-f0df-0975-13e1-05e40760d7c4@bsdio.com> From: "Marcin Juszkiewicz" Organization: Linaro In-Reply-To: <98e2cf1d-f0df-0975-13e1-05e40760d7c4@bsdio.com> Content-Language: pl-PL, en-GB, en-HK Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit W dniu 21.04.2023 o 16:37, Rebecca Cran pisze: > I noticed CI failed for the push PR > (https://github.com/tianocore/edk2/pull/4292). > > > Ecc is complaining about missing Doxygen info for the functions: > > https://dev.azure.com/tianocore/edk2-ci/_build/results?buildId=88023&view=logs&j=d36e2059-ab45-57a4-e2a1-e73032481054&t=463dc808-035c-5fe4-17fd-50a99c74a4aa > And it looks like there might be Uncrustify problems too: > https://dev.azure.com/tianocore/edk2-ci/_build/results?buildId=88024&view=logs&jobId=2640d2b2-7c53-5a2b-80c7-040377c664fd&j=2640d2b2-7c53-5a2b-80c7-040377c664fd&t=a7f329c1-489d-56ab-b670-1c248e984338 Thanks for links. Interface for EDK2 CI is not easy for beginners. Uncrustify dislikes enum. Easy to fix as those are only spaces. Doxygen info is something I probably never wrote so would need to look at rest of EDK2 code to find out what it is and how to use it. There is also this: > ERROR - EFI coding style error > ERROR - *Error code: 9001 > ERROR - *The file headers should follow Doxygen special > documentation blocks in section 2.3.5 > ERROR - *file: D:\a\1\s\Build\.pytool\Plugin\EccCheck\ArmPkg > \Application\ArmCpuInfo\ArmCpuInfo.inf > ERROR - *Line number: 1 > ERROR - *Header comment section must have Abstract information. Same situation as with Doxygen above.