From: Laszlo Ersek <lersek@redhat.com>
To: Shenglei Zhang <shenglei.zhang@intel.com>, edk2-devel@lists.01.org
Cc: Liming Gao <liming.gao@intel.com>
Subject: Re: [PATCH 09/10] BaseTools/tools_def.template: Remove CYGGCC
Date: Fri, 1 Feb 2019 09:58:10 +0100 [thread overview]
Message-ID: <1be8be5c-ccfe-77e8-c376-9162564e48af@redhat.com> (raw)
In-Reply-To: <20190201053445.13660-10-shenglei.zhang@intel.com>
On 02/01/19 06:34, Shenglei Zhang wrote:
> CYGGCC is too old.There is no verification for it.
> https://bugzilla.tianocore.org/show_bug.cgi?id=1377
>
> Cc: Bob Feng <bob.c.feng@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> Cc: Yonghong Zhu <yonghong.zhu@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
> ---
> BaseTools/Conf/tools_def.template | 203 ------------------------------
> 1 file changed, 203 deletions(-)
>
> diff --git a/BaseTools/Conf/tools_def.template b/BaseTools/Conf/tools_def.template
> index 0e671d55bc..e2718a1354 100755
> --- a/BaseTools/Conf/tools_def.template
> +++ b/BaseTools/Conf/tools_def.template
> @@ -295,15 +295,6 @@ DEFINE DTC_BIN = ENV(DTC_PREFIX)dtc
> # Required to build platforms or ACPI tables:
> # Intel(r) ACPI Compiler from
> # https://acpica.org/downloads
> -# CYGGCC -win32- Requires:
> -# CygWin, GCC 4.3.0, binutils 2.20.51.0.5
> -# Microsoft Visual Studio 2005 or 2008
> -# Optional:
> -# Required to build EBC drivers:
> -# Intel(r) Compiler for Efi Byte Code (Intel(r) EBC Compiler)
> -# Required to build platforms or ACPI tables:
> -# Intel(r) ACPI Compiler (iasl.exe) from
> -# https://acpica.org/downloads
> # ICC -win32- Requires:
> # Intel C Compiler V9.1
> # Dependencies:
> @@ -373,15 +364,6 @@ DEFINE DTC_BIN = ENV(DTC_PREFIX)dtc
> # Required to build platforms or ACPI tables:
> # Microsoft ASL ACPI Compiler (asl.exe) v4.0.0 from
> # http://download.microsoft.com/download/2/c/1/2c16c7e0-96c1-40f5-81fc-3e4bf7b65496/microsoft_asl_compiler-v4-0-0.msi
> -# CYGGCCxASL -win32- Requires:
> -# CygWin, GCC 4.3.0, binutils 2.20.51.0.5
> -# Microsoft Visual Studio 2005 or 2008
> -# Optional:
> -# Required to build EBC drivers:
> -# Intel(r) Compiler for Efi Byte Code (Intel(r) EBC Compiler)
> -# Required to build platforms or ACPI tables:
> -# Microsoft ASL ACPI Compiler (asl.exe) v4.0.0 from
> -# http://download.microsoft.com/download/2/c/1/2c16c7e0-96c1-40f5-81fc-3e4bf7b65496/microsoft_asl_compiler-v4-0-0.msi
> # ICCxASL -win32- Requires:
> # Intel C Compiler V9.1
> # Dependencies:
> @@ -524,24 +506,6 @@ DEFINE DTC_BIN = ENV(DTC_PREFIX)dtc
> # Required to build platforms or ACPI tables:
> # Microsoft ASL ACPI Compiler (asl.exe) v4.0.0 from
> # http://download.microsoft.com/download/2/c/1/2c16c7e0-96c1-40f5-81fc-3e4bf7b65496/microsoft_asl_compiler-v4-0-0.msi
> -# CYGGCCx86 -win64- Requires:
> -# CygWin, GCC 4.3.0, binutils 2.20.51.0.5
> -# Microsoft Visual Studio 2005 or 2008
> -# Optional:
> -# Required to build EBC drivers:
> -# Intel(r) Compiler for Efi Byte Code (Intel(r) EBC Compiler)
> -# Required to build platforms or ACPI tables:
> -# Intel(r) ACPI Compiler (iasl.exe) from
> -# https://acpica.org/downloads
> -# CYGGCCx86xASL -win64- Requires:
> -# CygWin, GCC 4.3.0, binutils 2.20.51.0.5
> -# Microsoft Visual Studio 2005 or 2008
> -# Optional:
> -# Required to build EBC drivers:
> -# Intel(r) Compiler for Efi Byte Code (Intel(r) EBC Compiler)
> -# Required to build platforms or ACPI tables:
> -# Microsoft ASL ACPI Compiler (asl.exe) v4.0.0 from
> -# http://download.microsoft.com/download/2/c/1/2c16c7e0-96c1-40f5-81fc-3e4bf7b65496/microsoft_asl_compiler-v4-0-0.msi
> # RVCT -win- Requires:
> # ARM C/C++ Compiler, 5.00
> # Optional:
> @@ -3824,173 +3788,6 @@ DEFINE CLANG38_AARCH64_DLINK_FLAGS = DEF(CLANG38_AARCH64_TARGET) DEF(GCC_AARCH6
> RELEASE_CLANG38_AARCH64_CC_FLAGS = DEF(CLANG38_AARCH64_CC_FLAGS) $(ARCHCC_FLAGS) $(PLATFORM_FLAGS) -flto -O3
> RELEASE_CLANG38_AARCH64_DLINK_FLAGS = DEF(CLANG38_AARCH64_DLINK_FLAGS) -flto -Wl,-O3 -L$(WORKSPACE)/ArmPkg/Library/GccLto -llto-aarch64 -Wl,-plugin-opt=-pass-through=-llto-aarch64
>
> -####################################################################################
> -#
> -# Cygwin GCC And Intel ACPI Compiler
> -#
> -####################################################################################
> -# CYGGCC - CygWin GCC
> -# ASL - Intel ACPI Source Language Compiler (iasl.exe)
> -*_CYGGCC_*_*_FAMILY = GCC
> -*_CYGGCC_*_*_BUILDRULEFAMILY = GCCLD
> -
> -*_CYGGCC_*_*_DLL = DEF(CYGWIN_BIN)
> -*_CYGGCC_*_MAKE_PATH = DEF(MS_VS_BIN)\nmake.exe
> -*_CYGGCC_*_ASL_PATH = DEF(DEFAULT_WIN_ASL_BIN)
> -
> -*_CYGGCC_IA32_DLINK_FLAGS = DEF(GCC_IA32_X64_DLINK_FLAGS) --image-base=0
> -*_CYGGCC_X64_DLINK_FLAGS = DEF(GCC_IA32_X64_DLINK_FLAGS) --image-base=0
> -*_CYGGCC_IA32_ASLDLINK_FLAGS = DEF(GCC_IA32_X64_ASLDLINK_FLAGS)
> -*_CYGGCC_X64_ASLDLINK_FLAGS = DEF(GCC_IA32_X64_ASLDLINK_FLAGS)
> -*_CYGGCC_*_MAKE_FLAGS = /nologo
> -*_CYGGCC_*_ASM_FLAGS = DEF(GCC_ASM_FLAGS)
> -*_CYGGCC_*_PP_FLAGS = DEF(GCC_PP_FLAGS)
> -*_CYGGCC_*_ASLPP_FLAGS = DEF(GCC_ASLPP_FLAGS)
> -*_CYGGCC_*_ASLCC_FLAGS = DEF(GCC_ASLCC_FLAGS)
> -*_CYGGCC_*_VFRPP_FLAGS = DEF(GCC_VFRPP_FLAGS)
> -*_CYGGCC_*_APP_FLAGS =
> -*_CYGGCC_*_ASL_FLAGS = DEF(DEFAULT_WIN_ASL_FLAGS)
> -*_CYGGCC_*_ASL_OUTFLAGS = DEF(DEFAULT_WIN_ASL_OUTFLAGS)
> -
> -##################
> -# IA32 definitions
> -##################
> -*_CYGGCC_IA32_CC_PATH = DEF(CYGWIN_BINIA32)gcc
> -*_CYGGCC_IA32_SLINK_PATH = DEF(CYGWIN_BINIA32)ar
> -*_CYGGCC_IA32_DLINK_PATH = DEF(CYGWIN_BINIA32)ld
> -*_CYGGCC_IA32_ASM_PATH = DEF(CYGWIN_BINIA32)gcc
> -*_CYGGCC_IA32_PP_PATH = DEF(CYGWIN_BINIA32)gcc
> -*_CYGGCC_IA32_APP_PATH = DEF(CYGWIN_BINIA32)gcc
> -*_CYGGCC_IA32_VFRPP_PATH = DEF(CYGWIN_BINIA32)gcc
> -*_CYGGCC_IA32_ASLCC_PATH = DEF(CYGWIN_BINIA32)gcc
> -*_CYGGCC_IA32_ASLPP_PATH = DEF(CYGWIN_BINIA32)gcc
> -*_CYGGCC_IA32_ASLDLINK_PATH = DEF(CYGWIN_BINIA32)ld
> -*_CYGGCC_IA32_RC_PATH = DEF(CYGWIN_BINIA32)objcopy
> -*_CYGGCC_IA32_OBJCOPY_PATH = DEF(CYGWIN_BINIA32)objcopy
> -
> -*_CYGGCC_IA32_CC_FLAGS = DEF(GCC_IA32_CC_FLAGS)
> -*_CYGGCC_IA32_RC_FLAGS = DEF(GCC_IA32_RC_FLAGS)
> -*_CYGGCC_IA32_OBJCOPY_FLAGS =
> -*_CYGGCC_IA32_NASM_FLAGS = -f win32
> -
> -##################
> -# X64 definitions
> -##################
> -*_CYGGCC_X64_CC_PATH = DEF(CYGWIN_BINX64)gcc
> -*_CYGGCC_X64_SLINK_PATH = DEF(CYGWIN_BINX64)ar
> -*_CYGGCC_X64_DLINK_PATH = DEF(CYGWIN_BINX64)ld
> -*_CYGGCC_X64_ASM_PATH = DEF(CYGWIN_BINX64)gcc
> -*_CYGGCC_X64_PP_PATH = DEF(CYGWIN_BINX64)gcc
> -*_CYGGCC_X64_APP_PATH = DEF(CYGWIN_BINX64)gcc
> -*_CYGGCC_X64_VFRPP_PATH = DEF(CYGWIN_BINX64)gcc
> -*_CYGGCC_X64_ASLCC_PATH = DEF(CYGWIN_BINX64)gcc
> -*_CYGGCC_X64_ASLPP_PATH = DEF(CYGWIN_BINX64)gcc
> -*_CYGGCC_X64_ASLDLINK_PATH = DEF(CYGWIN_BINX64)ld
> -*_CYGGCC_X64_RC_PATH = DEF(CYGWIN_BINX64)objcopy
> -*_CYGGCC_X64_OBJCOPY_PATH = DEF(CYGWIN_BINX64)objcopy
> -
> -*_CYGGCC_X64_CC_FLAGS = DEF(GCC_X64_CC_FLAGS)
> -*_CYGGCC_X64_RC_FLAGS = DEF(GCC_X64_RC_FLAGS)
> -*_CYGGCC_X64_OBJCOPY_FLAGS =
> -*_CYGGCC_X64_NASM_FLAGS = -f win64
> -
> -##################
> -# EBC definitions
> -##################
> -*_CYGGCC_EBC_*_FAMILY = INTEL
> -
> -*_CYGGCC_EBC_PP_PATH = DEF(EBC_BIN)\iec.exe
> -*_CYGGCC_EBC_CC_PATH = DEF(EBC_BIN)\iec.exe
> -*_CYGGCC_EBC_DLINK_PATH = DEF(EBC_BIN)\link.exe
> -*_CYGGCC_EBC_SLINK_PATH = DEF(EBC_BIN)\link.exe
> -*_CYGGCC_EBC_VFRPP_PATH = DEF(EBC_BIN)\iec.exe
> -*_CYGGCC_EBC_RC_PATH = DEF(MS_VS_BIN)\rc.exe
> -
> -*_CYGGCC_EBC_CC_FLAGS = /nologo /c /WX /W3 /FIAutoGen.h /D$(MODULE_ENTRY_POINT)=$(ARCH_ENTRY_POINT)
> -*_CYGGCC_EBC_SLINK_FLAGS = /lib /NOLOGO /MACHINE:EBC
> -*_CYGGCC_EBC_DLINK_FLAGS = "C:\Program Files\Intel\EBC\Lib\EbcLib.lib" /NOLOGO /NODEFAULTLIB /MACHINE:EBC /OPT:REF /ENTRY:$(IMAGE_ENTRY_POINT) /SUBSYSTEM:EFI_BOOT_SERVICE_DRIVER /ALIGN:32 /DRIVER
> -
> -####################################################################################
> -#
> -# Cygwin GCC And Microsoft ACPI Compiler
> -#
> -####################################################################################
> -# CYGGCCxASL - CygWin GCC
> -# ASL - Microsoft ACPI Source Language Compiler (asl.exe)
> -*_CYGGCCxASL_*_*_FAMILY = GCC
> -*_CYGGCCxASL_*_*_BUILDRULEFAMILY = GCCLD
> -
> -*_CYGGCCxASL_*_*_DLL = DEF(CYGWIN_BIN)
> -*_CYGGCCxASL_*_MAKE_PATH = DEF(MS_VS_BIN)\nmake.exe
> -
> -*_CYGGCCxASL_*_MAKE_FLAGS = /nologo
> -*_CYGGCCxASL_*_PP_FLAGS = -E -x assembler-with-cpp -include AutoGen.h
> -*_CYGGCCxASL_*_DLINK_FLAGS = -nostdlib -O2 --gc-sections --dll --export-all-symbols --entry _$(IMAGE_ENTRY_POINT) --file-alignment 0x20 --section-alignment 0x20
> -*_CYGGCCxASL_*_ASM_FLAGS = -c -x assembler -imacros AutoGen.h
> -*_CYGGCCxASL_*_APP_FLAGS = -E -x assembler
> -*_CYGGCCxASL_*_VFRPP_FLAGS = -x c -E -P -DVFRCOMPILE --include $(MODULE_NAME)StrDefs.h
> -
> -##################
> -# ASL definitions
> -##################
> -*_CYGGCCxASL_*_ASL_PATH = DEF(WIN_ASL_BIN)
> -*_CYGGCCxASL_*_ASL_FLAGS =
> -*_CYGGCCxASL_*_ASL_OUTFLAGS = DEF(MS_ASL_OUTFLAGS)
> -*_CYGGCCxASL_*_ASLCC_FLAGS = DEF(MSFT_ASLCC_FLAGS)
> -*_CYGGCCxASL_*_ASLPP_FLAGS = DEF(MSFT_ASLPP_FLAGS)
> -*_CYGGCCxASL_*_ASLDLINK_FLAGS = DEF(MSFT_ASLDLINK_FLAGS)
> -
> -##################
> -# IA32 definitions
> -##################
> -*_CYGGCCxASL_IA32_CC_PATH = DEF(CYGWIN_BINIA32)gcc
> -*_CYGGCCxASL_IA32_SLINK_PATH = DEF(CYGWIN_BINIA32)ar
> -*_CYGGCCxASL_IA32_DLINK_PATH = DEF(CYGWIN_BINIA32)ld
> -*_CYGGCCxASL_IA32_ASM_PATH = DEF(CYGWIN_BINIA32)gcc
> -*_CYGGCCxASL_IA32_PP_PATH = DEF(CYGWIN_BINIA32)gcc
> -*_CYGGCCxASL_IA32_APP_PATH = DEF(CYGWIN_BINIA32)gcc
> -*_CYGGCCxASL_IA32_VFRPP_PATH = DEF(CYGWIN_BINIA32)gcc
> -*_CYGGCCxASL_IA32_ASLCC_PATH = DEF(CYGWIN_BINIA32)gcc
> -*_CYGGCCxASL_IA32_ASLPP_PATH = DEF(CYGWIN_BINIA32)gcc
> -*_CYGGCCxASL_IA32_ASLDLINK_PATH = DEF(CYGWIN_BINIA32)ld
> -*_CYGGCCxASL_IA32_RC_PATH = DEF(CYGWIN_BINIA32)objcopy
> -
> -*_CYGGCCxASL_IA32_CC_FLAGS = DEF(GCC_IA32_CC_FLAGS)
> -*_CYGGCCxASL_IA32_RC_FLAGS = DEF(GCC_IA32_RC_FLAGS)
> -
> -##################
> -# X64 definitions
> -##################
> -*_CYGGCCxASL_X64_CC_PATH = DEF(CYGWIN_BINX64)gcc
> -*_CYGGCCxASL_X64_SLINK_PATH = DEF(CYGWIN_BINX64)ar
> -*_CYGGCCxASL_X64_DLINK_PATH = DEF(CYGWIN_BINX64)ld
> -*_CYGGCCxASL_X64_ASM_PATH = DEF(CYGWIN_BINX64)gcc
> -*_CYGGCCxASL_X64_PP_PATH = DEF(CYGWIN_BINX64)gcc
> -*_CYGGCCxASL_X64_APP_PATH = DEF(CYGWIN_BINX64)gcc
> -*_CYGGCCxASL_X64_VFRPP_PATH = DEF(CYGWIN_BINX64)gcc
> -*_CYGGCCxASL_X64_ASLCC_PATH = DEF(CYGWIN_BINX64)gcc
> -*_CYGGCCxASL_X64_ASLPP_PATH = DEF(CYGWIN_BINX64)gcc
> -*_CYGGCCxASL_X64_ASLDLINK_PATH = DEF(CYGWIN_BINX64)ld
> -*_CYGGCCxASL_X64_RC_PATH = DEF(CYGWIN_BINX64)objcopy
> -
> -*_CYGGCCxASL_X64_CC_FLAGS = DEF(GCC_X64_CC_FLAGS)
> -*_CYGGCCxASL_X64_RC_FLAGS = DEF(GCC_X64_RC_FLAGS)
> -
> -##################
> -# EBC definitions
> -##################
> -*_CYGGCCxASL_EBC_*_FAMILY = INTEL
> -
> -*_CYGGCCxASL_EBC_PP_PATH = DEF(EBC_BIN)\iec.exe
> -*_CYGGCCxASL_EBC_CC_PATH = DEF(EBC_BIN)\iec.exe
> -*_CYGGCCxASL_EBC_DLINK_PATH = DEF(EBC_BIN)\link.exe
> -*_CYGGCCxASL_EBC_SLINK_PATH = DEF(EBC_BIN)\link.exe
> -*_CYGGCCxASL_EBC_VFRPP_PATH = DEF(EBC_BIN)\iec.exe
> -*_CYGGCCxASL_EBC_RC_PATH = DEF(MS_VS_BIN)\rc.exe
> -
> -*_CYGGCCxASL_EBC_CC_FLAGS = /nologo /c /WX /W3 /FIAutoGen.h /D$(MODULE_ENTRY_POINT)=$(ARCH_ENTRY_POINT)
> -*_CYGGCCxASL_EBC_SLINK_FLAGS = /lib /NOLOGO /MACHINE:EBC
> -*_CYGGCCxASL_EBC_DLINK_FLAGS = "C:\Program Files\Intel\EBC\Lib\EbcLib.lib" /NOLOGO /NODEFAULTLIB /MACHINE:EBC /OPT:REF /ENTRY:$(IMAGE_ENTRY_POINT) /SUBSYSTEM:EFI_BOOT_SERVICE_DRIVER /ALIGN:32 /DRIVER
>
> ####################################################################################
> #
>
Reviewed-by: Laszlo Ersek <lersek@redhat.com>
next prev parent reply other threads:[~2019-02-01 8:58 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-01 5:34 [PATCH 00/10] Remove unused tool chain configuration Shenglei Zhang
2019-02-01 5:34 ` [PATCH 01/10] BaseTools/tools_def.template: Remove VS2003 and VS2005 Shenglei Zhang
2019-02-01 5:34 ` [PATCH 02/10] OptionRomPkg/ReadMe.txt: Remove VS2005 Shenglei Zhang
2019-02-01 5:34 ` [PATCH 03/10] BaseTools/tools_def.template: Remove DDK3790 Shenglei Zhang
2019-02-01 5:34 ` [PATCH 04/10] BaseTools/tools_def.template: Remove UNIXGCC Shenglei Zhang
2019-02-01 8:52 ` Laszlo Ersek
2019-02-01 5:34 ` [PATCH 05/10] OvmfPkg: Remove UNIXGCC in DSC files Shenglei Zhang
2019-02-01 8:53 ` Laszlo Ersek
2019-02-01 5:34 ` [PATCH 06/10] OvmfPkg/README: Remove UNIXGCC Shenglei Zhang
2019-02-01 8:55 ` Laszlo Ersek
2019-02-01 9:50 ` Philippe Mathieu-Daudé
2019-02-01 13:47 ` Laszlo Ersek
2019-02-01 5:34 ` [PATCH 07/10] BaseTools: Update MYTOOLS Shenglei Zhang
2019-02-01 5:34 ` [PATCH 08/10] BaseTools/tools_def.template: Remove ELFGCC Shenglei Zhang
2019-02-01 8:56 ` Laszlo Ersek
2019-02-01 5:34 ` [PATCH 09/10] BaseTools/tools_def.template: Remove CYGGCC Shenglei Zhang
2019-02-01 8:58 ` Laszlo Ersek [this message]
2019-02-01 5:34 ` [PATCH 10/10] OptionRomPkg/ReadMe.txt: " Shenglei Zhang
2019-02-01 10:25 ` [PATCH 00/10] Remove unused tool chain configuration Ard Biesheuvel
2019-02-01 13:23 ` Gao, Liming
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1be8be5c-ccfe-77e8-c376-9162564e48af@redhat.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox