From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=209.132.183.28; helo=mx1.redhat.com; envelope-from=lersek@redhat.com; receiver=edk2-devel@lists.01.org Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id AAFD6211C6060 for ; Fri, 1 Feb 2019 00:58:13 -0800 (PST) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 21FEFC7C85; Fri, 1 Feb 2019 08:58:13 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-120-49.rdu2.redhat.com [10.10.120.49]) by smtp.corp.redhat.com (Postfix) with ESMTP id C23E35C21F; Fri, 1 Feb 2019 08:58:11 +0000 (UTC) To: Shenglei Zhang , edk2-devel@lists.01.org Cc: Liming Gao References: <20190201053445.13660-1-shenglei.zhang@intel.com> <20190201053445.13660-10-shenglei.zhang@intel.com> From: Laszlo Ersek Message-ID: <1be8be5c-ccfe-77e8-c376-9162564e48af@redhat.com> Date: Fri, 1 Feb 2019 09:58:10 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20190201053445.13660-10-shenglei.zhang@intel.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Fri, 01 Feb 2019 08:58:13 +0000 (UTC) Subject: Re: [PATCH 09/10] BaseTools/tools_def.template: Remove CYGGCC X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 01 Feb 2019 08:58:13 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 02/01/19 06:34, Shenglei Zhang wrote: > CYGGCC is too old.There is no verification for it. > https://bugzilla.tianocore.org/show_bug.cgi?id=1377 > > Cc: Bob Feng > Cc: Liming Gao > Cc: Yonghong Zhu > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Shenglei Zhang > --- > BaseTools/Conf/tools_def.template | 203 ------------------------------ > 1 file changed, 203 deletions(-) > > diff --git a/BaseTools/Conf/tools_def.template b/BaseTools/Conf/tools_def.template > index 0e671d55bc..e2718a1354 100755 > --- a/BaseTools/Conf/tools_def.template > +++ b/BaseTools/Conf/tools_def.template > @@ -295,15 +295,6 @@ DEFINE DTC_BIN = ENV(DTC_PREFIX)dtc > # Required to build platforms or ACPI tables: > # Intel(r) ACPI Compiler from > # https://acpica.org/downloads > -# CYGGCC -win32- Requires: > -# CygWin, GCC 4.3.0, binutils 2.20.51.0.5 > -# Microsoft Visual Studio 2005 or 2008 > -# Optional: > -# Required to build EBC drivers: > -# Intel(r) Compiler for Efi Byte Code (Intel(r) EBC Compiler) > -# Required to build platforms or ACPI tables: > -# Intel(r) ACPI Compiler (iasl.exe) from > -# https://acpica.org/downloads > # ICC -win32- Requires: > # Intel C Compiler V9.1 > # Dependencies: > @@ -373,15 +364,6 @@ DEFINE DTC_BIN = ENV(DTC_PREFIX)dtc > # Required to build platforms or ACPI tables: > # Microsoft ASL ACPI Compiler (asl.exe) v4.0.0 from > # http://download.microsoft.com/download/2/c/1/2c16c7e0-96c1-40f5-81fc-3e4bf7b65496/microsoft_asl_compiler-v4-0-0.msi > -# CYGGCCxASL -win32- Requires: > -# CygWin, GCC 4.3.0, binutils 2.20.51.0.5 > -# Microsoft Visual Studio 2005 or 2008 > -# Optional: > -# Required to build EBC drivers: > -# Intel(r) Compiler for Efi Byte Code (Intel(r) EBC Compiler) > -# Required to build platforms or ACPI tables: > -# Microsoft ASL ACPI Compiler (asl.exe) v4.0.0 from > -# http://download.microsoft.com/download/2/c/1/2c16c7e0-96c1-40f5-81fc-3e4bf7b65496/microsoft_asl_compiler-v4-0-0.msi > # ICCxASL -win32- Requires: > # Intel C Compiler V9.1 > # Dependencies: > @@ -524,24 +506,6 @@ DEFINE DTC_BIN = ENV(DTC_PREFIX)dtc > # Required to build platforms or ACPI tables: > # Microsoft ASL ACPI Compiler (asl.exe) v4.0.0 from > # http://download.microsoft.com/download/2/c/1/2c16c7e0-96c1-40f5-81fc-3e4bf7b65496/microsoft_asl_compiler-v4-0-0.msi > -# CYGGCCx86 -win64- Requires: > -# CygWin, GCC 4.3.0, binutils 2.20.51.0.5 > -# Microsoft Visual Studio 2005 or 2008 > -# Optional: > -# Required to build EBC drivers: > -# Intel(r) Compiler for Efi Byte Code (Intel(r) EBC Compiler) > -# Required to build platforms or ACPI tables: > -# Intel(r) ACPI Compiler (iasl.exe) from > -# https://acpica.org/downloads > -# CYGGCCx86xASL -win64- Requires: > -# CygWin, GCC 4.3.0, binutils 2.20.51.0.5 > -# Microsoft Visual Studio 2005 or 2008 > -# Optional: > -# Required to build EBC drivers: > -# Intel(r) Compiler for Efi Byte Code (Intel(r) EBC Compiler) > -# Required to build platforms or ACPI tables: > -# Microsoft ASL ACPI Compiler (asl.exe) v4.0.0 from > -# http://download.microsoft.com/download/2/c/1/2c16c7e0-96c1-40f5-81fc-3e4bf7b65496/microsoft_asl_compiler-v4-0-0.msi > # RVCT -win- Requires: > # ARM C/C++ Compiler, 5.00 > # Optional: > @@ -3824,173 +3788,6 @@ DEFINE CLANG38_AARCH64_DLINK_FLAGS = DEF(CLANG38_AARCH64_TARGET) DEF(GCC_AARCH6 > RELEASE_CLANG38_AARCH64_CC_FLAGS = DEF(CLANG38_AARCH64_CC_FLAGS) $(ARCHCC_FLAGS) $(PLATFORM_FLAGS) -flto -O3 > RELEASE_CLANG38_AARCH64_DLINK_FLAGS = DEF(CLANG38_AARCH64_DLINK_FLAGS) -flto -Wl,-O3 -L$(WORKSPACE)/ArmPkg/Library/GccLto -llto-aarch64 -Wl,-plugin-opt=-pass-through=-llto-aarch64 > > -#################################################################################### > -# > -# Cygwin GCC And Intel ACPI Compiler > -# > -#################################################################################### > -# CYGGCC - CygWin GCC > -# ASL - Intel ACPI Source Language Compiler (iasl.exe) > -*_CYGGCC_*_*_FAMILY = GCC > -*_CYGGCC_*_*_BUILDRULEFAMILY = GCCLD > - > -*_CYGGCC_*_*_DLL = DEF(CYGWIN_BIN) > -*_CYGGCC_*_MAKE_PATH = DEF(MS_VS_BIN)\nmake.exe > -*_CYGGCC_*_ASL_PATH = DEF(DEFAULT_WIN_ASL_BIN) > - > -*_CYGGCC_IA32_DLINK_FLAGS = DEF(GCC_IA32_X64_DLINK_FLAGS) --image-base=0 > -*_CYGGCC_X64_DLINK_FLAGS = DEF(GCC_IA32_X64_DLINK_FLAGS) --image-base=0 > -*_CYGGCC_IA32_ASLDLINK_FLAGS = DEF(GCC_IA32_X64_ASLDLINK_FLAGS) > -*_CYGGCC_X64_ASLDLINK_FLAGS = DEF(GCC_IA32_X64_ASLDLINK_FLAGS) > -*_CYGGCC_*_MAKE_FLAGS = /nologo > -*_CYGGCC_*_ASM_FLAGS = DEF(GCC_ASM_FLAGS) > -*_CYGGCC_*_PP_FLAGS = DEF(GCC_PP_FLAGS) > -*_CYGGCC_*_ASLPP_FLAGS = DEF(GCC_ASLPP_FLAGS) > -*_CYGGCC_*_ASLCC_FLAGS = DEF(GCC_ASLCC_FLAGS) > -*_CYGGCC_*_VFRPP_FLAGS = DEF(GCC_VFRPP_FLAGS) > -*_CYGGCC_*_APP_FLAGS = > -*_CYGGCC_*_ASL_FLAGS = DEF(DEFAULT_WIN_ASL_FLAGS) > -*_CYGGCC_*_ASL_OUTFLAGS = DEF(DEFAULT_WIN_ASL_OUTFLAGS) > - > -################## > -# IA32 definitions > -################## > -*_CYGGCC_IA32_CC_PATH = DEF(CYGWIN_BINIA32)gcc > -*_CYGGCC_IA32_SLINK_PATH = DEF(CYGWIN_BINIA32)ar > -*_CYGGCC_IA32_DLINK_PATH = DEF(CYGWIN_BINIA32)ld > -*_CYGGCC_IA32_ASM_PATH = DEF(CYGWIN_BINIA32)gcc > -*_CYGGCC_IA32_PP_PATH = DEF(CYGWIN_BINIA32)gcc > -*_CYGGCC_IA32_APP_PATH = DEF(CYGWIN_BINIA32)gcc > -*_CYGGCC_IA32_VFRPP_PATH = DEF(CYGWIN_BINIA32)gcc > -*_CYGGCC_IA32_ASLCC_PATH = DEF(CYGWIN_BINIA32)gcc > -*_CYGGCC_IA32_ASLPP_PATH = DEF(CYGWIN_BINIA32)gcc > -*_CYGGCC_IA32_ASLDLINK_PATH = DEF(CYGWIN_BINIA32)ld > -*_CYGGCC_IA32_RC_PATH = DEF(CYGWIN_BINIA32)objcopy > -*_CYGGCC_IA32_OBJCOPY_PATH = DEF(CYGWIN_BINIA32)objcopy > - > -*_CYGGCC_IA32_CC_FLAGS = DEF(GCC_IA32_CC_FLAGS) > -*_CYGGCC_IA32_RC_FLAGS = DEF(GCC_IA32_RC_FLAGS) > -*_CYGGCC_IA32_OBJCOPY_FLAGS = > -*_CYGGCC_IA32_NASM_FLAGS = -f win32 > - > -################## > -# X64 definitions > -################## > -*_CYGGCC_X64_CC_PATH = DEF(CYGWIN_BINX64)gcc > -*_CYGGCC_X64_SLINK_PATH = DEF(CYGWIN_BINX64)ar > -*_CYGGCC_X64_DLINK_PATH = DEF(CYGWIN_BINX64)ld > -*_CYGGCC_X64_ASM_PATH = DEF(CYGWIN_BINX64)gcc > -*_CYGGCC_X64_PP_PATH = DEF(CYGWIN_BINX64)gcc > -*_CYGGCC_X64_APP_PATH = DEF(CYGWIN_BINX64)gcc > -*_CYGGCC_X64_VFRPP_PATH = DEF(CYGWIN_BINX64)gcc > -*_CYGGCC_X64_ASLCC_PATH = DEF(CYGWIN_BINX64)gcc > -*_CYGGCC_X64_ASLPP_PATH = DEF(CYGWIN_BINX64)gcc > -*_CYGGCC_X64_ASLDLINK_PATH = DEF(CYGWIN_BINX64)ld > -*_CYGGCC_X64_RC_PATH = DEF(CYGWIN_BINX64)objcopy > -*_CYGGCC_X64_OBJCOPY_PATH = DEF(CYGWIN_BINX64)objcopy > - > -*_CYGGCC_X64_CC_FLAGS = DEF(GCC_X64_CC_FLAGS) > -*_CYGGCC_X64_RC_FLAGS = DEF(GCC_X64_RC_FLAGS) > -*_CYGGCC_X64_OBJCOPY_FLAGS = > -*_CYGGCC_X64_NASM_FLAGS = -f win64 > - > -################## > -# EBC definitions > -################## > -*_CYGGCC_EBC_*_FAMILY = INTEL > - > -*_CYGGCC_EBC_PP_PATH = DEF(EBC_BIN)\iec.exe > -*_CYGGCC_EBC_CC_PATH = DEF(EBC_BIN)\iec.exe > -*_CYGGCC_EBC_DLINK_PATH = DEF(EBC_BIN)\link.exe > -*_CYGGCC_EBC_SLINK_PATH = DEF(EBC_BIN)\link.exe > -*_CYGGCC_EBC_VFRPP_PATH = DEF(EBC_BIN)\iec.exe > -*_CYGGCC_EBC_RC_PATH = DEF(MS_VS_BIN)\rc.exe > - > -*_CYGGCC_EBC_CC_FLAGS = /nologo /c /WX /W3 /FIAutoGen.h /D$(MODULE_ENTRY_POINT)=$(ARCH_ENTRY_POINT) > -*_CYGGCC_EBC_SLINK_FLAGS = /lib /NOLOGO /MACHINE:EBC > -*_CYGGCC_EBC_DLINK_FLAGS = "C:\Program Files\Intel\EBC\Lib\EbcLib.lib" /NOLOGO /NODEFAULTLIB /MACHINE:EBC /OPT:REF /ENTRY:$(IMAGE_ENTRY_POINT) /SUBSYSTEM:EFI_BOOT_SERVICE_DRIVER /ALIGN:32 /DRIVER > - > -#################################################################################### > -# > -# Cygwin GCC And Microsoft ACPI Compiler > -# > -#################################################################################### > -# CYGGCCxASL - CygWin GCC > -# ASL - Microsoft ACPI Source Language Compiler (asl.exe) > -*_CYGGCCxASL_*_*_FAMILY = GCC > -*_CYGGCCxASL_*_*_BUILDRULEFAMILY = GCCLD > - > -*_CYGGCCxASL_*_*_DLL = DEF(CYGWIN_BIN) > -*_CYGGCCxASL_*_MAKE_PATH = DEF(MS_VS_BIN)\nmake.exe > - > -*_CYGGCCxASL_*_MAKE_FLAGS = /nologo > -*_CYGGCCxASL_*_PP_FLAGS = -E -x assembler-with-cpp -include AutoGen.h > -*_CYGGCCxASL_*_DLINK_FLAGS = -nostdlib -O2 --gc-sections --dll --export-all-symbols --entry _$(IMAGE_ENTRY_POINT) --file-alignment 0x20 --section-alignment 0x20 > -*_CYGGCCxASL_*_ASM_FLAGS = -c -x assembler -imacros AutoGen.h > -*_CYGGCCxASL_*_APP_FLAGS = -E -x assembler > -*_CYGGCCxASL_*_VFRPP_FLAGS = -x c -E -P -DVFRCOMPILE --include $(MODULE_NAME)StrDefs.h > - > -################## > -# ASL definitions > -################## > -*_CYGGCCxASL_*_ASL_PATH = DEF(WIN_ASL_BIN) > -*_CYGGCCxASL_*_ASL_FLAGS = > -*_CYGGCCxASL_*_ASL_OUTFLAGS = DEF(MS_ASL_OUTFLAGS) > -*_CYGGCCxASL_*_ASLCC_FLAGS = DEF(MSFT_ASLCC_FLAGS) > -*_CYGGCCxASL_*_ASLPP_FLAGS = DEF(MSFT_ASLPP_FLAGS) > -*_CYGGCCxASL_*_ASLDLINK_FLAGS = DEF(MSFT_ASLDLINK_FLAGS) > - > -################## > -# IA32 definitions > -################## > -*_CYGGCCxASL_IA32_CC_PATH = DEF(CYGWIN_BINIA32)gcc > -*_CYGGCCxASL_IA32_SLINK_PATH = DEF(CYGWIN_BINIA32)ar > -*_CYGGCCxASL_IA32_DLINK_PATH = DEF(CYGWIN_BINIA32)ld > -*_CYGGCCxASL_IA32_ASM_PATH = DEF(CYGWIN_BINIA32)gcc > -*_CYGGCCxASL_IA32_PP_PATH = DEF(CYGWIN_BINIA32)gcc > -*_CYGGCCxASL_IA32_APP_PATH = DEF(CYGWIN_BINIA32)gcc > -*_CYGGCCxASL_IA32_VFRPP_PATH = DEF(CYGWIN_BINIA32)gcc > -*_CYGGCCxASL_IA32_ASLCC_PATH = DEF(CYGWIN_BINIA32)gcc > -*_CYGGCCxASL_IA32_ASLPP_PATH = DEF(CYGWIN_BINIA32)gcc > -*_CYGGCCxASL_IA32_ASLDLINK_PATH = DEF(CYGWIN_BINIA32)ld > -*_CYGGCCxASL_IA32_RC_PATH = DEF(CYGWIN_BINIA32)objcopy > - > -*_CYGGCCxASL_IA32_CC_FLAGS = DEF(GCC_IA32_CC_FLAGS) > -*_CYGGCCxASL_IA32_RC_FLAGS = DEF(GCC_IA32_RC_FLAGS) > - > -################## > -# X64 definitions > -################## > -*_CYGGCCxASL_X64_CC_PATH = DEF(CYGWIN_BINX64)gcc > -*_CYGGCCxASL_X64_SLINK_PATH = DEF(CYGWIN_BINX64)ar > -*_CYGGCCxASL_X64_DLINK_PATH = DEF(CYGWIN_BINX64)ld > -*_CYGGCCxASL_X64_ASM_PATH = DEF(CYGWIN_BINX64)gcc > -*_CYGGCCxASL_X64_PP_PATH = DEF(CYGWIN_BINX64)gcc > -*_CYGGCCxASL_X64_APP_PATH = DEF(CYGWIN_BINX64)gcc > -*_CYGGCCxASL_X64_VFRPP_PATH = DEF(CYGWIN_BINX64)gcc > -*_CYGGCCxASL_X64_ASLCC_PATH = DEF(CYGWIN_BINX64)gcc > -*_CYGGCCxASL_X64_ASLPP_PATH = DEF(CYGWIN_BINX64)gcc > -*_CYGGCCxASL_X64_ASLDLINK_PATH = DEF(CYGWIN_BINX64)ld > -*_CYGGCCxASL_X64_RC_PATH = DEF(CYGWIN_BINX64)objcopy > - > -*_CYGGCCxASL_X64_CC_FLAGS = DEF(GCC_X64_CC_FLAGS) > -*_CYGGCCxASL_X64_RC_FLAGS = DEF(GCC_X64_RC_FLAGS) > - > -################## > -# EBC definitions > -################## > -*_CYGGCCxASL_EBC_*_FAMILY = INTEL > - > -*_CYGGCCxASL_EBC_PP_PATH = DEF(EBC_BIN)\iec.exe > -*_CYGGCCxASL_EBC_CC_PATH = DEF(EBC_BIN)\iec.exe > -*_CYGGCCxASL_EBC_DLINK_PATH = DEF(EBC_BIN)\link.exe > -*_CYGGCCxASL_EBC_SLINK_PATH = DEF(EBC_BIN)\link.exe > -*_CYGGCCxASL_EBC_VFRPP_PATH = DEF(EBC_BIN)\iec.exe > -*_CYGGCCxASL_EBC_RC_PATH = DEF(MS_VS_BIN)\rc.exe > - > -*_CYGGCCxASL_EBC_CC_FLAGS = /nologo /c /WX /W3 /FIAutoGen.h /D$(MODULE_ENTRY_POINT)=$(ARCH_ENTRY_POINT) > -*_CYGGCCxASL_EBC_SLINK_FLAGS = /lib /NOLOGO /MACHINE:EBC > -*_CYGGCCxASL_EBC_DLINK_FLAGS = "C:\Program Files\Intel\EBC\Lib\EbcLib.lib" /NOLOGO /NODEFAULTLIB /MACHINE:EBC /OPT:REF /ENTRY:$(IMAGE_ENTRY_POINT) /SUBSYSTEM:EFI_BOOT_SERVICE_DRIVER /ALIGN:32 /DRIVER > > #################################################################################### > # > Reviewed-by: Laszlo Ersek