Re: [edk2-devel] [PATCH edk2-platforms v1 1/1] Platform/ARM: TimerLib based RngLib for CryptoPkg

["Ard Biesheuvel" <ard.biesheuvel@arm.com>]

On 10/2/20 4:12 PM, Thomas Abraham wrote:
> On Fri, Oct 2, 2020 at 1:49 PM Ard Biesheuvel <ard.biesheuvel@arm.com> wrote:
>>
>> On 10/2/20 1:15 AM, Sami Mujawar wrote:
>>> The commit at "b5701a4c7a0f CryptoPkg: OpensslLib: Use RngLib to
>>> generate entropy in rand_pool" updated CryptoPkg\OpenSSL to no
>>> longer depend on TimerLib and instead use RngLib. This is done so
>>> that platforms can choose the desired entropy source. However, this
>>> change breaks the builds for platforms under Platform/ARM.
>>>
>>> To fix this, update ArmVExpress.dsc.inc to use a TimerLib based
>>> implementation of RngLib.
>>>
>>> Note: The TimerLib based implementation of RngLib replicates past
>>> behavior when used with OpenSSL. However, this should not be used
>>> in production as a real source of entropy.
>>>
>>> Signed-off-by: Sami Mujawar <sami.mujawar@arm.com>
>>
>> Reviewed-by: Ard Biesheuvel <ard.biesheuvel@arm.com>
> 
> Tested for SGI/RD platforms and it resolves the build issue.
> 
> Tested-by: Thomas Abraham <thomas.abraham@arm.com>
> 

Pushed as 96a98e4d3255..fc49849a8ebc

Thanks,