From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web11.14376.1601829871938317371 for ; Sun, 04 Oct 2020 09:44:32 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: arm.com, ip: 217.140.110.172, mailfrom: ard.biesheuvel@arm.com) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id A6F23101E; Sun, 4 Oct 2020 09:44:31 -0700 (PDT) Received: from [192.168.1.81] (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 1E8E63F70D; Sun, 4 Oct 2020 09:44:29 -0700 (PDT) Subject: Re: [edk2-devel] [PATCH edk2-platforms v1 1/1] Platform/ARM: TimerLib based RngLib for CryptoPkg To: Thomas Abraham , devel@edk2.groups.io Cc: Sami Mujawar , Leif Lindholm , Matteo.Carlini@arm.com, Ben.Adderson@arm.com, nd@arm.com References: <20201001231528.100364-1-sami.mujawar@arm.com> <53b238d1-41be-e3c6-12a3-e054536d815a@arm.com> From: "Ard Biesheuvel" Message-ID: <1c03406f-09aa-4343-0886-76375568d726@arm.com> Date: Sun, 4 Oct 2020 18:44:20 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit On 10/2/20 4:12 PM, Thomas Abraham wrote: > On Fri, Oct 2, 2020 at 1:49 PM Ard Biesheuvel wrote: >> >> On 10/2/20 1:15 AM, Sami Mujawar wrote: >>> The commit at "b5701a4c7a0f CryptoPkg: OpensslLib: Use RngLib to >>> generate entropy in rand_pool" updated CryptoPkg\OpenSSL to no >>> longer depend on TimerLib and instead use RngLib. This is done so >>> that platforms can choose the desired entropy source. However, this >>> change breaks the builds for platforms under Platform/ARM. >>> >>> To fix this, update ArmVExpress.dsc.inc to use a TimerLib based >>> implementation of RngLib. >>> >>> Note: The TimerLib based implementation of RngLib replicates past >>> behavior when used with OpenSSL. However, this should not be used >>> in production as a real source of entropy. >>> >>> Signed-off-by: Sami Mujawar >> >> Reviewed-by: Ard Biesheuvel > > Tested for SGI/RD platforms and it resolves the build issue. > > Tested-by: Thomas Abraham > Pushed as 96a98e4d3255..fc49849a8ebc Thanks,