From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.61]) by mx.groups.io with SMTP id smtpd.web10.2258.1590052122438761616 for ; Thu, 21 May 2020 02:08:42 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=UUR8r7E5; spf=pass (domain: redhat.com, ip: 205.139.110.61, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1590052121; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=fz4tnJZ+z1G9xsT/C3Q9J/4qeok3v/G9xfY8k8r84rk=; b=UUR8r7E5Lu0i+vumurpFdH3QLTXfDU6v5mZfv25IGbaojON2I99IpQowFSsiqbWRhnV5q9 zkd+Ce12VDeacpxI9s9XCW1X5Nj/BI3eyCzmL5SXsSA8LFdRR20bJXuHDQe3fBrzwBEGHo OMRryQK2WGUReqZrYuvbTCNifCPFYPA= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-114-C7_3BJqxM6G8gJviqaoeGg-1; Thu, 21 May 2020 05:08:34 -0400 X-MC-Unique: C7_3BJqxM6G8gJviqaoeGg-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 62F10107ACCA; Thu, 21 May 2020 09:08:33 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-113-225.ams2.redhat.com [10.36.113.225]) by smtp.corp.redhat.com (Postfix) with ESMTP id 22F3F105912B; Thu, 21 May 2020 09:08:25 +0000 (UTC) Subject: Re: [PATCH 0/3] OvmfPkg/Tcg2ConfigPei: fix ARM/AARCH64 build failure To: Ard Biesheuvel , edk2-devel-groups-io Cc: Eric Auger , Jordan Justen , =?UTF-8?Q?Marc-Andr=c3=a9_Lureau?= , =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , Simon Hardy , Stefan Berger References: <20200520225841.17793-1-lersek@redhat.com> From: "Laszlo Ersek" Message-ID: <1c09facb-1a3c-3689-f5d0-060cd930a119@redhat.com> Date: Thu, 21 May 2020 11:08:25 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit On 05/21/20 10:37, Ard Biesheuvel wrote: > On 5/21/20 12:58 AM, Laszlo Ersek wrote: >> Ref:    https://bugzilla.tianocore.org/show_bug.cgi?id=2728 >> Repo:   https://pagure.io/lersek/edk2.git >> Branch: restrict_tpm12_to_x86_bz_2728 >> >> Another regression fix for edk2-stable202005. >> >> End of February 2020, Ard and Marc-André worked on two TPM-related >> features in parallel. Respectively: >> >> - [edk2-devel] [PATCH v4 00/11] >>    ArmVirtPkg: implement measured boot for ArmVirtQemu >> >>    >> http://mid.mail-archive.com/20200227144056.56988-1-ard.biesheuvel@linaro.org >> >>    https://edk2.groups.io/g/devel/message/55004 >> >> - [edk2-devel] [PATCH v4 0/5] >>    Ovmf: enable TPM 1.2 >> >>    >> http://mid.mail-archive.com/20200226152433.1295789-1-marcandre.lureau@redhat.com >> >>    https://edk2.groups.io/g/devel/message/54894 >> >> Both series were merged tightly one after the other. There was no merge >> conflict, and standing alone (without rebasing one on the other), each >> series was self-contained and correct. Their combination however led to >> an ArmVirtQemu build regression. There never was an intent to support >> TPM-1.2 in ArmVirtQemu, but the TPM-1.2 series for OVMF kind of made >> that "mandatory". >> >> Worse, the build regression has remained hidden for 2+ months because >> (a) I didn't expect Marc-André's series to affect any ArmVirtPkg >> platform, (b) my ArmVirtQemu build script did not set TPM2_ENABLE. >> >> This series fixes the build regression, and intends no functional >> changes at all. >> >> Functional regression-testing would be appreciated: >> >> - from Simon regarding their TPM-1.2 passthrough use case, >> >> - from Marc-André regarding vTPM-2.0 on X64, >> >> - from Eric regarding vTPM-2.0 on AARCH64. >> >> This is a regression fix, therefore it is eligible for merging during >> the edk2-stable202005 Hard Feature Freeze too >> . >> >> >> If you plan to regression-test this series, then please say so soon, >> otherwise I wouldn't like to wait for long -- assuming an R-b from Ard >> or Jordan -- even without Tested-by's. >> >> In the future we should likely set some "-D" flags somewhere under >> "ArmVirtPkg/PlatformCI/" (so that our CI coverage grow). The best I can >> personally do about that is maybe file a BZ?... >> > > Thanks a lot for fixing this. I know TPM support is not a feature you > care deeply about. > > For the series, > > Reviewed-by: Ard Biesheuvel > Tested-by: Ard Biesheuvel > > (on AArch64 only) > Thanks! In that case, I will *not* send a v2. The updates I'd implement in v2 are not important enough to invalidate your testing. I'll send those small fixups after the stable tag is made. Thanks! Laszlo