From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=45.249.212.191; helo=huawei.com; envelope-from=huangming23@huawei.com; receiver=edk2-devel@lists.01.org Received: from huawei.com (szxga05-in.huawei.com [45.249.212.191]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id D123321E48F20 for ; Tue, 23 Jan 2018 17:12:15 -0800 (PST) Received: from DGGEMS413-HUB.china.huawei.com (unknown [172.30.72.59]) by Forcepoint Email with ESMTP id B86D67F356C35; Wed, 24 Jan 2018 09:17:28 +0800 (CST) Received: from [127.0.0.1] (10.61.17.224) by DGGEMS413-HUB.china.huawei.com (10.3.19.213) with Microsoft SMTP Server id 14.3.361.1; Wed, 24 Jan 2018 09:17:22 +0800 To: Leif Lindholm , Ming Huang References: <1516287703-35516-1-git-send-email-huangming23@huawei.com> <1516287703-35516-15-git-send-email-huangming23@huawei.com> <20180123101847.p65tfoeskt7jc7q7@bivouac.eciton.net> CC: , , , , , , , , From: "Huangming (Mark)" Message-ID: <1c488414-a363-6faa-3c73-474d59c451bb@huawei.com> Date: Wed, 24 Jan 2018 09:17:21 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <20180123101847.p65tfoeskt7jc7q7@bivouac.eciton.net> X-Originating-IP: [10.61.17.224] X-CFilter-Loop: Reflected Subject: Re: [PATCH edk2-platforms v1 14/14] Hisilicon D03/D05: Update firmware version to 18.02 X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 24 Jan 2018 01:12:16 -0000 Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit On 2018/1/23 18:18, Leif Lindholm wrote: > On Thu, Jan 18, 2018 at 11:01:43PM +0800, Ming Huang wrote: >> Replace the old string with short one. The old one is >> too long that can not be show integrallty in Setup nemu. >> >> Contributed-under: TianoCore Contribution Agreement 1.1 >> Signed-off-by: Ming Huang >> Signed-off-by: Heyi Guo > > NAK > > Anything that is not an official Linaro reference platform release is > a development build. The fallback string needs to indicate this. > The current one does this. > The modified version does not. > > / > Leif > Is the below version string ok? "Development build 18.02 for Hisilicon D03" >> --- >> Platform/Hisilicon/D03/D03.dsc | 2 +- >> Platform/Hisilicon/D05/D05.dsc | 2 +- >> 2 files changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/Platform/Hisilicon/D03/D03.dsc b/Platform/Hisilicon/D03/D03.dsc >> index 6f1164e..b6b8086 100644 >> --- a/Platform/Hisilicon/D03/D03.dsc >> +++ b/Platform/Hisilicon/D03/D03.dsc >> @@ -171,7 +171,7 @@ >> !ifdef $(FIRMWARE_VER) >> gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareVersionString|L"$(FIRMWARE_VER)" >> !else >> - gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareVersionString|L"Development build base on Hisilicon D03 UEFI 17.10 Release" >> + gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareVersionString|L"RP 18.02 for Hisilicon D03" >> !endif >> >> gHisiTokenSpaceGuid.PcdBiosVersionString|L"10.01.01T18" >> diff --git a/Platform/Hisilicon/D05/D05.dsc b/Platform/Hisilicon/D05/D05.dsc >> index 52ffad5..a599c08 100644 >> --- a/Platform/Hisilicon/D05/D05.dsc >> +++ b/Platform/Hisilicon/D05/D05.dsc >> @@ -190,7 +190,7 @@ >> !ifdef $(FIRMWARE_VER) >> gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareVersionString|L"$(FIRMWARE_VER)" >> !else >> - gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareVersionString|L"Development build base on Hisilicon D05 UEFI 17.10 Release" >> + gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareVersionString|L"RP 18.02 for Hisilicon D05" >> !endif >> >> gHisiTokenSpaceGuid.PcdBiosVersionString|L"10.01.01T18" >> -- >> 1.9.1 >> > > . > -- Best Regards, Ming