From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.groups.io with SMTP id smtpd.web12.517.1570577810809257751 for ; Tue, 08 Oct 2019 16:36:50 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: redhat.com, ip: 209.132.183.28, mailfrom: lersek@redhat.com) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 5ABFF4627A; Tue, 8 Oct 2019 23:36:50 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-120-109.rdu2.redhat.com [10.10.120.109]) by smtp.corp.redhat.com (Postfix) with ESMTP id ADBDF5D70D; Tue, 8 Oct 2019 23:36:46 +0000 (UTC) Subject: Re: [edk2-devel] [PATCH 18/35] NetworkPkg/DxeNetLib: fix type typo in NetLibGetMacAddress() To: "Fu, Siyuan" , "devel@edk2.groups.io" , "philmd@redhat.com" Cc: "Wu, Jiaxin" , Michael Kinney References: <20190917194935.24322-1-lersek@redhat.com> <20190917194935.24322-19-lersek@redhat.com> From: "Laszlo Ersek" Message-ID: <1c4a203c-b4bd-2d98-6b16-c541e192da1d@redhat.com> Date: Wed, 9 Oct 2019 01:36:45 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.29]); Tue, 08 Oct 2019 23:36:50 +0000 (UTC) Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 10/08/19 02:32, Fu, Siyuan wrote: > Just return from vacation. Sorry for late response. >=20 > Reviewed-by: Siyuan Fu Thank you and Mike both! Laszlo >> -----Original Message----- >> From: devel@edk2.groups.io On Behalf Of Philippe >> Mathieu-Daud=C3=A9 >> Sent: 2019=E5=B9=B49=E6=9C=8824=E6=97=A5 19:00 >> To: devel@edk2.groups.io; lersek@redhat.com >> Cc: Wu, Jiaxin ; Fu, Siyuan >> Subject: Re: [edk2-devel] [PATCH 18/35] NetworkPkg/DxeNetLib: fix type >> typo in NetLibGetMacAddress() >> >> On 9/17/19 9:49 PM, Laszlo Ersek wrote: >>> NetLibGetSnpHandle() returns an EFI_HANDLE, not an (EFI_HANDLE*). >>> NetLibGetMacAddress() only uses the return value ("SnpHandle") for a >>> NULL-check. Fix the type of "SnpHandle". >>> >>> This patch is a no-op. >>> >>> Cc: Jiaxin Wu >>> Cc: Siyuan Fu >>> Signed-off-by: Laszlo Ersek >>> --- >>> >>> Notes: >>> lightly tested: MAC strings are displayed in UiApp >>> >>> NetworkPkg/Library/DxeNetLib/DxeNetLib.c | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/NetworkPkg/Library/DxeNetLib/DxeNetLib.c >> b/NetworkPkg/Library/DxeNetLib/DxeNetLib.c >>> index 8e2f720666ea..a39c20be3d34 100644 >>> --- a/NetworkPkg/Library/DxeNetLib/DxeNetLib.c >>> +++ b/NetworkPkg/Library/DxeNetLib/DxeNetLib.c >>> @@ -2182,7 +2182,7 @@ NetLibGetMacAddress ( >>> EFI_SIMPLE_NETWORK_MODE SnpModeData; >>> EFI_MANAGED_NETWORK_PROTOCOL *Mnp; >>> EFI_SERVICE_BINDING_PROTOCOL *MnpSb; >>> - EFI_HANDLE *SnpHandle; >>> + EFI_HANDLE SnpHandle; >>> EFI_HANDLE MnpChildHandle; >>> >>> ASSERT (MacAddress !=3D NULL); >>> >> >> Since SnpHandle is only checked for being non-null, this change is >> indeed a no-op, else it would probably fixed some bug. >> >> Reviewed-by: Philippe Mathieu-Daude >> >>=20 >=20