From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f45.google.com (mail-pj1-f45.google.com [209.85.216.45]) by mx.groups.io with SMTP id smtpd.web09.2914.1630615731428186028 for ; Thu, 02 Sep 2021 13:48:51 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@nuviainc-com.20150623.gappssmtp.com header.s=20150623 header.b=Qog65Yno; spf=pass (domain: nuviainc.com, ip: 209.85.216.45, mailfrom: rebecca@nuviainc.com) Received: by mail-pj1-f45.google.com with SMTP id fs6so2212789pjb.4 for ; Thu, 02 Sep 2021 13:48:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuviainc-com.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=t/sX4oj1GO4Cc1zpdSg/JBw1vOIEtD/lp8DsFjZFbss=; b=Qog65YnoRtjSyl4O+5dW8Vr1IxQcUpVTsmbYOaqyCZ4Ejqh5n5W61lC8SDcaaG4Mx5 oslRlvR6M70oVnq9B4Z81eGtZgoyi0cjdxi6TDN5lssQtKUi4DXOjQTJM+ZlyS/iPNSD fNt4x38NtXVwAaCncPWEPtuxxOLBrEts/uvl+gl+EKVSV3YxEmGtEPnCDbxmDD2JwpB0 ve78bsMNYkFwmDti3SJBCYe6nGJvrWL0U20klqq7qnBD14rRZkzSvi3Xqen/pSzF3z2z 4N6L3Qb6KcE6rEmRuCDFHWbEy7QXEZp3N5XeD4lA8GFHKMiuCbpepY9gunTN8T5bmqWI IHwA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=t/sX4oj1GO4Cc1zpdSg/JBw1vOIEtD/lp8DsFjZFbss=; b=axcpmjcqI7j+4G+DLMrr3VCh/AJ3+fsMD3JobDFTZ4u2IT8VZ7SIaW1Fr2KxWRA305 uSKtRJOm2fgvHyfhZDkziyaChXo70ZsERIboTRIkMknQyMYqmZMTFNmlmy4GhgkmMrHA WlN+DlhZ+nDzfzVcGJpr/ThG1LxLApk4ne2oBSA9Hz4ZVYdseyOpiMLi2umifJueuF81 spEW4kAdrPWmxmxJzKYZIJ4uFneP5Wfp8x3GMfyzIB4Bf/rWMqderiCCrEoRdQEBX9zm 1JL3uJnpdAbYIzPbozcaeqgmX431e4er9oPZtRUQU1abbq9cDVzjkws2rjkSzSS222wI hGug== X-Gm-Message-State: AOAM530b0204yTB2gWax5ZezOz9bztax+CIx+EWOMMm/70qn93njBRmN 1CVAXBtlS/JbR437DpC+18/3kQ== X-Google-Smtp-Source: ABdhPJypf+RYEYvdoRygXXTHWjvA4RfZlQM7j6wfFMXPQhek0LcM9ztttFB5nUZu0ICq8OrqQYFVHQ== X-Received: by 2002:a17:90b:1b4f:: with SMTP id nv15mr2492134pjb.44.1630615730971; Thu, 02 Sep 2021 13:48:50 -0700 (PDT) Return-Path: Received: from linbox.int.bluestop.org (c-174-52-16-57.hsd1.ut.comcast.net. [174.52.16.57]) by smtp.gmail.com with ESMTPSA id 73sm3259837pfu.92.2021.09.02.13.48.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 02 Sep 2021 13:48:50 -0700 (PDT) Subject: Re: [edk2-devel] [edk2-libc Patch 1/1] AppPkg/Applications/Python/Python-3.6.8: Py 3.6.8 UEFI changes To: "Kinney, Michael D" , "devel@edk2.groups.io" Cc: "Jayaprakash, N" References: <20210902171247.1935-1-michael.d.kinney@intel.com> <20210902171247.1935-2-michael.d.kinney@intel.com> From: "Rebecca Cran" Message-ID: <1c4d6151-be92-cc9c-5995-fd14a15ae21d@nuviainc.com> Date: Thu, 2 Sep 2021 14:48:49 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Thanks, that makes sense. I haven't reviewed the entire patch, so I've given an Acked-by instead. -- Rebecca Cran On 9/2/21 2:46 PM, Kinney, Michael D wrote: > Hi Rebecca, > > Responses below. > > Some of the items you are observing are due to following the exact > same pattern as the Python 2.x ports. There are many things that can > get cleaned up in the Python 3.x ports. I would prefer to see this > initial functional version go in and add new BZs for additional cleanups. > > Thanks, > > Mike > >> -----Original Message----- >> From: devel@edk2.groups.io On Behalf Of Rebecca Cran >> Sent: Thursday, September 2, 2021 11:41 AM >> To: devel@edk2.groups.io; Kinney, Michael D >> Cc: Jayaprakash, N >> Subject: Re: [edk2-devel] [edk2-libc Patch 1/1] AppPkg/Applications/Python/Python-3.6.8: Py 3.6.8 UEFI changes >> >> On 9/2/21 11:12 AM, Michael D Kinney wrote: >> >>> AppPkg/AppPkg.dsc | 3 + >>> .../Python/Python-3.6.8/Py368ReadMe.txt | 220 + >> This looks like it's formatted using Markdown, so should it be >> Py368ReadMe.md? > It looks like there are elements that do not follow MarkDown and the formatting > looks bad when using a MarkDown viewer. I would recommend leaving it as .txt for > now. We can enter a new issue to convert to MD. > >>> create mode 100644 AppPkg/Applications/Python/Python-3.6.8/create_python368_pkg.bat >> The xcopy commands should probably have error checking after them. > There are several limitations to the BAT file. It is just being reused from the > Python 2.x ports. I think it would be better to port this to a Python script and > add all error checking in that version. We can enter a new issues for this Python > port. > >> >> -- >> >> Rebecca Cran >> >> >> >> >>