From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.81]) by mx.groups.io with SMTP id smtpd.web12.48653.1590493528777051738 for ; Tue, 26 May 2020 04:45:29 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=N/KKhfUy; spf=pass (domain: redhat.com, ip: 207.211.31.81, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1590493527; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=853oVlfqC2Vuu7JsGQ2fw7TnzCSK1nTbXC3DUKl9tI0=; b=N/KKhfUyJ3zNFv8niq4lsLaIoTg7GAk/uABG2kiN00Hd/1WooTnYDd67CpSiX3sAQ4FWgY CVjgFDs/o4hJSoW4DoloKG2j5SYeTkslovXyA/Xf8IE53xkf47eCRuipPYq7Nf5OlZ/saI AA2DerYqzwPyMNDbuYYoXOoz7tuSmS4= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-193-zog0qiwJPU2-dGfk05kd8w-1; Tue, 26 May 2020 07:45:18 -0400 X-MC-Unique: zog0qiwJPU2-dGfk05kd8w-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id CEBD2100CCCE; Tue, 26 May 2020 11:45:16 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-114-136.ams2.redhat.com [10.36.114.136]) by smtp.corp.redhat.com (Postfix) with ESMTP id 294905D9E5; Tue, 26 May 2020 11:45:14 +0000 (UTC) Subject: Re: [edk2-devel] [PATCH 3/3] OvmfwPkg: Don't exclude XCODE Modules To: Andrew Fish , edk2-devel-groups-io Cc: Ard Biesheuvel , Jiewen Yao , Jordan Justen , =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= References: <215ac3c5d0c73779d06b6d7463000ee8d1d526fe.1590354726.git.afish@apple.com> <63bcf199-3937-040c-dc2f-26b1d577ede5@redhat.com> <9D1DBCDB-9B2D-4DB2-89C9-F89458C0AA72@apple.com> From: "Laszlo Ersek" Message-ID: <1c4fd1f8-980d-1a18-bf65-34afea2bc2dc@redhat.com> Date: Tue, 26 May 2020 13:45:14 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <9D1DBCDB-9B2D-4DB2-89C9-F89458C0AA72@apple.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit On 05/26/20 06:10, Andrew Fish wrote: > > >> On May 25, 2020, at 12:31 PM, Laszlo Ersek wrote: >> >> Hi Andrew, >> >> On 05/24/20 23:20, Andrew Fish via groups.io wrote: >>> With this BZ getting fixed we no longer need to special case XCODE. >>> >>> Cc: Ard Biesheuvel >>> Cc: Jiewen Yao >>> Cc: Jordan Justen >>> Cc: Philippe Mathieu-Daudé >>> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=557 >>> Signed-off-by: Andrew Fish >>> >>> Signed-off-by: Andrew Fish >>> --- >>> OvmfPkg/OvmfPkgIa32.dsc | 3 +-- >>> OvmfPkg/OvmfPkgIa32.fdf | 2 -- >>> OvmfPkg/OvmfPkgIa32X64.dsc | 4 ++-- >>> OvmfPkg/OvmfPkgIa32X64.fdf | 2 -- >>> OvmfPkg/OvmfPkgX64.dsc | 3 +-- >>> OvmfPkg/OvmfPkgX64.fdf | 2 -- >>> OvmfPkg/OvmfXen.dsc | 3 +-- >>> OvmfPkg/OvmfXen.fdf | 2 -- >>> 8 files changed, 5 insertions(+), 16 deletions(-) >> > > Laszlo, > > Thanks for the feedback. > > Can I ask that you go to https://www.tianocore.org, click on How to Contribute and point me at the chain of links I did not follow, if I missed it tit is likely due to too many links and too much information being vended. You didn't miss anything, starting from that page, I think. I don't remember ever clicking "How to Contribute" on that page. :) In fact if I grep the current edk2-wiki project source, at commit de8fae02bbcc ("Add acknowledgements page", 2020-05-21), I find no references to "SetupGit.py". > When people are starting out we should vend them the instructions that work and let them opt in to learning more. "Working instructions" is a moving target. When I wrote the unkempt guide, it was serious work, I had to set aside resources. When we changed the workflow to replace "git-push" (by maintainers) with github PRs (to trigger CI), documenting that was again serious work (for Mike -- Mike updated both the official workflow article and the unkempt guide, as I couldn't volunteer for the latter). The more documentation we add, the larger the burden to update them grows. It's an on-going commitment. Given the constant scarcity of developer (and reviewer) cycles, we can only choose between: - "code, plus more or less up-to-date docs", and - "code, plus no docs". Leif wrote SetupGit.py in the first place to save people the effort of going through some of the unkempt guide steps. If we decide that no SetupGit.py (or similar utilities) should be written without documenting them in the wiki, that won't force contributors to document their workflow-related contributions; it will cause them to not writing the utilities in the first place. Open source development communities teach contributors the workflow by doing. For example, I have contributed to two open source projects that are *exclusively* managed on github.com, using "github native" pull requests and such. (Namely, openssl, and "p11-glue/p11-kit".) I'm the kind of guy that very carefully reads the documentation first, and starts pushing the buttons only second, and I *still* got wrong my initial contributions to both projects. With OpenSSL, I missed details of how review worked and details about the CLA. Maintainers taught me those bits on the PR, while they were reviewing my code. With p11-kit, I had missed that I was expected to write a unit test at once, for the new code. Maintainers pointed that out in my PR. I posit that virtually no up-to-date technical documentation exists unless an organization treats that documentation as a *product* (with its own resource allocations, technical writers, subject matter expert reviewers, project managers, and so on). > >> (1) Please run "BaseTools/Scripts/SetupGit.py" in your edk2 clone, >> because right now, the patch is formatted/posted with too many CR >> characters. >> > > I filed https://bugzilla.tianocore.org/show_bug.cgi?id=2767 since I passed PatchCheck.py but did not run BaseTools/Scripts/SetupGit.py Thanks. For the record: I didn't reject your contribution (I'm very happy you posted a patch series); instead, I asked for an update. In particular, the number of empty lines inserted into the DSC files is not consistent across the OVMF DSC files, and that fact has nothing to do with git configuration -- it would need fixing identically even if the series had been submitted via a github.com PR. Thanks Laszlo