From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM02-SN1-obe.outbound.protection.outlook.com (NAM02-SN1-obe.outbound.protection.outlook.com [40.107.96.129]) by mx.groups.io with SMTP id smtpd.web11.5768.1639626837372504592 for ; Wed, 15 Dec 2021 19:53:57 -0800 Authentication-Results: mx.groups.io; dkim=fail reason="body hash did not verify" header.i=@os.amperecomputing.com header.s=selector2 header.b=E2WbxHdh; spf=pass (domain: os.amperecomputing.com, ip: 40.107.96.129, mailfrom: nhi@os.amperecomputing.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FJ+Hzab2dIxR4I1n02pHKI2bPZbQ32jygEezXCJ7V4WLWFRRnwnP61r0JmukP8toeQ+K51wGEOry0KUoRGDZYhZcjSbsCPahK8p1NIrOPiB3nZgGmB7ANu18BC2AnIvc+JjCz2j/KbayjwLMYPjqf5WgcvRQ/eOqfzV2mYg015xJ24jU4zUHezzatc7nbtv8gNrZrYfxTV4RYGW0V2HgS2KF2tWnk5mRbsDdm1vU828HDye9oy5gMEloWau+3Zo89QQqFSbNXCPvo5X3o8LNrVlRYZAFvkGMwhCQKoPfNVNQ5kSuW2BDmFc7ESQtfHKmVWobOPS67mCw2o3QBGoaRA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=lbqKzsfYURNXH4YYK2UJPwoRCnd8oKKLbwMx/8z1nHE=; b=YdZ2AhtYG3wCJEEUJfJ5TmF3G1jlBTFSvqkVIzCOXEb0hvm+2d6biF3ZPVzpcFS62njMEBfcVvPIJTy91nbVxPkptqAlc1H2LS1NGi9rNfkTuSqBiSXfqeQB2gW3TNRjPxhwaFfiDuyGJwW+TRi20LVSkVIokrepYbLlF1sNpwywQiLX6C1ur6/7QgHTNxkQiJQoxx6yms7eVKq0X7IV5npS1XKiUQ9WSnfbWatpNAutVz5UutUY78c2rzl+TsQgOUBiKjGdSdh3F1D/gytns0QgfD1WO+Q7RKDehMaMSF4kVOdn+6oXbL6UzlT9jSPbRxYYTK+dG18g0hhNsOAHNw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=os.amperecomputing.com; dmarc=pass action=none header.from=os.amperecomputing.com; dkim=pass header.d=os.amperecomputing.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=os.amperecomputing.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lbqKzsfYURNXH4YYK2UJPwoRCnd8oKKLbwMx/8z1nHE=; b=E2WbxHdhIBF5fVtf+2shdZY4TBiaamfZaHL3rlM/I30xWDhdbm2eYbTYIV+FwBnfm2NpkGeJUiERmBmn8nkSudgWtY8pbHijUwQuiyNxTMn/m2OSrMeWMOkk6XL1KdAYTommKkVhl7iA68iExH/eklJmkR9lGhwyqlXegiVjoRM= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=os.amperecomputing.com; Received: from PH0PR01MB7287.prod.exchangelabs.com (2603:10b6:510:10a::21) by PH0PR01MB7381.prod.exchangelabs.com (2603:10b6:510:100::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4801.14; Thu, 16 Dec 2021 03:53:55 +0000 Received: from PH0PR01MB7287.prod.exchangelabs.com ([fe80::b519:e888:c4c8:b552]) by PH0PR01MB7287.prod.exchangelabs.com ([fe80::b519:e888:c4c8:b552%8]) with mapi id 15.20.4778.017; Thu, 16 Dec 2021 03:53:55 +0000 Message-ID: <1c557ec7-4a57-9723-b1e4-1cebac17afc2@os.amperecomputing.com> Date: Thu, 16 Dec 2021 10:53:46 +0700 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.3.2 Subject: Re: [edk2-devel] [PATCH 0/3] ArmPkg/SMBIOS: Update HII string settings for SMBIOS To: Sami Mujawar , devel@edk2.groups.io CC: patches@amperecomputing.com, Leif Lindholm , Ard Biesheuvel , Rebecca Cran , nd References: <20211201041031.31824-1-nhi@os.amperecomputing.com> <5a8dddbb-d327-1ae7-e269-63fc5649c124@arm.com> From: "Nhi Pham" In-Reply-To: <5a8dddbb-d327-1ae7-e269-63fc5649c124@arm.com> X-ClientProxiedBy: SI2P153CA0024.APCP153.PROD.OUTLOOK.COM (2603:1096:4:190::13) To PH0PR01MB7287.prod.exchangelabs.com (2603:10b6:510:10a::21) Return-Path: nhi@os.amperecomputing.com MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: d20fa825-e35f-4b13-4c7c-08d9c047ae22 X-MS-TrafficTypeDiagnostic: PH0PR01MB7381:EE_ X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:2331; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: SlWn5RreyqvlXjJ9L/DVl2NeddyFV8LgOYW/l7mfQYT3jePz86Q4TnKHWF/kY1DWVCYTa16XxnFOajv6qje6zYxf2iiatsRqYwFOUm8etv04X5IYszNAMq9vOSaFDWoJ9W9Im5XT2tDUTNWPXh43jHgS8BRhbAXHzDQ1CRnyAlOhVwDLB4JUgs1/d4TzJ9y0HDv85e7TRVfo3jvc5BYKGXxzfD2eXe38BVVGAoHWXUEXV1OXImPGAqwNrphuwZo+P73apsUTQ9oqpWAva4kdSqoJCaDMj+L/TFOeTDhwnlf96McIazZpWP5iG4xUkAQg3wJLV97tuL40N1TJoW99NkTfXUNPDJHhORFWAsZMfpF8Cv81WAiRh2Y7xs/gZwXkBaMA0tGnRzO909BBsN2sQkMJaDiFQIx1dW4PdFKpsq4K0ifYnX4Fl477BO2L5CGtCf0pzNKm2NENQGdFSJ8zz+YsuRIHxiEryTitn/8gC6iY75flDHz83IERAAdfIKOlM5vTq7KuDkiPbXkOw/3RObNO6xAn3x9fzJS9vXZ/ELMm1swcFjgN/vghIaKRNXEM7Tqhu7Weg1oOnQ9KoUzIY2NJWOfZRwHxcpQY8GNSDM0KuWv6KVcy3WGYbJR36dnoaMsLmKyEDVXA4kcUgJLfg66cAWfdDCD+wq0YE/RNh7RYR8thHxpM1iWmvOay/Xezr6IMBWTcWgINPrCepW0qU1wM3OIpuEITJpxcFe3sD2w= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR01MB7287.prod.exchangelabs.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(45954011)(6486002)(6506007)(19627235002)(8676002)(53546011)(5660300002)(6512007)(31696002)(31686004)(83380400001)(66946007)(2906002)(86362001)(2616005)(15650500001)(508600001)(8936002)(66476007)(26005)(4326008)(6666004)(66556008)(52116002)(316002)(38100700002)(54906003)(186003)(38350700002)(43740500002);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?HQz4iKYNDcmx1NgYazsbZebRrMvK8Pgx/7ol407q7iRYBUsqTRx0TrP4vrKM?= =?us-ascii?Q?/OkmJo5VHX0r1HSbDKIK6an5MOAOFHj1SFveJtTd42OFDCLeaPmzAqgmRy7I?= =?us-ascii?Q?X0O5o9yoQ31/8LHuSF5rFI5B6dU7XsSqPG9KO5QKjMe9hbkQFOXD3T05EyFA?= =?us-ascii?Q?9d9ZjJQmpAWyyTZMnhT1Zgb33uyJCl1YGiGfDUBsOyGfsTJ8xAQyiSJov2p0?= =?us-ascii?Q?/MBf9GX96xImSQGmkK7p4Qmlo2wAwGO6qPY/3Ri2+UsdxB0mNfvBLTBzvLpf?= =?us-ascii?Q?t+F3P9y6RT0jzK1Dv1qhJ8tKnjdKy+WqdwlDgLAQocn2YgjpasXSLSwQuxsE?= =?us-ascii?Q?lwPKY8kp6Uyu5TL/UkiVLMkOttIPA/YST/nUhqenUYY3hvzwUrt9atjXSk7+?= =?us-ascii?Q?g/XRksgW3nT6O2LFv1O61ism586tPJrughxjOcYHh3TwL0BZDyVH9wy53gcu?= =?us-ascii?Q?DmhCxG5FQndQCCM43ocW6WM9Dg7NU6EJAEpJuWQj3FaVZU0cmDjd3Aqw/JiC?= =?us-ascii?Q?DdJ/mR4AYH0TIMM4hRSWWWqI9PEdODNw+Tvz9wXSIVw7rQwydIYpJKpSShXn?= =?us-ascii?Q?SFzfnlis6ab2F0U0bTPG5OTi/P+dkSF2vrZ63YjiUeA2QBKHu9sSEpITc4tg?= =?us-ascii?Q?G9WxCf5g2qIwEJao8ioTX8D7ivvwK3JXXn0bvjnTK8MvvUjVd0IPCshTfALr?= =?us-ascii?Q?ULAn04VZcNzgcfgQcOxsmLymuhwL9lxpEHL+xBF/ABcCexLC58rDKA2Ykx+m?= =?us-ascii?Q?X9eylCGnk5M2h14KuJdKYcCKFz+PY4rYXKtJAmEsus8c6vFLJvvlYK8z5vtL?= =?us-ascii?Q?9ikbxk8W6uQ+3NhYiQ9GsqwohslBmLo69NEZo0vnbGE/lngEeE/f3KbauN5J?= =?us-ascii?Q?4UMJGFaJSymaFsBxjEpxdmYlH1h1jrtCYhnnoE1ceyCz6Qp2lbV4zJNUyF14?= =?us-ascii?Q?kC8xWljYKot3rDHCMeBlAefSaCFSxpi9Kj7g5nJugG6OcOVTx8SCEU6I58PJ?= =?us-ascii?Q?EoKe2NEKXuh+U3zAj7j9iRh9BvQJg5T0mBTVDq9aB1UAn+aKAoU9RY+3bXM+?= =?us-ascii?Q?l7mqk8WmUtK6tRRB+hoU4jFHzLWs75+vfclY5awS3iNtYBTkt7vrLaNeHGad?= =?us-ascii?Q?+kuxNyI56RcIBQGwTBm09xQhvkfzBQfRYmgLVGqzi0O6MeJfrW9jjWiiMqZ3?= =?us-ascii?Q?lBghFLz/3A4W7/h+yZYQ3j/ibsoy2R+GDqJPXQoq/0W28RAhM4vs0VO00qJy?= =?us-ascii?Q?oTh+VeHglxWv7ZYXcstVsRnekrSMbIaHK991KftnObOrytn2kZvOlGdHeBrZ?= =?us-ascii?Q?s8JWMvGmNBnBpha+RUw7bmnzpoEfkkex85IASMU8sftEwmOYcFNgimQAe/uM?= =?us-ascii?Q?2cWxXIImiWYbr9g9Qm/kearPfZIXTAUv6DLFVTbsdzCpM/Cmgob6mbuZIzFJ?= =?us-ascii?Q?CrrNHd++4fNn4EPG1T7i/hM+4rN19UanK+1C/FbNxBuphAOkYX87AKOY2Kic?= =?us-ascii?Q?bDGHw/aENojSco/IxryaZ42ZnIYNkDn5Y6fzCMSXW6QRdAeqyW4ykS0rCZ21?= =?us-ascii?Q?466XFogyZT9fLxjAcLxHuos5khaTk0au7H1z3HTdyGoU8ugbuzN9ZcnCeaxL?= =?us-ascii?Q?27eXy99RfbrFhOdeW3j37rUwBf1+yG7dsKqv7m0Q/xGzvZwt1+e58GtstPiR?= =?us-ascii?Q?4XEQRA=3D=3D?= X-OriginatorOrg: os.amperecomputing.com X-MS-Exchange-CrossTenant-Network-Message-Id: d20fa825-e35f-4b13-4c7c-08d9c047ae22 X-MS-Exchange-CrossTenant-AuthSource: PH0PR01MB7287.prod.exchangelabs.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Dec 2021 03:53:55.6026 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3bc2b170-fd94-476d-b0ce-4229bdc904a7 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Wdv3U+HfgOuDIJD2/3OiqVx7lvfIY1SHxUWNhNd/Jg/QtvtNu0wFOxSUlc0u00BofUktUHRMcXAzh+OzHUYavsbvnjmPHDpW+3F2gYRqggc= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR01MB7381 Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable Hi Sami, On 16/12/2021 00:06, Sami Mujawar wrote: > Hi Nhi, > > These patches do not cleanly apply. I guess you would need to run=20 > uncrustify for these patches. > > Can you check, please? Sure, will fix all coding style issues found by uncrustify and change to=20 use FixedPcdGetPtr() instead of PcdGetPtr() as your suggestion in the=20 PATCH 3/3. Thanks, Nhi > > Regards, > > Sami Mujawar > > > On 01/12/2021 04:10 AM, Nhi Pham via groups.io wrote: >> This patchset leverages the OemUpdateSmbiosInfo API functions from >> OemMiscLib for updating some HII string fields in the SMBIOS Type 1/2/4 >> because they may be updated dynamically during UEFI booting with the >> data being passed from the pre-UEFI firmware. >> >> Cc: Leif Lindholm >> Cc: Ard Biesheuvel >> Cc: Rebecca Cran >> Signed-off-by: Nhi Pham >> >> Nhi Pham (3): >> =C2=A0=C2=A0 ArmPkg/SmbiosMiscDxe: Remove duplicate HII string definitio= n >> =C2=A0=C2=A0 ArmPkg/SmbiosMiscDxe: Get full SMBIOS strings from OemMiscL= ib >> =C2=A0=C2=A0 ArmPkg/ProcessorSubClassDxe: Get serial and part number fro= m >> =C2=A0=C2=A0=C2=A0=C2=A0 OemMiscLib >> >> =C2=A0 ArmPkg/Include/Library/OemMiscLib.h=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 |=C2=A0 5 +++++ >> =C2=A0 .../ProcessorSubClassDxe/ProcessorSubClass.c=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0 | 14 ++++++++++++-- >> =C2=A0 .../Type01/MiscSystemManufacturerFunction.c=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0 | 10 ++++++++++ >> =C2=A0 .../Type02/MiscBaseBoardManufacturerFunction.c=C2=A0=C2=A0=C2=A0 = | 15 +++++++++++++++ >> =C2=A0 .../Type01/MiscSystemManufacturer.uni=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 |=C2=A0 1 - >> =C2=A0 5 files changed, 42 insertions(+), 3 deletions(-) >> >