From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f68.google.com (mail-wr1-f68.google.com [209.85.221.68]) by mx.groups.io with SMTP id smtpd.web10.10347.1604480925735026805 for ; Wed, 04 Nov 2020 01:08:46 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@akeo-ie.20150623.gappssmtp.com header.s=20150623 header.b=ibCJLg+n; spf=pass (domain: akeo.ie, ip: 209.85.221.68, mailfrom: pete@akeo.ie) Received: by mail-wr1-f68.google.com with SMTP id w14so21158820wrs.9 for ; Wed, 04 Nov 2020 01:08:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=akeo-ie.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=RpAD3rgSk/VMlH+ghZb3siAalH5pOqQ2eBpi+7FMbLM=; b=ibCJLg+nOkxgHtldEIrxqIcIWYt1HTAuodsy4veLqssUqqFSFA2Ale4LmkRyFeswWN sED1zHL24dXexxET1iwv+jVumwDHGrXRqsFh0L+vZUhI0burFQfzMZG2nrzLlhtDWD1V 5zYk8caHy4SdHWXICU/P6wDrlL9SOFwOYucivZU4K/DNCcLmu/1cIw8QHX0RE1R+lIR+ 56tT9XkLoIYqMzihw/w8v3kwQbOBX8QVvl6optV5vyvJaBUGbIZkWfkXfLX3q7aha9Xy X3fyRm5p329vGgJMPKQ9p59CRAqZFZlg7u4zjolPmneOrR/nJltzp3KYY/nlnt3T38iw keLw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=RpAD3rgSk/VMlH+ghZb3siAalH5pOqQ2eBpi+7FMbLM=; b=crd4DLhZKbzgVk59DsG50LQUNzY2d8fh+F9SnSCsBbmTg5KKjGo1C/HKOMvI0TVm8p 3csNixFad7wkRgj4N32Q+uqYgEBh2gFfrjlOKlhMiwDGRWMlRXNvrg/GPi1g0tF9pkUS O85fmObhBcfhF1Daa8K+ty+4xASUe+wQ9UY1R19kAFzOkuguyMXlTJCWdmvpw47MT1wn 0pYTelYeNDQGdRnJ3K54P9XlXn2CnN4WxCFSMrXDrCNyutSR7itdrRtXAe6dQ5SbIEEY NcuJZRX8puOs8r9N9iS67r2mCMlBmmTFA3/4W/ryvhz/4/MLkAcU9j6M5pblQ/LR7jil 3+hw== X-Gm-Message-State: AOAM533j3DaQwLscER3WZYJjS/UowVM2RuATLu6XFeW6HdqZf9AIRcSI MRt9obXCUqvEskkkkwBoNnzUww== X-Google-Smtp-Source: ABdhPJxrxBDJppLPEsPWxvnhfcvCv86cqspkB+btMp5XvfDuArtIo+Z4v0MGkgrYD0OKkJkE464Mfg== X-Received: by 2002:adf:e582:: with SMTP id l2mr30812776wrm.293.1604480924307; Wed, 04 Nov 2020 01:08:44 -0800 (PST) Return-Path: Received: from [10.0.0.122] ([84.203.53.25]) by smtp.googlemail.com with ESMTPSA id t23sm1400747wmn.13.2020.11.04.01.08.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 04 Nov 2020 01:08:43 -0800 (PST) Subject: Re: [edk2-platform][PATCH v1 1/1] Platforms/RaspberryPi: Fix incorrect display resolution To: Samer El-Haj-Mahmoud , devel@edk2.groups.io Cc: Leif Lindholm , Ard Biesheuvel , Andrei Warkentin References: <20200929174830.4955-1-Samer.El-Haj-Mahmoud@arm.com> From: "Pete Batard" Message-ID: <1c69a4a1-e78a-f201-2b25-ca7e2c68334c@akeo.ie> Date: Wed, 4 Nov 2020 09:08:42 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.12.1 MIME-Version: 1.0 In-Reply-To: <20200929174830.4955-1-Samer.El-Haj-Mahmoud@arm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit Looks like noone has reviewed this one yet. Let's fix that. On 2020.09.29 18:48, Samer El-Haj-Mahmoud wrote: > Fix https://github.com/pftf/RPi4/issues/100 by swapping RPi DisplayDxe > resolution settings for 640x480 and 800x600, which were incorrectly > mapped to the settings shown in the Setup configuration variable. > > Cc: Leif Lindholm > Cc: Ard Biesheuvel > Cc: Pete Batard > Cc: Andrei Warkentin > Signed-off-by: Samer El-Haj-Mahmoud > --- > Platform/RaspberryPi/Include/ConfigVars.h | 2 +- > Platform/RaspberryPi/RPi3/Readme.md | 4 ++-- > Platform/RaspberryPi/RPi4/Readme.md | 4 ++-- > 3 files changed, 5 insertions(+), 5 deletions(-) > > diff --git a/Platform/RaspberryPi/Include/ConfigVars.h b/Platform/RaspberryPi/Include/ConfigVars.h > index 8094d4ef9ab9..c185bfe28b55 100644 > --- a/Platform/RaspberryPi/Include/ConfigVars.h > +++ b/Platform/RaspberryPi/Include/ConfigVars.h > @@ -19,8 +19,8 @@ typedef struct { > * > * 800x600, 640x480, 1024x768, 720p, 1080p, native. > */ > - UINT8 v640 : 1; > UINT8 v800 : 1; > + UINT8 v640 : 1; > UINT8 v1024 : 1; > UINT8 v720p : 1; > UINT8 v1080p : 1; > diff --git a/Platform/RaspberryPi/RPi3/Readme.md b/Platform/RaspberryPi/RPi3/Readme.md > index 9080cff15841..3b1171a27c3b 100644 > --- a/Platform/RaspberryPi/RPi3/Readme.md > +++ b/Platform/RaspberryPi/RPi3/Readme.md > @@ -226,8 +226,8 @@ UEFI Setting | NAME | VALUE > CPU Clock | `CpuClock` | Low = `0x00000000`
Default = `0x00000001` (default)
Max = `0x00000002`
Custom = `0x00000003` > CPU Clock Rate (MHz) | `CustomCpuClock` | Hex numeric value, 4-bytes
(e.g. `0x000005DC` for 1500 MHz) > **Display Configuration** | > -Virtual 640x480 | `DisplayEnableScaledVModes` | Checked = Bit 0 set (i.e. ` \| 0x01`) > -Virtual 800x600 | `DisplayEnableScaledVModes` | Checked = Bit 1 set (i.e. ` \| 0x02`) > +Virtual 640x480 | `DisplayEnableScaledVModes` | Checked = Bit 1 set (i.e. ` \| 0x02`) > +Virtual 800x600 | `DisplayEnableScaledVModes` | Checked = Bit 0 set (i.e. ` \| 0x01`) > Virtual 1024x768 | `DisplayEnableScaledVModes` | Checked = Bit 2 set (i.e. ` \| 0x04`) > Virtual 720p | `DisplayEnableScaledVModes` | Checked = Bit 3 set (i.e. ` \| 0x08`) > Virtual 1080p | `DisplayEnableScaledVModes` | Checked = Bit 4 set (i.e. ` \| 0x10`) > diff --git a/Platform/RaspberryPi/RPi4/Readme.md b/Platform/RaspberryPi/RPi4/Readme.md > index 98388e3caba1..3b2ed44e3c38 100644 > --- a/Platform/RaspberryPi/RPi4/Readme.md > +++ b/Platform/RaspberryPi/RPi4/Readme.md > @@ -169,8 +169,8 @@ UEFI Setting | NAME | VALUE > CPU Clock | `CpuClock` | Low = `0x00000000`
Default = `0x00000001` (default)
Max = `0x00000002`
Custom = `0x00000003` > CPU Clock Rate (MHz) | `CustomCpuClock` | Hex numeric value, 4-bytes
(e.g. `0x000005DC` for 1500 MHz) > **Display Configuration** | > -Virtual 640x480 | `DisplayEnableScaledVModes` | Checked = Bit 0 set (i.e. ` \| 0x01`) > -Virtual 800x600 | `DisplayEnableScaledVModes` | Checked = Bit 1 set (i.e. ` \| 0x02`) > +Virtual 640x480 | `DisplayEnableScaledVModes` | Checked = Bit 1 set (i.e. ` \| 0x02`) > +Virtual 800x600 | `DisplayEnableScaledVModes` | Checked = Bit 0 set (i.e. ` \| 0x01`) > Virtual 1024x768 | `DisplayEnableScaledVModes` | Checked = Bit 2 set (i.e. ` \| 0x04`) > Virtual 720p | `DisplayEnableScaledVModes` | Checked = Bit 3 set (i.e. ` \| 0x08`) > Virtual 1080p | `DisplayEnableScaledVModes` | Checked = Bit 4 set (i.e. ` \| 0x10`) > Reviewed-by: Pete Batard