From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 6D93921C8EFB0 for ; Thu, 15 Jun 2017 06:45:56 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id B36B712BA3; Thu, 15 Jun 2017 13:47:12 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com B36B712BA3 Authentication-Results: ext-mx06.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx06.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=lersek@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com B36B712BA3 Received: from lacos-laptop-7.usersys.redhat.com (ovpn-116-40.phx2.redhat.com [10.3.116.40]) by smtp.corp.redhat.com (Postfix) with ESMTP id 1C10896FCB; Thu, 15 Jun 2017 13:47:11 +0000 (UTC) To: Liming Gao , edk2-devel@lists.01.org References: <1497519972-11796-1-git-send-email-liming.gao@intel.com> From: Laszlo Ersek Message-ID: <1c6fd9f9-7f5c-6a5b-21ec-b2ed6246eb7c@redhat.com> Date: Thu, 15 Jun 2017 15:47:11 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: <1497519972-11796-1-git-send-email-liming.gao@intel.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Thu, 15 Jun 2017 13:47:12 +0000 (UTC) Subject: Re: [PATCH v2 staging][BaseToolsOpt 0/4] Enable multiple driver combination X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Jun 2017 13:45:56 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 06/15/17 11:46, Liming Gao wrote: > In V2, > 1) Add SamplePkg to include the example to show the combined drivers in DSC. > 2) Update Read.MD to describe the Depex will be AND together in the combined driver. > > Combine more drivers into the single one can reduce the image size and > compile link time. This patch adds this support in BaseTools. > > Liming Gao (4): > BaseTools: Merge multiple drivers into one for size and link > performance > SamplePkg: Add it to show the edk2 usage case. > SamplePkg: Combine two drivers into one > Update Readme.MD to include multiple driver combination. > > BaseTools/Source/Python/AutoGen/GenC.py | 24 ++- > Readme.MD | 3 + > SamplePkg/SamplePkg.dec | 21 +++ > SamplePkg/SamplePkg.dsc | 264 ++++++++++++++++++++++++++++++++ > 4 files changed, 307 insertions(+), 5 deletions(-) > create mode 100644 SamplePkg/SamplePkg.dec > create mode 100644 SamplePkg/SamplePkg.dsc > Thank you Liming, this looks good to me. Acked-by: Laszlo Ersek Cheers Laszlo