From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by mx.groups.io with SMTP id smtpd.web09.17.1606260159265639623 for ; Tue, 24 Nov 2020 15:22:39 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=J+iBb5EV; spf=pass (domain: redhat.com, ip: 63.128.21.124, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1606260158; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1sfx2ks7bwwVhf/qHKUmTiP9vSSvfmueesxZvVndRRQ=; b=J+iBb5EVqYIWydwQBVctE7kqcLwNMTlIqFEb8RZXXxYTja7/pyx1WfP9ohqnT7kMVPiDmA T7EVKynmNdlg+RuERe0nrnnLEULw3/e68bvIxeIQt3ZdLnwq6A2+mMe+5CVQpIyWe/1Caq 9+ZU9bzlUL96BHHazspP7e+Z8yxXnmU= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-492-Kl1G3YaKOMqGiLpSRYzO1Q-1; Tue, 24 Nov 2020 18:22:34 -0500 X-MC-Unique: Kl1G3YaKOMqGiLpSRYzO1Q-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id E90D418C89D9; Tue, 24 Nov 2020 23:22:32 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-112-25.ams2.redhat.com [10.36.112.25]) by smtp.corp.redhat.com (Postfix) with ESMTP id 5458519C48; Tue, 24 Nov 2020 23:22:28 +0000 (UTC) Subject: Re: [edk2-devel] [PATCH v2 2/6] OvmfPkg/AmdSev: add Grub Firmware Volume Package To: jejb@linux.ibm.com, devel@edk2.groups.io Cc: dovmurik@linux.vnet.ibm.com, Dov.Murik1@il.ibm.com, ashish.kalra@amd.com, brijesh.singh@amd.com, tobin@ibm.com, david.kaplan@amd.com, jon.grimm@amd.com, thomas.lendacky@amd.com, frankeh@us.ibm.com, "Dr . David Alan Gilbert" References: <20201120184521.19437-1-jejb@linux.ibm.com> <20201120184521.19437-3-jejb@linux.ibm.com> <28e99174-79b3-e805-b977-5fed0071a702@redhat.com> <06b9425507ab8c1b35d377cf9bba155b0cc44147.camel@linux.ibm.com> <3b7899fa-fa52-7652-2d2a-d4ec67ece34d@redhat.com> From: "Laszlo Ersek" Message-ID: <1c871b56-f459-5ac4-3b8d-a55d978eac06@redhat.com> Date: Wed, 25 Nov 2020 00:22:27 +0100 MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=lersek@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 11/24/20 17:22, James Bottomley wrote: > On Tue, 2020-11-24 at 16:58 +0100, Laszlo Ersek wrote: >> On 11/24/20 15:54, Laszlo Ersek wrote: > [...] >> Perhaps I can make that recommendation / request more detailed too: >> >> >> * drop: >> >> - UefiRuntimeServicesTableLib: no use of "gRT" >> >> - ReportStatusCodeLib: commit 0a0566d5edad is not relevant, because >> we justifiedly removed TryRunningQemuKernel() >> >> - XenPlatformLib: as discussed before; substitute FALSE for each >> XenDetected() call, and compress the resultant code > > All dropped. > >> * keep: >> >> - BaseLib: for CpuDeadLoop() >> >> - MemoryAllocationLib: for FreePool() >> >> - UefiBootServicesTableLib: for gBS->xxx() >> >> - BaseMemoryLib: for CompareMem() >> >> - DebugLib: for DEBUG() and ASSERT() >> >> - PcdLib: for PcdGet16 (PcdOvmfHostBridgePciDevId) >> >> - UefiBootManagerLib: for APIs central to the functionality of >> PlatformBootManagerLibGrub >> >> - BootLogoLib: for BootLogoEnableLogo() >> >> - DevicePathLib: for a bunch of device path manipulation >> >> - PciLib: mainly for the functions called in PciAcpiInitialization() >> >> - UefiLib: for EfiEventGroupSignal() etc >> >> - PlatformBmPrintScLib: for PlatformBmPrintScRegisterHandler() -- >> this is responsible for printing the boot option processing steps to >> the UEFI console >> >> - Tcg2PhysicalPresenceLib: for >> Tcg2PhysicalItPresenceLibProcessRequest() -- we preserve TPM support >> >> >> Then leaving the trimming of [Packages] to the end makes sense -- >> after trimming everything else, try to remove each package DEC in >> isolation, and see if the lib instance continues to build. > > I can't seem to remove any packages. Even the source debug agent one > is used by the uart devices. OK! Thanks for checking. > > It seems I can get rid of PcdFSBClock > > and in the protocols section (with some header file removal) > > gEfiDecompressProtocolGuid > gEfiS3SaveStateProtocolGuid Yes, I agree removing these is correct; they were also included in my other email at . There are some others that should be possible to remove (pls. refer to the rest of that email). Thanks! Laszlo