From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f169.google.com (mail-pg1-f169.google.com [209.85.215.169]) by mx.groups.io with SMTP id smtpd.web12.2545.1657761557839265782 for ; Wed, 13 Jul 2022 18:19:17 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@gmail.com header.s=20210112 header.b=P4AGRWCZ; spf=pass (domain: gmail.com, ip: 209.85.215.169, mailfrom: kuqin12@gmail.com) Received: by mail-pg1-f169.google.com with SMTP id s27so151077pga.13 for ; Wed, 13 Jul 2022 18:19:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=zxwHORV5O793ixtgpPRCRFepZ8yN+LRQ8Csb2Cu+DnA=; b=P4AGRWCZd61cnSOgu1e6GlGc0FsqoPThdEWi2YBKRcRNVmnSr2HA9ZuNNPuxtOqKOw GObec7cpQvcc5U5pp2V5cZLg+xLzFbfO9P164YG5vF26DlhwcWYgVp0oR7oeF8VZy/MC 1kGxLDfRpMF/pGvXaiNwYd6tgHjexBA0T3Fi0awvbBW7LSGiYYfGRlLdvY7Y1udnMafD 6N0LhwC5wVQ4tvYif8qCtgl/boSDTY+D4IoaHXFa4EKZ/grEFbcwONqjIVfTtcau7CZ+ R7FJ5t140ENhDIYaBmKEc0c4pjJ8/taD74mhtORQTdtO5ZndkFNH8itn+IE1ci6yeTjP LWJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=zxwHORV5O793ixtgpPRCRFepZ8yN+LRQ8Csb2Cu+DnA=; b=xjQCCU3SqZCZw4kKO0g9LbyvKTZVZsCjiP7fXSZI3nhMb6LlpqsZA5QixnfgPK/x/J qFqNDVrYiL53cE39yRnG/MpFP7xFLBFkJNl9uj2/fNolNBB4iXUpbgCQsRQhOQS3ckDC p0EVBY0HxyEAFXTUMAktm+E+tHv0cyUBgzRHYLD7E9l3kOHLR753Q8WLBoLzsFjtVU6w Z66T8jHPlk7SPxGQysQwfzI/UpX8Syekb1P1X+VsYOuSf+z/MeKG7eOCcvX+NXi5Ixva TqRtcLr7fP7T3ehRe5SXOJUidV85299wSjTsqw5nzp/hBBWISCu2kK8UjRYPFDoeZTTM rDTA== X-Gm-Message-State: AJIora/4YSuCRb3gfbRx+K0X6asJurc/j49i+HACT0BdexawwXBk8Fsz rN2wz6iDDYOdJHiAUWujlv00VSPb8ik= X-Google-Smtp-Source: AGRyM1sgBx1zUDmW93hyAKTBGNo5qVRrlBmCvueanZHVuPYohoIcPtSZm046zc103pOxbxd+tLXdKg== X-Received: by 2002:a05:6a00:174b:b0:525:4eea:8ff2 with SMTP id j11-20020a056a00174b00b005254eea8ff2mr5900333pfc.23.1657761557054; Wed, 13 Jul 2022 18:19:17 -0700 (PDT) Return-Path: Received: from ?IPV6:2001:4898:d8:33:b964:c1e8:26aa:4c24? ([2001:4898:80e8:9:397e:c1e8:26aa:4c24]) by smtp.gmail.com with ESMTPSA id f19-20020a17090aa79300b001efff0a4ca4sm111634pjq.51.2022.07.13.18.19.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 13 Jul 2022 18:19:16 -0700 (PDT) Message-ID: <1c9bbdf5-8203-99b5-7c67-50115ff9cf90@gmail.com> Date: Wed, 13 Jul 2022 18:19:16 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [edk2-devel] [edk2-staging][PATCH Kun,v1 0/7] Add TPM subclass definition To: devel@edk2.groups.io, michael.d.kinney@intel.com Cc: "Yao, Jiewen" , "Wang, Jian J" , "Zhang, Qi1" , "Kumar, Rahul1" , Andrew Fish , Leif Lindholm , "Gao, Liming" , "Liu, Zhiguang" References: From: "Kun Qin" In-Reply-To: Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Thanks, Mike. I will drop the applicable code change and send a v2 series shortly. Regards, Kun On 7/13/2022 5:47 PM, Michael D Kinney wrote: > Hi Kun, > > I would prefer to focus on the spec issue with this patch set and only > update DEC and .H file. > > The idea of removing all the status code related PCDs and updating all the > source files to use the #defines is a different change. And that change may > impact many downstream modules/libs that currently use the PCDs. > > Mike > > >> -----Original Message----- >> From: Kun Qin >> Sent: Wednesday, July 13, 2022 5:39 PM >> To: devel@edk2.groups.io; Kinney, Michael D >> Cc: Yao, Jiewen ; Wang, Jian J ; Zhang, Qi1 ; Kumar, Rahul1 >> ; Andrew Fish ; Leif Lindholm ; Gao, Liming >> ; Liu, Zhiguang >> Subject: Re: [edk2-devel] [edk2-staging][PATCH v1 0/7] Add TPM subclass definition >> >> Hi Mike, >> >> The intention was to encourage the usage of new definition in .H file >> once the definition >> is updated. The PCD is left as is only to serve as backwards >> compatibility purpose. >> >> Do you think only updating the DEC and .H file is more ideal? I could >> drop the other changes >> if so desired. >> >> Thanks, >> Kun >> >> On 7/13/2022 5:30 PM, Michael D Kinney wrote: >>> Hi Kun, >>> >>> Why was the PCD usage not preserved and only the value updated in the DEC file and .H file? >>> >>> Mike >>> >>>> -----Original Message----- >>>> From: Kun Qin >>>> Sent: Wednesday, July 13, 2022 5:21 PM >>>> To: devel@edk2.groups.io >>>> Cc: Yao, Jiewen ; Wang, Jian J ; Zhang, Qi1 ; Kumar, >> Rahul1 >>>> ; Andrew Fish ; Leif Lindholm ; Kinney, Michael D >>>> ; Gao, Liming ; Liu, Zhiguang >>>> Subject: Re: [edk2-devel] [edk2-staging][PATCH v1 0/7] Add TPM subclass definition >>>> >>>> Hi SecurityPkg maintainers & EDK2 stewards, >>>> >>>> I sent out this patch series intending to update/fix the PI spec through >>>> code first process. >>>> >>>> Could you please shed some light on it and let me know if any feedback? >>>> >>>> Thanks in advance! >>>> >>>> Regards, >>>> Kun >>>> >>>> On 7/5/2022 8:38 PM, Kun Qin via groups.io wrote: >>>>> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3966 >>>>> >>>>> From PI Specification v1.7 Errata A, EFI_PERIPHERAL_DOCKING is defined as >>>>> 0xD0000 (as well as included in PiStatusCode.h). >>>>> >>>>> However, subclass employed as PCD for TPM peripheral in SecurityPkg is >>>>> also defined as 0xD0000. The TPM subclass code was used in TcgPei.c when >>>>> reporting error codes. >>>>> >>>>> The collision of subclass definition could cause the parsing of reported >>>>> errors being ambiguous. >>>>> >>>>> This patch series add EFI_PERIPHERAL_TPM as a spec-defined value and >>>>> removed potential usages in the SecurityPkg. >>>>> >>>>> Patch v1 branch: https://github.com/kuqin12/edk2/tree/BZ3966-add_tpm_subclass >>>>> >>>>> Cc: Jiewen Yao >>>>> Cc: Jian J Wang >>>>> Cc: Qi Zhang >>>>> Cc: Rahul Kumar >>>>> Cc: Andrew Fish >>>>> Cc: Leif Lindholm >>>>> Cc: Michael D Kinney >>>>> Cc: Liming Gao >>>>> Cc: Zhiguang Liu >>>>> >>>>> Kun Qin (7): >>>>> EDK2 Code First: PI Specification: New peripheral subclass for TPM >>>>> MdePkg: MmCommunication: Add TPM subclass definition to MdePkg >>>>> SecurityPkg: Tcg2Dxe: Replace PcdStatusCodeSubClassTpmDevice >>>>> SecurityPkg: Tcg2Pei: Replace PcdStatusCodeSubClassTpmDevice >>>>> SecurityPkg: TcgDxe: Replace PcdStatusCodeSubClassTpmDevice >>>>> SecurityPkg: TcgPei: Replace PcdStatusCodeSubClassTpmDevice >>>>> SecurityPkg: SubClassTpm: Updated default value >>>>> >>>>> SecurityPkg/Tcg/Tcg2Dxe/Tcg2Dxe.c | 4 +- >>>>> SecurityPkg/Tcg/Tcg2Pei/Tcg2Pei.c | 4 +- >>>>> SecurityPkg/Tcg/TcgDxe/TcgDxe.c | 2 +- >>>>> SecurityPkg/Tcg/TcgPei/TcgPei.c | 4 +- >>>>> CodeFirst/BZ3966-SpecChange.md | 60 ++++++++++++++++++++ >>>>> MdePkg/Include/Pi/PiStatusCode.h | 1 + >>>>> SecurityPkg/SecurityPkg.dec | 6 +- >>>>> SecurityPkg/SecurityPkg.uni | 2 +- >>>>> SecurityPkg/Tcg/Tcg2Dxe/Tcg2Dxe.inf | 1 - >>>>> SecurityPkg/Tcg/Tcg2Pei/Tcg2Pei.inf | 1 - >>>>> SecurityPkg/Tcg/TcgDxe/TcgDxe.inf | 1 - >>>>> SecurityPkg/Tcg/TcgPei/TcgPei.inf | 1 - >>>>> 12 files changed, 72 insertions(+), 15 deletions(-) >>>>> create mode 100644 CodeFirst/BZ3966-SpecChange.md >>>>> >>> >>> >>> > > > >