From: "Laszlo Ersek" <lersek@redhat.com>
To: devel@edk2.groups.io, zhichao.gao@intel.com
Cc: Michael D Kinney <michael.d.kinney@intel.com>,
Liming Gao <liming.gao@intel.com>,
Marvin Hauser <mhaeuser@outlook.de>
Subject: Re: [edk2-devel] [PATCH 0/3] MdePkg/BaseLib: Base64Decode: Make it follow its specification
Date: Fri, 28 Jun 2019 16:28:16 +0200 [thread overview]
Message-ID: <1cc02d63-2cec-38c0-0495-b7af6d424b66@redhat.com> (raw)
In-Reply-To: <20190628035746.24160-1-zhichao.gao@intel.com>
On 06/28/19 05:57, Gao, Zhichao wrote:
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1891
>
> Adjust the coding style.
> Set DestinationSize before return.
> Add addition decription for the RETURN_SUCCESS case.
>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> Cc: Marvin Hauser <mhaeuser@outlook.de>
> Cc: Laszlo Ersek <lersek@redhat.com>
>
> Zhichao Gao (3):
> MdePkg/BaseLib: Adjust the coding style in Base64Decode
> MdePkg/BaseLib: Base64Decode: Make DestinationSize complied to spec
> MdePkg/BaseLib: Base64Decode: Add decription for RETURN_SUCCESS
>
> MdePkg/Library/BaseLib/String.c | 28 ++++++++++++++++++----------
> 1 file changed, 18 insertions(+), 10 deletions(-)
>
I'll try to review patches #2 and #3 in this series later.
If you get sufficient MdePkg owner R-b's meanwhile, don't wait for me
with pushing the patches.
Thanks
Laszlo
next prev parent reply other threads:[~2019-06-28 14:28 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-28 3:57 [PATCH 0/3] MdePkg/BaseLib: Base64Decode: Make it follow its specification Gao, Zhichao
2019-06-28 3:57 ` [PATCH 1/3] MdePkg/BaseLib: Adjust the coding style in Base64Decode Gao, Zhichao
2019-06-28 14:26 ` [edk2-devel] " Laszlo Ersek
2019-07-01 9:24 ` Laszlo Ersek
2019-07-01 9:55 ` Laszlo Ersek
2019-06-28 3:57 ` [PATCH 2/3] MdePkg/BaseLib: Base64Decode: Make DestinationSize complied to spec Gao, Zhichao
2019-07-01 11:03 ` [edk2-devel] " Laszlo Ersek
2019-06-28 3:57 ` [PATCH 3/3] MdePkg/BaseLib: Base64Decode: Add decription for RETURN_SUCCESS Gao, Zhichao
2019-07-01 9:54 ` [edk2-devel] " Laszlo Ersek
2019-06-28 14:28 ` Laszlo Ersek [this message]
2019-07-01 11:02 ` [edk2-devel] [PATCH 0/3] MdePkg/BaseLib: Base64Decode: Make it follow its specification Laszlo Ersek
2019-07-01 11:11 ` Laszlo Ersek
2019-07-01 18:01 ` Laszlo Ersek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1cc02d63-2cec-38c0-0495-b7af6d424b66@redhat.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox