From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR02-AM0-obe.outbound.protection.outlook.com (EUR02-AM0-obe.outbound.protection.outlook.com [40.107.247.48]) by mx.groups.io with SMTP id smtpd.web11.7030.1666787856835271567 for ; Wed, 26 Oct 2022 05:37:37 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=ob8f1Oyi; spf=pass (domain: arm.com, ip: 40.107.247.48, mailfrom: sami.mujawar@arm.com) ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=OnFnZcMVrInZwDnxErmngTOUG3y5Q3ArO8UiAb/AtcK7wQuhGVBHFPy8TTvS6RBwiPlbBOv8WhtXmisaBry3k8Ez5j55dOsLu6wRQgtH6dCePoiiaOQ4qzwmlPnZnBEbT9SvyIdugfIAdxlCgiBnCJWPyY8y4H4QIq6tIFey1VIgo5ZnAdM6Fb3JOR9Pfk9g+jprMMvD0c3J5QYWypFmi6Hd0EekJRk7oFguJ4GKLSjJqgXR8crh+fk8TnoHhSrVHQcut7cCkTkDiPnPyS2RH7LIY/BJJ0nvkuXzxB4SfXZYhnEELAXfgbUWW7Fw1Xs+sqEL+Zk50pp9AYLAjj2Wow== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=qTzDjtolhuA5vOw7BwBkTkaI1CNURMjZUMZYPvVB5lQ=; b=GvVCR0F6aEh+XZ7a9UwtW/eFH5QIRJqmmDqDZaRWPiWfHoKZr3pb9LFZ7EsbUHjsAnimU5Fm8Tyx8wYuMXmH5urcin56CQSnXZ544d30vEYI7zmzn/iH/WFPATRGyixJpdpMBq2PDVQjkpTfqluZjPltJiHXrv7oO3x61GS0U/M6krs6Ul4438NW6HQKxWv2xZWVpo721eg1TGSCxp0kP4qdxc25PFkHncxTYUBBuH5KHgtSYNOT1xL/Um71r8/5B7hYKrLGvq1W3Zbrym/z0Hx88kvA/C2kW8C1QlZOxNs8+KAKU48mv6Ntgu1mR9u+IOFQ7/bJUUj8GqIzZ0Qw6Q== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=qTzDjtolhuA5vOw7BwBkTkaI1CNURMjZUMZYPvVB5lQ=; b=ob8f1OyikNeGwLcCD6QHLdT87Ce64Kzn1aKhLyNpn9hOPJdJKzpl/+8z0T42UfrypM/6fjUVOu2tjKcp0nhKGh384uJU/WCXVyivZlfBOgTWdeT+QGdzCMaUv/Q7iny84hQpp/kaUgSx/p1uvDuSFSFrAiwRPIyUODj9c7bSDGQ= Received: from AS9PR06CA0294.eurprd06.prod.outlook.com (2603:10a6:20b:45a::22) by DU0PR08MB7568.eurprd08.prod.outlook.com (2603:10a6:10:31d::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.33; Wed, 26 Oct 2022 12:37:31 +0000 Received: from AM7EUR03FT027.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:45a:cafe::de) by AS9PR06CA0294.outlook.office365.com (2603:10a6:20b:45a::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.28 via Frontend Transport; Wed, 26 Oct 2022 12:37:31 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT027.mail.protection.outlook.com (100.127.140.124) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.19 via Frontend Transport; Wed, 26 Oct 2022 12:37:31 +0000 Received: ("Tessian outbound 58faf9791229:v130"); Wed, 26 Oct 2022 12:37:31 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 9537e4e508a7a240 X-CR-MTA-TID: 64aa7808 Received: from ae01a9967167.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 6D691C68-2828-4A83-B739-46223C7CE85C.1; Wed, 26 Oct 2022 12:37:24 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id ae01a9967167.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 26 Oct 2022 12:37:24 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FvDfVKzMsTEgdPbz7RTQkgbuyMKd1AOBiCDZIuCAfKRVl7uVH4edIx4fvlJh3esTM4e7qKGiJ0flswVJXz4cPlWrnswjSYyV+hIrmH/BCwda35Nr81nOpaESectGfXm8mR+cxUK/h1cDJXm9jtFY7KRmL82rfpaz/fVPqupIFGyA4HLtlIv64BUwutq83mv0DAESbcbcz4Nr20Ij+XICdNbrzdyJ1FzdSVfNXqK40arknZLPSjfgYTmiz7ML+7vNox/0HuSSA5fC2XgcTVGjlWOHFvsJ4xDLBu2ZT1lWNc7175lhzdSmxG5wxqeEibjv6FMeUZrkiIhp7bj/YJkHxQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=qTzDjtolhuA5vOw7BwBkTkaI1CNURMjZUMZYPvVB5lQ=; b=ka+SbVB3VMDpitiJMgO3l5Zrjd1g/dUDxJ0B9kvWUorm6n80GSPbdlVEuMbTEdOCoHsvD8L3n1HuE3Q7r/KknRQIxZhhmKSEI+j7y2c+4uv6zRrPAKk5yfWx11a51m/cC9WWH72uwkCMsCVPFuHrPfNh8kfO5clqzgvkJY+wZPNaDnLJhpFKNNlhXGhSKxKQ+0N/jBl5y0GgRNMydOFDk3u7RG35QlFIAynzs8KqIKdZcOZXtusi+B+CixmUStGTegfvMwy72KWPyfw316/XVltMuLhU9Q9F2KoVAzXxNBhQU7KmINoicrEx9cMuiqSGriK5imIw1hpnQx1s9K7WUA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=qTzDjtolhuA5vOw7BwBkTkaI1CNURMjZUMZYPvVB5lQ=; b=ob8f1OyikNeGwLcCD6QHLdT87Ce64Kzn1aKhLyNpn9hOPJdJKzpl/+8z0T42UfrypM/6fjUVOu2tjKcp0nhKGh384uJU/WCXVyivZlfBOgTWdeT+QGdzCMaUv/Q7iny84hQpp/kaUgSx/p1uvDuSFSFrAiwRPIyUODj9c7bSDGQ= Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) by PAXPR08MB6398.eurprd08.prod.outlook.com (2603:10a6:102:12d::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.26; Wed, 26 Oct 2022 12:37:22 +0000 Received: from AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::283c:fe2e:699d:2bf]) by AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::283c:fe2e:699d:2bf%5]) with mapi id 15.20.5746.027; Wed, 26 Oct 2022 12:37:22 +0000 Message-ID: <1cc9516d-8032-5786-8e45-5e75e81ed2ac@arm.com> Date: Wed, 26 Oct 2022 13:37:21 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.4.0 Subject: Re: [PATCH 07/14] DynamicTablesPkg: Remove deprecated APIs To: Pierre.Gondois@arm.com, devel@edk2.groups.io Cc: Alexei Fedorov , "nd@arm.com" References: <20221010092058.118714-1-Pierre.Gondois@arm.com> <20221010092058.118714-8-Pierre.Gondois@arm.com> From: "Sami Mujawar" In-Reply-To: <20221010092058.118714-8-Pierre.Gondois@arm.com> X-ClientProxiedBy: LO4P123CA0232.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:1a6::21) To AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) MIME-Version: 1.0 X-MS-TrafficTypeDiagnostic: AS8PR08MB6806:EE_|PAXPR08MB6398:EE_|AM7EUR03FT027:EE_|DU0PR08MB7568:EE_ X-MS-Office365-Filtering-Correlation-Id: 0401c30c-8967-4672-63b8-08dab74ed9a1 x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: GkHBfb3e5gl+JftomKRRhTAOhF1gIdgHc4mwm9tpu1mgv3R71EiR11bBujw0RvEy/CptlNHDNDMipY8m4iMzmto3UL3m0YB8EF7EdlNQcHQ/cjuS61PLyGr31RPH3e2p9MKQkr2X8Y8JVP39E4AkWDAPC29UGTgOa02YxCNDMl8kgw6nF5/nJe5fhhupt9McPt43c42noUX2cU7llwAfdEYiJe6K0xwqTxhgJ7Q6dUbzd1qksrfG6cbmYKHKcQD2fcxq+yQ6B15OEZsRaMNtuwVR/jBVQp0HKxvGroVdKdvLuHJqhlao0bIFIEJZcgmLPBbbGmSEntFDZMktNiGhe/3VMTl3FzcX6LHg7yn1M6mjjIiKoaO/0hYVkgTrI6OBUX6rl9tqPqwOwTwYDnsC7lFW3yf9pq9PmAP93PUKGx2cSBCUSPFyeHNLLweNooaoJmuOKowGJW491vUwk69LMyEXHvGms6Ii66nlnpE0awRiy5zObw5h1YA7eIqcP7TZoXOARLZIVXDsSIIsAafp7PW/8p5PTHYY38uyGBUR8mhbli2NJl3JIUn5LchHL/2XdGxVlx9YYCeQq5wPdqA2IRwO8JPXRBBG1bsSE6erm+7buVm5mjdEeoJBRl+r4ugMV3ZXThTYMZyFk2omga4Rb7blxh6m7JDtO3kGHptHZkocMC5sIMntw9jNJbsb4Cky8xqbsgW9S7f3s8krevbgWTNNpeoyvHAbV6/IABIUd0ItPwOv0u/arFLVyjYINKGnhqs/IZ/lIhIIU7pcLmozqQZC8xT8+ABD0ipB01b/JFo= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB6806.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(136003)(376002)(346002)(366004)(39860400002)(396003)(451199015)(83380400001)(66556008)(86362001)(38100700002)(31696002)(66476007)(30864003)(8936002)(66946007)(5660300002)(44832011)(8676002)(6506007)(4326008)(41300700001)(2906002)(53546011)(6486002)(36756003)(26005)(2616005)(6512007)(54906003)(316002)(478600001)(31686004)(186003)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR08MB6398 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Return-Path: Sami.Mujawar@arm.com X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT027.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 7d73a7c6-eb67-49c4-f4a7-08dab74ed442 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: csjA63zMJ29FikccPJD3RYEMVFfiCLAF8c5znus1bVs/63CR/p9EmAg14k0dVZDGA9fXjhB3bf4Uo7U+IIsCwT4/qgjSZfb2qGcnTq2oQCcTWEZ/sEN6f/w8nN+JM4iE5jJ4wPbEftFlUtrHBah/nTkr9s7gyHQEp2gUeve+cZO5Dt8MHggJng62CPrZV215RB8b011zzK+1ADtA6sK8SELXtk5ZdKTdy9mK4J2Rgxj3FG4uAv+toelkoLiV7NpV+2AoA+wATOVUS7thsSGmAEpdcLWwmN/zxnlOrUpsJMUOjm3IUu2uJ739CtfTVW4efML7TF1NuIWyvbNuiJDLUr9EC4RtBqNzJf6JwkGc62RuGQ6GReLODrnGOEaOgi8oE80jdwLqml/FRj6xVOlfDwT40A4uw4Oa9YFuboBJ3TeNLekU5rfbvHrxju++1KjqSIl/+lUV7ObHw50//lhroKp/Mjg4dJ6h/f6Y4Q8Pc/dHirY7klAcsd/haola57AsqPaL7y/9TUiJUIn3YKRs06iq8oJdXcC3De5svnKYQlXIXBK9IRgtTVEUF393fhF7aWI2X6UDIg5Ufp2RhnncI1B+4jb+bMc/4dtrzW6AofzM9giXrMqRO2EtfmkKcsmDop69Zi9KxJz018wZ9h25PK5wUVU1zRnu1zwjkWaTPZdH40gEIsxlp0dmHgQHuFM9YwN4uX/qm/3A86h028HaiSXIvA4X1bSq1sBZBG/kxjAnBvqk4ZoPe/ZSKpHyEa4qkgYorY0iKIpEliDoyl7qyNyPqrDWZ6LDMVjNZQnQxyVygr3svXbiT+ZbsTVHGNU2 X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(136003)(346002)(376002)(39860400002)(396003)(451199015)(46966006)(40470700004)(36840700001)(83380400001)(31686004)(86362001)(54906003)(44832011)(478600001)(356005)(8676002)(26005)(2906002)(40460700003)(6506007)(31696002)(4326008)(82740400003)(30864003)(40480700001)(41300700001)(8936002)(53546011)(6486002)(5660300002)(81166007)(316002)(36756003)(70586007)(2616005)(6512007)(70206006)(36860700001)(336012)(186003)(82310400005)(47076005)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Oct 2022 12:37:31.2130 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 0401c30c-8967-4672-63b8-08dab74ed9a1 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT027.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB7568 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Pierre, Thank you for this patch. Reviewed-by: Sami Mujawar Regards, Sami Mujawar On 10/10/2022 10:20 am, Pierre.Gondois@arm.com wrote: > From: Pierre Gondois > > commit 691c5f776274 ("DynamicTablesPkg: Deprecate Crs specific methods > in AmlLib") > deprecates some APIs. Finally remove them. > > Signed-off-by: Pierre Gondois > --- > .../Include/Library/AmlLib/AmlLib.h | 138 ------------------ > .../Library/Common/AmlLib/Api/AmlApi.c | 85 ----------- > .../AmlLib/CodeGen/AmlResourceDataCodeGen.c | 76 ---------- > 3 files changed, 299 deletions(-) > > diff --git a/DynamicTablesPkg/Include/Library/AmlLib/AmlLib.h b/DynamicTablesPkg/Include/Library/AmlLib/AmlLib.h > index 0d8446d78256..9210c5091548 100644 > --- a/DynamicTablesPkg/Include/Library/AmlLib/AmlLib.h > +++ b/DynamicTablesPkg/Include/Library/AmlLib/AmlLib.h > @@ -1390,142 +1390,4 @@ AmlCreateCpcNode ( > OUT AML_OBJECT_NODE_HANDLE *NewCpcNode OPTIONAL > ); > > -// DEPRECATED APIS > -#ifndef DISABLE_NEW_DEPRECATED_INTERFACES > - > -/** DEPRECATED API > - > - Get the first Resource Data element contained in a "_CRS" object. > - > - In the following ASL code, the function will return the Resource Data > - node corresponding to the "QWordMemory ()" ASL macro. > - Name (_CRS, ResourceTemplate() { > - QWordMemory (...) {...}, > - Interrupt (...) {...} > - } > - ) > - > - Note: > - - The "_CRS" object must be declared using ASL "Name (Declare Named Object)". > - - "_CRS" declared using ASL "Method (Declare Control Method)" is not > - supported. > - > - @ingroup UserApis > - > - @param [in] NameOpCrsNode NameOp object node defining a "_CRS" object. > - Must have an OpCode=AML_NAME_OP, SubOpCode=0. > - NameOp object nodes are defined in ASL > - using the "Name ()" function. > - @param [out] OutRdNode Pointer to the first Resource Data element of > - the "_CRS" object. A Resource Data element > - is stored in a data node. > - > - @retval EFI_SUCCESS The function completed successfully. > - @retval EFI_INVALID_PARAMETER Invalid parameter. > -**/ > -EFI_STATUS > -EFIAPI > -AmlNameOpCrsGetFirstRdNode ( > - IN AML_OBJECT_NODE_HANDLE NameOpCrsNode, > - OUT AML_DATA_NODE_HANDLE *OutRdNode > - ); > - > -/** DEPRECATED API > - > - Get the Resource Data element following the CurrRdNode Resource Data. > - > - In the following ASL code, if CurrRdNode corresponds to the first > - "QWordMemory ()" ASL macro, the function will return the Resource Data > - node corresponding to the "Interrupt ()" ASL macro. > - Name (_CRS, ResourceTemplate() { > - QwordMemory (...) {...}, > - Interrupt (...) {...} > - } > - ) > - > - The CurrRdNode Resource Data node must be defined in an object named "_CRS" > - and defined by a "Name ()" ASL function. > - > - @ingroup UserApis > - > - @param [in] CurrRdNode Pointer to the current Resource Data element of > - the "_CRS" variable. > - @param [out] OutRdNode Pointer to the Resource Data element following > - the CurrRdNode. > - Contain a NULL pointer if CurrRdNode is the > - last Resource Data element in the list. > - The "End Tag" is not considered as a resource > - data element and is not returned. > - > - @retval EFI_SUCCESS The function completed successfully. > - @retval EFI_INVALID_PARAMETER Invalid parameter. > -**/ > -EFI_STATUS > -EFIAPI > -AmlNameOpCrsGetNextRdNode ( > - IN AML_DATA_NODE_HANDLE CurrRdNode, > - OUT AML_DATA_NODE_HANDLE *OutRdNode > - ); > - > -/** DEPRECATED API > - > - Add an Interrupt Resource Data node. > - > - This function creates a Resource Data element corresponding to the > - "Interrupt ()" ASL function, stores it in an AML Data Node. > - > - It then adds it after the input CurrRdNode in the list of resource data > - element. > - > - The Resource Data effectively created is an Extended Interrupt Resource > - Data. See ACPI 6.3 specification, s6.4.3.6 "Extended Interrupt Descriptor" > - for more information about Extended Interrupt Resource Data. > - > - The Extended Interrupt contains one single interrupt. > - > - This function allocates memory to create a data node. It is the caller's > - responsibility to either: > - - attach this node to an AML tree; > - - delete this node. > - > - Note: The _CRS node must be defined using the ASL Name () function. > - e.g. Name (_CRS, ResourceTemplate () { > - ... > - } > - > - @ingroup CodeGenApis > - > - @param [in] NameOpCrsNode NameOp object node defining a "_CRS" object. > - Must have an OpCode=AML_NAME_OP, SubOpCode=0. > - NameOp object nodes are defined in ASL > - using the "Name ()" function. > - @param [in] ResourceConsumer The device consumes the specified interrupt > - or produces it for use by a child device. > - @param [in] EdgeTriggered The interrupt is edge triggered or > - level triggered. > - @param [in] ActiveLow The interrupt is active-high or active-low. > - @param [in] Shared The interrupt can be shared with other > - devices or not (Exclusive). > - @param [in] IrqList Interrupt list. Must be non-NULL. > - @param [in] IrqCount Interrupt count. Must be non-zero. > - > - > - @retval EFI_SUCCESS The function completed successfully. > - @retval EFI_INVALID_PARAMETER Invalid parameter. > - @retval EFI_OUT_OF_RESOURCES Could not allocate memory. > -**/ > -EFI_STATUS > -EFIAPI > -AmlCodeGenCrsAddRdInterrupt ( > - IN AML_OBJECT_NODE_HANDLE NameOpCrsNode, > - IN BOOLEAN ResourceConsumer, > - IN BOOLEAN EdgeTriggered, > - IN BOOLEAN ActiveLow, > - IN BOOLEAN Shared, > - IN UINT32 *IrqList, > - IN UINT8 IrqCount > - ); > - > -#endif // DISABLE_NEW_DEPRECATED_INTERFACES > - > #endif // AML_LIB_H_ > diff --git a/DynamicTablesPkg/Library/Common/AmlLib/Api/AmlApi.c b/DynamicTablesPkg/Library/Common/AmlLib/Api/AmlApi.c > index 519afdc1eafa..9f162abe2d09 100644 > --- a/DynamicTablesPkg/Library/Common/AmlLib/Api/AmlApi.c > +++ b/DynamicTablesPkg/Library/Common/AmlLib/Api/AmlApi.c > @@ -429,88 +429,3 @@ AmlAttachNode ( > { > return AmlVarListAddTail (ParentNode, NewNode); > } > - > -// DEPRECATED APIS > -#ifndef DISABLE_NEW_DEPRECATED_INTERFACES > - > -/** DEPRECATED API > - > - Get the first Resource Data element contained in a "_CRS" object. > - > - In the following ASL code, the function will return the Resource Data > - node corresponding to the "QWordMemory ()" ASL macro. > - Name (_CRS, ResourceTemplate() { > - QWordMemory (...) {...}, > - Interrupt (...) {...} > - } > - ) > - > - Note: > - - The "_CRS" object must be declared using ASL "Name (Declare Named Object)". > - - "_CRS" declared using ASL "Method (Declare Control Method)" is not > - supported. > - > - @ingroup UserApis > - > - @param [in] NameOpCrsNode NameOp object node defining a "_CRS" object. > - Must have an OpCode=AML_NAME_OP, SubOpCode=0. > - NameOp object nodes are defined in ASL > - using the "Name ()" function. > - @param [out] OutRdNode Pointer to the first Resource Data element of > - the "_CRS" object. A Resource Data element > - is stored in a data node. > - > - @retval EFI_SUCCESS The function completed successfully. > - @retval EFI_INVALID_PARAMETER Invalid parameter. > -**/ > -EFI_STATUS > -EFIAPI > -AmlNameOpCrsGetFirstRdNode ( > - IN AML_OBJECT_NODE_HANDLE NameOpCrsNode, > - OUT AML_DATA_NODE_HANDLE *OutRdNode > - ) > -{ > - return AmlNameOpGetFirstRdNode (NameOpCrsNode, OutRdNode); > -} > - > -/** DEPRECATED API > - > - Get the Resource Data element following the CurrRdNode Resource Data. > - > - In the following ASL code, if CurrRdNode corresponds to the first > - "QWordMemory ()" ASL macro, the function will return the Resource Data > - node corresponding to the "Interrupt ()" ASL macro. > - Name (_CRS, ResourceTemplate() { > - QwordMemory (...) {...}, > - Interrupt (...) {...} > - } > - ) > - > - The CurrRdNode Resource Data node must be defined in an object named "_CRS" > - and defined by a "Name ()" ASL function. > - > - @ingroup UserApis > - > - @param [in] CurrRdNode Pointer to the current Resource Data element of > - the "_CRS" variable. > - @param [out] OutRdNode Pointer to the Resource Data element following > - the CurrRdNode. > - Contain a NULL pointer if CurrRdNode is the > - last Resource Data element in the list. > - The "End Tag" is not considered as a resource > - data element and is not returned. > - > - @retval EFI_SUCCESS The function completed successfully. > - @retval EFI_INVALID_PARAMETER Invalid parameter. > -**/ > -EFI_STATUS > -EFIAPI > -AmlNameOpCrsGetNextRdNode ( > - IN AML_DATA_NODE_HANDLE CurrRdNode, > - OUT AML_DATA_NODE_HANDLE *OutRdNode > - ) > -{ > - return AmlNameOpGetNextRdNode (CurrRdNode, OutRdNode); > -} > - > -#endif // DISABLE_NEW_DEPRECATED_INTERFACES > diff --git a/DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlResourceDataCodeGen.c b/DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlResourceDataCodeGen.c > index 32c3ab534d0b..332962bed441 100644 > --- a/DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlResourceDataCodeGen.c > +++ b/DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlResourceDataCodeGen.c > @@ -1406,79 +1406,3 @@ error_handler: > > return Status; > } > - > -// DEPRECATED APIS > -#ifndef DISABLE_NEW_DEPRECATED_INTERFACES > - > -/** DEPRECATED API > - > - Add an Interrupt Resource Data node. > - > - This function creates a Resource Data element corresponding to the > - "Interrupt ()" ASL function, stores it in an AML Data Node. > - > - It then adds it after the input CurrRdNode in the list of resource data > - element. > - > - The Resource Data effectively created is an Extended Interrupt Resource > - Data. See ACPI 6.3 specification, s6.4.3.6 "Extended Interrupt Descriptor" > - for more information about Extended Interrupt Resource Data. > - > - The Extended Interrupt contains one single interrupt. > - > - This function allocates memory to create a data node. It is the caller's > - responsibility to either: > - - attach this node to an AML tree; > - - delete this node. > - > - Note: The _CRS node must be defined using the ASL Name () function. > - e.g. Name (_CRS, ResourceTemplate () { > - ... > - } > - > - @ingroup UserApis > - > - @param [in] NameOpCrsNode NameOp object node defining a "_CRS" object. > - Must have an OpCode=AML_NAME_OP, SubOpCode=0. > - NameOp object nodes are defined in ASL > - using the "Name ()" function. > - @param [in] ResourceConsumer The device consumes the specified interrupt > - or produces it for use by a child device. > - @param [in] EdgeTriggered The interrupt is edge triggered or > - level triggered. > - @param [in] ActiveLow The interrupt is active-high or active-low. > - @param [in] Shared The interrupt can be shared with other > - devices or not (Exclusive). > - @param [in] IrqList Interrupt list. Must be non-NULL. > - @param [in] IrqCount Interrupt count. Must be non-zero. > - > - > - @retval EFI_SUCCESS The function completed successfully. > - @retval EFI_INVALID_PARAMETER Invalid parameter. > - @retval EFI_OUT_OF_RESOURCES Could not allocate memory. > -**/ > -EFI_STATUS > -EFIAPI > -AmlCodeGenCrsAddRdInterrupt ( > - IN AML_OBJECT_NODE_HANDLE NameOpCrsNode, > - IN BOOLEAN ResourceConsumer, > - IN BOOLEAN EdgeTriggered, > - IN BOOLEAN ActiveLow, > - IN BOOLEAN Shared, > - IN UINT32 *IrqList, > - IN UINT8 IrqCount > - ) > -{ > - return AmlCodeGenRdInterrupt ( > - ResourceConsumer, > - EdgeTriggered, > - ActiveLow, > - Shared, > - IrqList, > - IrqCount, > - NameOpCrsNode, > - NULL > - ); > -} > - > -#endif // DISABLE_NEW_DEPRECATED_INTERFACES