From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-002e3701.pphosted.com (mx0a-002e3701.pphosted.com [148.163.147.86]) by mx.groups.io with SMTP id smtpd.web11.35873.1612794688961960968 for ; Mon, 08 Feb 2021 06:31:29 -0800 Authentication-Results: mx.groups.io; dkim=fail reason="body hash did not verify" header.i=@hpe.com header.s=pps0720 header.b=E9JCev3z; spf=pass (domain: hpe.com, ip: 148.163.147.86, mailfrom: prvs=0673351e1b=daniel.schaefer@hpe.com) Received: from pps.filterd (m0150242.ppops.net [127.0.0.1]) by mx0a-002e3701.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 118ETK8O032006; Mon, 8 Feb 2021 14:31:03 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hpe.com; h=subject : to : cc : references : from : message-id : date : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pps0720; bh=gVTWqpIE8Le3vVu20Z0XsLQjJUY5b4yMR7KAuQRvJAE=; b=E9JCev3zkjPRYSdzpDiH/ep7q3e9+bttJA/asSd+FELjGnTTMzpME8qak1jZsopD7DAW 0YYxJpecspmA4TNBzjCRDLGm9NgE4700BcwId/TRNF3cP0cb0dSmTV2MhPGrgw62SbyJ V6WKqAuXCLMJaUJxj/5Bszhos/jSqvCGQAm9AJUGOVqdJrU3W2+5TAExnwHp7c+f62Q3 bqOpR46hoJCSlSSo7qg8bxa3hX5P5lFDlmoNsl0uSsGmVk56oG3FB4MEseBo1kb5qMKd girpz1zCKKKPYmSbs9f8sipTvb8I85pz/3+8n0695UNmdS9/yakfAYueoYof4RdH1vhk Gw== Received: from g9t5008.houston.hpe.com (g9t5008.houston.hpe.com [15.241.48.72]) by mx0a-002e3701.pphosted.com with ESMTP id 36jymuuvps-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 08 Feb 2021 14:31:03 +0000 Received: from G2W6311.americas.hpqcorp.net (g2w6311.austin.hp.com [16.197.64.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by g9t5008.houston.hpe.com (Postfix) with ESMTPS id D607464; Mon, 8 Feb 2021 14:31:01 +0000 (UTC) Received: from G9W8673.americas.hpqcorp.net (16.220.49.32) by G2W6311.americas.hpqcorp.net (16.197.64.53) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 8 Feb 2021 14:30:52 +0000 Received: from G9W9210.americas.hpqcorp.net (2002:10dc:429b::10dc:429b) by G9W8673.americas.hpqcorp.net (2002:10dc:3120::10dc:3120) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 8 Feb 2021 14:30:51 +0000 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (15.241.52.12) by G9W9210.americas.hpqcorp.net (16.220.66.155) with Microsoft SMTP Server (TLS) id 15.0.1497.2 via Frontend Transport; Mon, 8 Feb 2021 14:30:51 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=f99Ra6oGlS2hj38yp5CSluDeGeHddah7HkLWa6cZ870ZWjEOUnxapt7KOEjjTZLdyHy51u1qhelMskStPxWbyWsjhZs2fXmEpzm8WaQZOsRznnBOaB6zXwqiVbD99LNRTxLZuqb2h+6b2aXvPCwGVenyAMll1NHPrIolTwh4uTDVYKDjvMduzjBCYkR6Sljt7kpcYbOYDtgIqBIOtBsYCdT2U2LtvNYlTwYUIQIsGc8RhY0Zf1kkkDg1xyaMstLuFkiaqc4MeLn5CdAohSmhxq3gJsjhySHHd4AqRAxFCF43KiMCWeJOhVeE0xSuqTMyzhC9wgVYDtLoau69pAF1Hw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0iVQBmIdN6kxPcsqvPvWMkAxIap8fZO2VI+WGHvZMNA=; b=F19wUFrt+CuUkp70XNDGVvGdKiTY+cKt5aTcolntDTVnoQD7EbqB8XuQ6sQXJjJozQ4oufd7cDJMpdvI+8z4GshNo2Vu6dOBv0hPxA38m6Bo3sVZg6AzLPvt/gvY7f2fNs9SSIkXy+RqKOjgzIGkO6/YS+0yPn6+iPbns9/kekP6ny0BH8i9vOfVkrOgqAH7c2OodynPgHnzzwLWxoymZ/2SzxVf24J2xqC6bwaLuxgoZl3rwlA8DJYaD935i/4/zXlcDmqCoXUGmtvSNWcSV1blL1E3zkmhJab8U+X33YCQBfdzl53/Z6ehjWVKV+ygdGfCbNFtt5jtrNKh6nvCCw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=hpe.com; dmarc=pass action=none header.from=hpe.com; dkim=pass header.d=hpe.com; arc=none Authentication-Results: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=hpe.com; Received: from DF4PR8401MB0444.NAMPRD84.PROD.OUTLOOK.COM (2a01:111:e400:760d::23) by DF4PR8401MB0507.NAMPRD84.PROD.OUTLOOK.COM (2a01:111:e400:7605::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3825.20; Mon, 8 Feb 2021 14:30:50 +0000 Received: from DF4PR8401MB0444.NAMPRD84.PROD.OUTLOOK.COM ([fe80::45f0:20e7:1e33:e2a0]) by DF4PR8401MB0444.NAMPRD84.PROD.OUTLOOK.COM ([fe80::45f0:20e7:1e33:e2a0%9]) with mapi id 15.20.3825.030; Mon, 8 Feb 2021 14:30:50 +0000 Subject: Re: [edk2-test PATCH v1 0/2] Add RISCV64 support to SctPkg To: Heinrich Schuchardt , CC: Leif Lindholm , Abner Chang , Gilbert Chen , Eric Jin , "G Edhaya Chandran" , Barton Gao , "Samer El-Haj-Mahmoud" References: <20201201161752.23734-1-daniel.schaefer@hpe.com> <82ec80ae-679e-ae37-6a13-8ef957789a7b@gmx.de> From: "Daniel Schaefer" Message-ID: <1cd523be-3f74-206e-bcdb-9d05f85b717e@hpe.com> Date: Mon, 8 Feb 2021 22:30:22 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.1 In-Reply-To: <82ec80ae-679e-ae37-6a13-8ef957789a7b@gmx.de> X-Originating-IP: [123.193.51.23] X-ClientProxiedBy: HK2PR02CA0131.apcprd02.prod.outlook.com (2603:1096:202:16::15) To DF4PR8401MB0444.NAMPRD84.PROD.OUTLOOK.COM (2a01:111:e400:760d::23) X-MS-Exchange-MessageSentRepresentingType: 1 Received: from [192.168.0.21] (123.193.51.23) by HK2PR02CA0131.apcprd02.prod.outlook.com (2603:1096:202:16::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3825.19 via Frontend Transport; Mon, 8 Feb 2021 14:30:47 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 2017e3a8-dff8-4309-739b-08d8cc3e21ef X-MS-TrafficTypeDiagnostic: DF4PR8401MB0507: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:2657; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: SH6NzzvHQF4polrx1PI4CFB5se9/lLFFNCOiTgl6mAeIIT+mPFLsZY9wJPK/qLXWBXSebVffbHddUBFAFqrvjHcRfPX5wwsI0p18EZVZMZjjxlX4tnyfjwHp8V4CLZrdshKJPq9fcdJkU2nTAFKo7a/EypjiahcGB82wrz3ovpMJKwDiLJC160enqT/4D+R+EPUGmd07qou/Th7xPS0VZgeI5e5HeWUzIih0ji5svpLTjVDLYLn1xdcM85ZKRZCTBqzq2n45qDyIOM3Us3BqxluZdCqwXYuGnMIKjIaxCoPkQwlLs9QJranNpQNicnu01ZWZaDSmGIRFEXCnj20BI88j1LLDwCMlAhlTPPtix0vIXwKvWNHR50UfP/NaH2gu05q52p/bq9tzQhqGIAqF48nRP6exP7TyUUyikDwLIQZnWyV4+T7GlJxSwIquMdFGt1RuPI65zUCoBV1gifzrHNTghBOREITIerCLVFOzgpsFOqo/TBc0m1/DxH5nQd9GUsXJj8/lruwizjmVkbljV+iQcATYgjcFpXELv3RY+Dyd8wi72bVjK/HzkKmV2yohCIWXtGHGFRfuElEATg53EYpOjT7KhaVaR2yyNeiDPcJu77aMG5DpFcOI9xrnzTZOwItcydjWWCcpETxGmqxvaKOsIXhyxU57nXKXQJeJg2+p07sco8ftmkgwP6NZkutIeR80aHxLfsg+rQbzebRgERpYanuhAJhZIJsRaoky0cY= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DF4PR8401MB0444.NAMPRD84.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(376002)(396003)(366004)(346002)(39860400002)(136003)(8676002)(5660300002)(966005)(31686004)(86362001)(6666004)(54906003)(6486002)(956004)(4326008)(44832011)(316002)(16576012)(53546011)(66556008)(66476007)(66946007)(26005)(83380400001)(52116002)(186003)(16526019)(36756003)(478600001)(31696002)(2616005)(8936002)(19627235002)(2906002)(17423001)(156123004)(43740500002)(45980500001);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?enl5YUVlbmRQQjBscC81cENPZjl6MkJlNVdaNEZWdEUzcEhRSEtJK1FkK3I0?= =?utf-8?B?c3UzdG1JYUdzc2ZXcWNmUlcrdEE4YitVdlowaTdmWkJidnBjdXp2NGk5Q0E2?= =?utf-8?B?N1c4QzlheFk3K2pPRVB4RE5xbTF5RHlqU214aWlwVFRPWXJGbFh5L0hmbU5B?= =?utf-8?B?dDMxYW5zcGc2QWhYalh6QjRvTERGRFFJWTFGZ29IQ3gvOWhjVHpCcDFiSFhM?= =?utf-8?B?UzJwVlZqYUNMWUpRdkNhVkZOZEhGSG5PVGI3M3docE8wWUdQNmVjR21CbUZr?= =?utf-8?B?ck9jTWNkV1JjZkdVRFMwcnV2U2RLdjBDOER2Z0YzTlV3TUpEUkVFSUk2VXFB?= =?utf-8?B?MTRLV0dCTjRIK2hKRThrL3Zzc2FpUzdITWVsT0RKSEt0OFBFWnM4MXZTd0dM?= =?utf-8?B?T3hVWlk3b1NXdjlxYVN4ODNCc0ltVFZLa2w1Q2VKRXh2SUthcnpYalJjM2lh?= =?utf-8?B?d0d0SUUvMTZoSkd4OUpLMVJ4c2RLQkVHVzZuWDdGSWJiRWVNU2RiNXNvZ2JK?= =?utf-8?B?dGtxTWVJRzVKbEh3N3NkdlYrUG9tSzBtT2FUVzNvd3RwMUhWN3FmZFVuUjlS?= =?utf-8?B?UW9GcHEvUUZhalZMWjNjb3lHZU1MZWh5Mm5hbmFPS28rL2NPb2VnQTV5UnZ0?= =?utf-8?B?VjY1dTNnSGxSbVpxUGk3cEU5NkpheXNNWjVjeHdpakpZenJIWS91MFNjRk5W?= =?utf-8?B?TVBBMTFwaUx3aHhIQm5mTllMeTBEeldPUURjZ25ES1dGU0VwbkZYdXM5cE93?= =?utf-8?B?emlaYmpYV1dXOWtTdEtSVk1PbTVyYjNyWk1xSlA1d1Q2ZUFzY0F3RlJSSnFr?= =?utf-8?B?L3h2NTRWYUpXL0Yvc01mOXpHZEs4ZGoyNjRqQmZYc3V2djVyZXR0aUJWd1VN?= =?utf-8?B?UkN6VFVrZmRWM0ZVVkpVMnlHZnN5NmwvRmpsV0VuUC8zSkg1blA5RVV0US95?= =?utf-8?B?NEdxZFpKZ3k5K3R3S2Z3R0oxNm1nV0xrSmpBTGgvb3BtVnJCSW5QRG00YjFF?= =?utf-8?B?UDJRNVVQZkNrNUxCY0lKMUdPenROcmlVOUJWMkJPSFBDdDUva0pCdmlCbkI0?= =?utf-8?B?VFZkTUZQeXR1T0c3b3dkSnBrZ1BjQTIvT2dsM1BBVHpjTzFmV3p3NzNCWTFT?= =?utf-8?B?bGQzRGhIZTd4dXU5THh6R2hqeVkxZDRtM0M4ZEFkZklOcUNROXB5NG1LcVJh?= =?utf-8?B?VkRFTUZ4WTB1RGE5SFdYNW5ZMDdFS0lkeVNRZ0UyZFcxd3haNk1lUmRscGhp?= =?utf-8?B?ZGowdUdiNm5FTHZsZ0IzZXA0eFl3bHN4bGEzYW9nOEFRSVBEckxoemwrRStp?= =?utf-8?B?OGJLcnBBUmthWmNFdW5kM0VhdTNLL2ViNTQwaU5ibU90bnpSYlJIb3A0b3Bv?= =?utf-8?B?R2xPZ2tIVXBTZDU1d2FCUjdsWDlHWERxaElHMk8xamVNU3JDaUU1dEtLcC8x?= =?utf-8?B?TnlYVFI0ZURqK20rbk02ejRxbXlHckxGdmhFUWhXVXBZaTFCTlBxUUVCY0ty?= =?utf-8?B?ZlVISHd0enA1Y0tOdHUyWERUL0xVYVI0bWgwZkwzUlNxamxRZzJYOVl0Q3lF?= =?utf-8?B?Szk1SWVOVnZ1QXJmNGNCOE41VzkwQzVSakVETlpRbWp4SzVVb2c2ckJZYW54?= =?utf-8?B?ZU8xU0ZDcnZoWEczc0p0YU5iNFJGamZwNlNaTzdDeE1WSTlOZjlmZVVWMktt?= =?utf-8?B?bktobTl2Z1lMa1lFdThoajdLVEY0MGdqbzV1RjZacC9IL2QxWFhkMFVLRU1y?= =?utf-8?Q?xMdxQg05v/lZ7b0CNwRqNZVyJrQJSLzYZMjUz3+?= X-MS-Exchange-CrossTenant-Network-Message-Id: 2017e3a8-dff8-4309-739b-08d8cc3e21ef X-MS-Exchange-CrossTenant-AuthSource: DF4PR8401MB0444.NAMPRD84.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Feb 2021 14:30:50.4763 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 105b2061-b669-4b31-92ac-24d304d195dc X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Xben4vEYVLi3YpbuCSDIq/OBkZfRtRip3G5gZupPlrzAzzhJTxivDMNEXSSEzRwzgXtUV83pSKAtXaJs5gAJbw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DF4PR8401MB0507 X-OriginatorOrg: hpe.com X-Proofpoint-UnRewURL: 1 URL was un-rewritten MIME-Version: 1.0 X-HPE-SCL: -1 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.369,18.0.737 definitions=2021-02-08_06:2021-02-08,2021-02-08 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1011 impostorscore=0 malwarescore=0 bulkscore=0 phishscore=0 lowpriorityscore=0 spamscore=0 mlxscore=0 mlxlogscore=999 suspectscore=0 priorityscore=1501 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2102080099 X-MIME-Autoconverted: from 8bit to quoted-printable by mx0a-002e3701.pphosted.com id 118ETK8O032006 Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 12/2/20 1:37 AM, Heinrich Schuchardt wrote: > On 12/1/20 6:11 PM, Daniel Schaefer wrote: >> On 12/2/20 12:59 AM, Heinrich Schuchardt wrote: >>> On 12/1/20 5:17 PM, Daniel Schaefer wrote: >>>> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D3042 >>>> >>>> With this patch series we can build the UEFI SCT for RISCV64. It was >>>> confirmed >>>> to be working on the U-Boot UEFI implementation by Heinrich. >>>> It hasn't been tested on EDK2 yet. >>>> >>>> Build requirements are the same as for the EDK2 RISCV64 port and >>>> detailed here: >>>> https://github.com/riscv/riscv-uefi-edk2-docs >>>> >>>> The second patch is a big one because it adds architecture specific >>>> files by >>>> copying them from the Aarch64 directory. Only a single file, an >>>> assembly file >>>> needed modifications. I'm not sure why the other ones are in an >>>> architecture >>>> specific directory. They're all C files and seem to be generic. We >>>> can probably >>>> unify them. >>> >>> Hello Daniel, >>> >>> thanks a lot for your patches. >>> >>> You address the uefi-sct/SctPkg/TestCase/UEFI/EFI directory. >>> >>> Are you planning future patches for uefi-sct/SctPkg/TestCase/UEFI/IHV >>> too? >> >> I grepped the repo for strings related to arm64 and aarch64. I ported >> what I found. >> Do you see anything that's not ported? >=20 > uefi-sct/SctPkg/UEFI/IHV_SCT.dsc is the only IHV related file with > AARCH64 in it and that one is covered by your patch series. >=20 >> >> The only thing I see, is in >> Protocol/UsbIo/BlackBoxTest/UsbIoTestConformance.c >> where some code is not used for ARM because: >> >> =C2=A0 // Note: This function uses the EDKII Glu library from EDKII >> compatibility pkg. >> >> =C2=A0 // which is not ported to ARM yet. Hence for the time being ju= st >> return success. >> >> >> I'm not yet sure what library that's referring to, but most likely it'= s >> also >> not implemented for RISC-V. >=20 > I assume this refers to: > https://github.com/tianocore/edk/tree/master/Foundation/Library/EdkIIGl= ueLib >=20 > The files of this library are in edk2/MdePkg/Library now. Wow, that code is ancient then. I'm not gonna ifdef it out for RISC-V. If it works for x86 it might work for RISC-V now. Maybe the ARM people can try it on ARM first ;) >> Thanks for testing! >> Does the SCT result look like what you expect? Or are some tests faili= ng >> that you expect to succeed? >=20 > Not all tests have run yet. Running SCT on QEMU is really slow. >=20 > But from what I can see there is no difference to AARCH64 results on QE= MU. Sounds great! I assume all the tests have succeeded now? > Best regards >=20 > Heinrich >=20