public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Laszlo Ersek <lersek@redhat.com>
To: Rebecca Cran <rebecca@bluestop.org>
Cc: edk2-devel <edk2-devel@lists.01.org>
Subject: Re: Issues with EDK-II-Debugging wiki page, and how to submit a pull request for wiki pages
Date: Thu, 14 Feb 2019 20:23:05 +0100	[thread overview]
Message-ID: <1ce48d85-8a54-fc57-9fa6-9488b62ccd43@redhat.com> (raw)
In-Reply-To: <61170a4b-c4cd-2dba-966c-ec429184d3c9@bluestop.org>

On 02/14/19 18:39, Rebecca Cran via edk2-devel wrote:
> I noticed a couple of issues with the page
> https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Debugging -
> 'SNI' should be 'SNP', and the |PcdDebugPrintErrorLevel is missing some
> entries.
> |
> 
> 
> How do I fork the wiki repo to make a pull request?

I suggest the following:

(1) clone the wiki to your local workstation. The repo URL is

  git://github.com/tianocore/tianocore.github.io.wiki

(2) In any project that you have *on github*, enable the wiki (specific
to that project). Then, add *that* wiki as a "remote" to your local
clone that was made in step (1):

[remote "mine"]
        url = git@github.com:GITHUB_USERNAME/PROJECT.wiki.git
        tagopt = --no-tags

The command I recommend is

  git remote add --no-tags mine \
    git@github.com:GITHUB_USERNAME/PROJECT.wiki.git

(3) You can develop wiki article changes in your local repo, on a
dedicated topic branch. Simply commit and rebase as you see fit.

(4) For rendering your local changes, force-push your local topic branch
to the master branch of your own wiki:

  git push --force mine TOPIC_BRANCH:master

Then, if you refresh your own wiki page, on github, in your browser, you
should see the changes.

Please note that this step is destructive, with regard to the personal
wiki that you push to.

In addition, IIRC, this step requires SSH pubkey auth to be enabled in
your github profile. (Step 2 could require it too; I'm not certain.)

(5) Once you are done with development, simply format the patches as
usual, and submit them to edk2-devel with git-send-email. For
formatting, use the parameter

  --subject-prefix='edk2-wiki PATCH'

This will tell reviewers the patches are for the wiki.

I can help apply the changes when they are suitably reviewed.

I'm not sure if we have designated maintainers/reviewers for wiki pages.
Usually there is a related area in edk2, so I guess the edk2
maintainer(s) could double in the docs reviewer role too.

> On each page there's
> a "Clone this wiki locally" box where I can clone
> https://github.com/tianocore/tianocore.github.io.wiki.git, but when I
> try and fork it I instead fork
> https://github.com/tianocore/tianocore.github.io which doesn't have the
> same files either on the master or gh-pages branches - it looks like
> https://github.com/tianocore/tianocore.github.io has the files for
> www.tianocore.org, not the wiki?

The wikis on github are non-intuitive, if you intend to edit them in a
normal text editor, locally. I struggled a lot until I came up with the
list on top. (It's possible I relied on others' advice in that; I no
longer remember.) I hope it helps.

Thanks,
Laszlo


  reply	other threads:[~2019-02-14 19:23 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-14 17:39 Issues with EDK-II-Debugging wiki page, and how to submit a pull request for wiki pages Rebecca Cran
2019-02-14 19:23 ` Laszlo Ersek [this message]
2019-02-20  7:45   ` Rebecca Cran
2019-02-20  9:51     ` Laszlo Ersek
2019-02-20 15:00       ` Gao, Liming

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1ce48d85-8a54-fc57-9fa6-9488b62ccd43@redhat.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox