Re: [edk2-devel] [edk2-platforms][PATCH v1 1/1] MinPlatformPkg/TestPointCheckLib: Fix mis-parsed HSTI structures

["Michael Kubacki" <mikuback@linux.microsoft.com>]

Just another reminder to please merge this patch if there is no further 
feedback.

Thanks,
Michael

On 4/1/2022 10:12 AM, Michael Kubacki wrote:
> Thanks for the review.
> 
> Can you please merge this soon if there are no concerns?
> 
> On 3/23/2022 2:14 AM, Chiu, Chasel wrote:
>>
>> Reviewed-by: Chasel Chiu <chasel.chiu@intel.com>
>>
>>
>>> -----Original Message-----
>>> From: mikuback@linux.microsoft.com <mikuback@linux.microsoft.com>
>>> Sent: Wednesday, March 23, 2022 9:11 AM
>>> To: devel@edk2.groups.io
>>> Cc: Bret Barkelew <bret@corthon.com>; Chiu, Chasel
>>> <chasel.chiu@intel.com>; Desimone, Nathaniel L
>>> <nathaniel.l.desimone@intel.com>; Gao, Liming
>>> <gaoliming@byosoft.com.cn>; Dong, Eric <eric.dong@intel.com>
>>> Subject: [edk2-platforms][PATCH v1 1/1]
>>> MinPlatformPkg/TestPointCheckLib: Fix mis-parsed HSTI structures
>>>
>>> From: Michael Kubacki <michael.kubacki@microsoft.com>
>>>
>>> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3612
>>>
>>> Printing corruption can occur if the DumpHsti helper function 
>>> encounters a
>>> structure from the IHV (i.e. one that contains the 'Required' field).
>>>
>>> Co-authored-by: Bret Barkelew <bret@corthon.com>
>>> Cc: Chasel Chiu <chasel.chiu@intel.com>
>>> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
>>> Cc: Liming Gao <gaoliming@byosoft.com.cn>
>>> Cc: Eric Dong <eric.dong@intel.com>
>>> Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
>>> ---
>>>
>>> Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeCheckH
>>> sti.c | 12 +++++++++++-
>>>   1 file changed, 11 insertions(+), 1 deletion(-)
>>>
>>> diff --git
>>> a/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeChec
>>> kHsti.c
>>> b/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeChec
>>> kHsti.c
>>> index 7756369ae17b..f2f3fa83a57c 100644
>>> ---
>>> a/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeChec
>>> kHsti.c
>>> +++
>>> b/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeCh
>>> +++ eckHsti.c
>>> @@ -40,6 +40,16 @@ DumpHsti (
>>>     DEBUG ((DEBUG_INFO, "  SecurityFeaturesSize        - 0x%08x\n", 
>>> Hsti-
>>>> SecurityFeaturesSize));
>>>
>>>     SecurityFeatures = (UINT8 *) (Hsti + 1);
>>> +
>>> +  if (Hsti->Role == PLATFORM_SECURITY_ROLE_PLATFORM_REFERENCE) {
>>> +    DEBUG ((DEBUG_INFO, "  SecurityFeaturesRequired    - "));
>>> +    for (Index = 0; Index < Hsti->SecurityFeaturesSize; Index++) {
>>> +      DEBUG ((DEBUG_INFO, "%02x ", SecurityFeatures[Index]));
>>> +    }
>>> +    DEBUG ((DEBUG_INFO, "\n"));
>>> +    SecurityFeatures = (UINT8 *) (SecurityFeatures +
>>> + Hsti->SecurityFeaturesSize);  }
>>> +
>>>     DEBUG ((DEBUG_INFO, "  SecurityFeaturesImplemented - "));
>>>     for (Index = 0; Index < Hsti->SecurityFeaturesSize; Index++) {
>>>       DEBUG ((DEBUG_INFO, "%02x ", SecurityFeatures[Index])); @@ -81,7
>>> +91,7 @@ TestPointCheckHsti (
>>>     EFI_STATUS  Status;
>>>     UINTN       Index;
>>>     BOOLEAN     Result;
>>> -
>>> +
>>>     Result = TRUE;
>>>     DEBUG ((DEBUG_INFO, "==== TestPointCheckHsti - Enter\n"));
>>>     for (Index = 0; Index < sizeof(mRole)/sizeof(mRole[0]); Index++) {
>>> -- 
>>> 2.28.0.windows.1
>>
>>
>>
>> 
>>