From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 3881D21EB88D9 for ; Fri, 1 Sep 2017 05:20:35 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 3E692806AF; Fri, 1 Sep 2017 12:23:19 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 3E692806AF Authentication-Results: ext-mx02.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx02.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=lersek@redhat.com Received: from lacos-laptop-7.usersys.redhat.com (ovpn-120-176.rdu2.redhat.com [10.10.120.176]) by smtp.corp.redhat.com (Postfix) with ESMTP id 67E9477DC1; Fri, 1 Sep 2017 12:23:18 +0000 (UTC) To: Brijesh Singh , edk2-devel-01 Cc: Jordan Justen References: <20170830155317.30917-1-lersek@redhat.com> <83ac7feb-17a2-bc58-cf39-ba36f88d76f6@amd.com> From: Laszlo Ersek Message-ID: <1d090718-21ea-5d7e-3834-df9ae6d3129c@redhat.com> Date: Fri, 1 Sep 2017 14:23:17 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <83ac7feb-17a2-bc58-cf39-ba36f88d76f6@amd.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.26]); Fri, 01 Sep 2017 12:23:19 +0000 (UTC) Subject: Re: [PATCH 00/11] OvmfPkg: improve SEV-related DEBUG messages X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 01 Sep 2017 12:20:35 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit On 08/31/17 17:14, Brijesh Singh wrote: > > > On 08/30/2017 10:53 AM, Laszlo Ersek wrote: >> Repo:   https://github.com/lersek/edk2.git >> Branch: sev_debug_messages >> >> I've now looked at quite a bit of SEV-related DEBUG messages, and I find >> them really hard to read, and to process with command line utilities >> like grep, sort, uniq. >> >> For example, shell pipelines should be possible to construct with these >> utilities to collect decrypt/encrypt operations, in chronological order, >> grouped by address ever decrypted. >> >> The log should also be human-readable as much as possible -- it >> shouldn't be redundant, but all information for forward- and >> back-referencing should be available. >> >> I propose this series for the above improvements. >> >> Cc: Brijesh Singh >> Cc: Jordan Justen >> > > Very nice improvement in debug message, thank you ! > > Reviewed-by: Brijesh Singh > Tested-by: Brijesh Singh Thank you, pushed as commit range 63ed4d2757eb..1afbb85f8736. Laszlo