public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "PierreGondois" <pierre.gondois@arm.com>
To: Sami Mujawar <sami.mujawar@arm.com>, devel@edk2.groups.io
Cc: ardb+tianocore@kernel.org, quic_llindhol@quicinc.com,
	Suzuki.Poulose@arm.com, Matteo.Carlini@arm.com,
	Akanksha.Jain2@arm.com, Ben.Adderson@arm.com, nd@arm.com
Subject: Re: [PATCH edk2-platforms v1 1/1] Platform/ARM: Reduce System Memory Size for FVP with RME extensions
Date: Tue, 18 Apr 2023 15:59:19 +0200	[thread overview]
Message-ID: <1d0a0375-fd22-1f62-2a53-482f8406a3dc@arm.com> (raw)
In-Reply-To: <20230417132249.15092-1-sami.mujawar@arm.com>

Hi Sami,

Tested-by: Pierre Gondois <pierre.gondois@arm.com>

On 4/17/23 15:22, Sami Mujawar wrote:
> For older FVPs (without support for RME extension) the top 16MB of
> DRAM1 is reserved as Trusted DRAM. However, the latest FVP Base RevC
> AEM Model [1] has support for RME extension. When RME extension is
> present the top 64MB of DRAM1 (i.e. at the top of the 32bit address
> space) is carved out for four-world support in TF-A [2].
> 
> Therefore, reduce the System Memory size by 64MB.
> 
> Reference:
> [1] FVP Base RevC AEM Model (available on x86_64 / Arm64 Linux)
> (https://developer.arm.com/Tools%20and%20Software/
> Fixed%20Virtual%20Platforms)
> 
> [2] commit c872072 (https://review.trustedfirmware.org/plugins/gitiles/
> TF-A/trusted-firmware-a/+/c8720729726faffc39ec64f3a02440a48c8c305a))
> 
> Signed-off-by: Sami Mujawar <sami.mujawar@arm.com>
> ---
>   Platform/ARM/VExpressPkg/ArmVExpress-FVP-AArch64.dsc | 7 +++++--
>   1 file changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/Platform/ARM/VExpressPkg/ArmVExpress-FVP-AArch64.dsc b/Platform/ARM/VExpressPkg/ArmVExpress-FVP-AArch64.dsc
> index dc081794cf98a27c667ef85bd27dacd80e9e8bd2..f70a4d52ba06f570e017ab5286f06d87193753e5 100644
> --- a/Platform/ARM/VExpressPkg/ArmVExpress-FVP-AArch64.dsc
> +++ b/Platform/ARM/VExpressPkg/ArmVExpress-FVP-AArch64.dsc
> @@ -107,9 +107,12 @@ [PcdsFixedAtBuild.common]
>     gArmPlatformTokenSpaceGuid.PcdCPUCorePrimaryStackSize|0x4000
>     gArmPlatformTokenSpaceGuid.PcdCPUCoreSecondaryStackSize|0x0
>   
> -  # System Memory (2GB - 16MB of Trusted DRAM at the top of the 32bit address space)
> +  # System Memory
> +  # When RME is supported by the FVP the top 64MB of DRAM1 (i.e. at the top
> +  # of the 32bit address space) is reserved for four-world support in TF-A.
> +  # Therefore, set the default System Memory size to (2GB - 64MB).
>     gArmTokenSpaceGuid.PcdSystemMemoryBase|0x80000000
> -  gArmTokenSpaceGuid.PcdSystemMemorySize|0x7F000000
> +  gArmTokenSpaceGuid.PcdSystemMemorySize|0x7C000000
>   
>     # Size of the region used by UEFI in permanent memory (Reserved 64MB)
>     gArmPlatformTokenSpaceGuid.PcdSystemMemoryUefiRegionSize|0x04000000

      parent reply	other threads:[~2023-04-18 13:59 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-17 13:22 [PATCH edk2-platforms v1 1/1] Platform/ARM: Reduce System Memory Size for FVP with RME extensions Sami Mujawar
2023-04-18 13:30 ` [edk2-devel] " Leif Lindholm
2023-04-20  8:07   ` Sami Mujawar
2023-04-20  9:52     ` Sami Mujawar
2023-04-18 13:59 ` PierreGondois [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1d0a0375-fd22-1f62-2a53-482f8406a3dc@arm.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox