From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mga09.intel.com (mga09.intel.com [134.134.136.24])
 by mx.groups.io with SMTP id smtpd.web11.8848.1617287239275169696
 for <devel@edk2.groups.io>;
 Thu, 01 Apr 2021 07:27:19 -0700
Authentication-Results: mx.groups.io;
 dkim=missing; spf=none, err=permanent DNS error (domain: linux.intel.com, ip: 134.134.136.24, mailfrom: maciej.rabeda@linux.intel.com)
IronPort-SDR: cEYTdlNM5DkdiXTeUs/tWMYYXDAH/ZMi+LBaIyep/YL9xmD87A5k++UxLFQDlwZ3piNZxFATmX
 jxvhXry56K/Q==
X-IronPort-AV: E=McAfee;i="6000,8403,9941"; a="192357819"
X-IronPort-AV: E=Sophos;i="5.81,296,1610438400"; 
   d="scan'208";a="192357819"
Received: from orsmga004.jf.intel.com ([10.7.209.38])
  by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Apr 2021 07:27:18 -0700
IronPort-SDR: i+jWProfV8lDdzjS2ksWDuKG1omAQiw2JiGqbMQwXBJVXtEtD0gnEvFbfhSSF3eVD/B+s1kTIQ
 yRu3QN3qD8/A==
X-IronPort-AV: E=Sophos;i="5.81,296,1610438400"; 
   d="scan'208";a="528211965"
Received: from mrabeda-mobl.ger.corp.intel.com (HELO [10.249.145.224]) ([10.249.145.224])
  by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Apr 2021 07:27:16 -0700
Subject: Re: [edk2-devel] [patch V4 16/29] NetworkPkg: Consume MdeLibs.dsc.inc for RegisterFilterLib
To: devel@edk2.groups.io, dandan.bi@intel.com
Cc: Jiaxin Wu <jiaxin.wu@intel.com>, Siyuan Fu <siyuan.fu@intel.com>
References: <20210328120229.24828-1-dandan.bi@intel.com>
 <20210328120229.24828-17-dandan.bi@intel.com>
From: "Maciej Rabeda" <maciej.rabeda@linux.intel.com>
Message-ID: <1d15a525-87e3-ea67-38cf-968b5285b1da@linux.intel.com>
Date: Thu, 1 Apr 2021 16:27:15 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.9.0
MIME-Version: 1.0
In-Reply-To: <20210328120229.24828-17-dandan.bi@intel.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: pl

Reviewed-by: Maciej Rabeda <maciej.rabeda@linux.intel.com>

On 28-Mar-21 14:02, Dandan Bi wrote:
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3246
>
> MdeLibs.dsc.inc was added for some basic/default library
> instances provided by MdePkg and RegisterFilterLibNull Library
> was also added into it as the first version of MdeLibs.dsc.inc.
>
> So update platform dsc to consume MdeLibs.dsc.inc for
> RegisterFilterLibNull which will be consumed by IoLib and BaseLib.
>
> Cc: Maciej Rabeda <maciej.rabeda@linux.intel.com>
> Cc: Jiaxin Wu <jiaxin.wu@intel.com>
> Cc: Siyuan Fu <siyuan.fu@intel.com>
> Signed-off-by: Dandan Bi <dandan.bi@intel.com>
> Acked-by: Ard Biesheuvel <ardb@kernel.org>
> ---
>   NetworkPkg/NetworkPkg.dsc | 4 +++-
>   1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/NetworkPkg/NetworkPkg.dsc b/NetworkPkg/NetworkPkg.dsc
> index 531da841e9..5e6619ad85 100644
> --- a/NetworkPkg/NetworkPkg.dsc
> +++ b/NetworkPkg/NetworkPkg.dsc
> @@ -1,10 +1,10 @@
>   ## @file
>   # UEFI 2.4 Network Module Package for All Architectures
>   #
>   # (C) Copyright 2014 Hewlett-Packard Development Company, L.P.<BR>
> -# Copyright (c) 2009 - 2020, Intel Corporation. All rights reserved.<BR>
> +# Copyright (c) 2009 - 2021, Intel Corporation. All rights reserved.<BR>
>   # Copyright (c) 2020, Hewlett Packard Enterprise Development LP. All rights reserved.<BR>
>   #    SPDX-License-Identifier: BSD-2-Clause-Patent
>   #
>   ##
>   
> @@ -18,10 +18,12 @@ [Defines]
>     BUILD_TARGETS                  = DEBUG|RELEASE|NOOPT
>     SKUID_IDENTIFIER               = DEFAULT
>   
>     DEFINE NETWORK_ISCSI_ENABLE    = TRUE
>   
> +!include MdePkg/MdeLibs.dsc.inc
> +
>   [LibraryClasses]
>     DebugLib|MdePkg/Library/BaseDebugLibNull/BaseDebugLibNull.inf
>     BaseLib|MdePkg/Library/BaseLib/BaseLib.inf
>     BaseMemoryLib|MdePkg/Library/BaseMemoryLib/BaseMemoryLib.inf
>     DevicePathLib|MdePkg/Library/UefiDevicePathLib/UefiDevicePathLib.inf