From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=209.85.221.66; helo=mail-wr1-f66.google.com; envelope-from=philmd@redhat.com; receiver=edk2-devel@lists.01.org Received: from mail-wr1-f66.google.com (mail-wr1-f66.google.com [209.85.221.66]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id AAABD2119620A for ; Wed, 28 Nov 2018 07:01:44 -0800 (PST) Received: by mail-wr1-f66.google.com with SMTP id z5so22320073wrt.11 for ; Wed, 28 Nov 2018 07:01:44 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:openpgp:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=ihfQwxxJPJwA9oyGSjIKnanKjkkuF5qh53XItYXFzKg=; b=U0m1KLkQS3828KLS3kmbYv5UkAusrXp3AcBTVNdx+oeLBhLm9bP3+AR91VzrK+pveQ sioKLuxoUJKwNLW+JRE2iy0xGoGv5RTKi/ySZl4bc42OwtWlGkPQFyFxEVG4aXgBAVDf cJg4fG5ZKGdlCv1ybGtkpgqQgABBssnuhoEaWUe4ZxxToM7Z7g6uhAL3DsrzteRpXm9d Sl8AS6MEJmCEpnkizLxAKGsR9V1UZr2M1a/4V+TAekN1Bk/TdvqNNuGm4gk4VJ10qhAF MdoWjO3CQC9tyf8d0U6dw8NwbrPpjgKb4k3CGF7y9d5xNNreq7TI/lfPgUt1YqaEsEt/ ivTg== X-Gm-Message-State: AA+aEWanBSIGcbmh20pLO4+xfB3/SBwgBkkMZcGx02EX8XudNSzAbqcR 1eXaNtc/Zap1nSzAoIqDqhwcpA== X-Google-Smtp-Source: AFSGD/VTFdh9hVG79SycgxoDcEL0UdxYn1WuHYGfPsxSLXhktrvuTvyRdAFYTzd8DTzthp5ehrQVWA== X-Received: by 2002:adf:e707:: with SMTP id c7mr29887137wrm.196.1543417303229; Wed, 28 Nov 2018 07:01:43 -0800 (PST) Received: from ?IPv6:2a01:cb1d:8a0a:f500:48c1:8eab:256a:caf9? ([2a01:cb1d:8a0a:f500:48c1:8eab:256a:caf9]) by smtp.gmail.com with ESMTPSA id q14sm6240453wrw.39.2018.11.28.07.01.40 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 28 Nov 2018 07:01:41 -0800 (PST) To: Ard Biesheuvel , edk2-devel@lists.01.org Cc: Laszlo Ersek , Leif Lindholm , Eric Auger , Andrew Jones , Julien Grall References: <20181128143357.991-1-ard.biesheuvel@linaro.org> <20181128143357.991-10-ard.biesheuvel@linaro.org> From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= Openpgp: id=89C1E78F601EE86C867495CBA2A3FD6EDEADC0DE; url=http://pgp.mit.edu/pks/lookup?op=get&search=0xA2A3FD6EDEADC0DE Message-ID: <1d188dd4-b103-7200-7513-472c83541fbe@redhat.com> Date: Wed, 28 Nov 2018 16:01:40 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.3.0 MIME-Version: 1.0 In-Reply-To: <20181128143357.991-10-ard.biesheuvel@linaro.org> Subject: Re: [PATCH v3 09/16] ArmPkg/CpuPei: base GCD memory space size on CPU's PA range X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 28 Nov 2018 15:01:45 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit On 28/11/18 15:33, Ard Biesheuvel wrote: > Derive the size of the GCD memory space map directly from the CPU's > information registers rather than from the PcdPrePiCpuMemorySize PCD, > which will be removed. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ard Biesheuvel > --- > ArmPkg/Drivers/CpuPei/CpuPei.inf | 1 - > ArmPkg/Drivers/CpuPei/CpuPei.c | 2 +- > 2 files changed, 1 insertion(+), 2 deletions(-) > > diff --git a/ArmPkg/Drivers/CpuPei/CpuPei.inf b/ArmPkg/Drivers/CpuPei/CpuPei.inf > index eafccd600983..dcea012fd8f9 100644 > --- a/ArmPkg/Drivers/CpuPei/CpuPei.inf > +++ b/ArmPkg/Drivers/CpuPei/CpuPei.inf > @@ -50,7 +50,6 @@ [Guids] > gArmMpCoreInfoGuid > > [FixedPcd] > - gEmbeddedTokenSpaceGuid.PcdPrePiCpuMemorySize > gEmbeddedTokenSpaceGuid.PcdPrePiCpuIoSize > > [Depex] > diff --git a/ArmPkg/Drivers/CpuPei/CpuPei.c b/ArmPkg/Drivers/CpuPei/CpuPei.c > index d54f42acfcc8..e63519ff6481 100644 > --- a/ArmPkg/Drivers/CpuPei/CpuPei.c > +++ b/ArmPkg/Drivers/CpuPei/CpuPei.c > @@ -73,7 +73,7 @@ InitializeCpuPeim ( > ArmEnableBranchPrediction (); > > // Publish the CPU memory and io spaces sizes This comment is misleading, maybe 'sizes' -> 'addressable bits'? (not related to this series) > - BuildCpuHob (PcdGet8 (PcdPrePiCpuMemorySize), PcdGet8 (PcdPrePiCpuIoSize)); > + BuildCpuHob (ArmGetPhysicalAddressBits (), PcdGet8 (PcdPrePiCpuIoSize)); Reviewed-by: Philippe Mathieu-Daudé > > // Only MP Core platform need to produce gArmMpCoreInfoPpiGuid > Status = PeiServicesLocatePpi (&gArmMpCoreInfoPpiGuid, 0, NULL, (VOID**)&ArmMpCoreInfoPpi); >