[edk2-test] [PATCH 1/1] uefi-sct/SctPkg: fix typo 'Remained test cases'

[edk2-test] [PATCH 1/1] uefi-sct/SctPkg: fix typo 'Remained test cases'

[Heinrich Schuchardt]

%s/Remained/Remaining/g

Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
---
 .../SctPkg/TestInfrastructure/SCT/Framework/Execute/Execute.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/uefi-sct/SctPkg/TestInfrastructure/SCT/Framework/Execute/Execute.c b/uefi-sct/SctPkg/TestInfrastructure/SCT/Framework/Execute/Execute.c
index 9e7f672e..6fd36914 100644
--- a/uefi-sct/SctPkg/TestInfrastructure/SCT/Framework/Execute/Execute.c
+++ b/uefi-sct/SctPkg/TestInfrastructure/SCT/Framework/Execute/Execute.c
@@ -608,10 +608,10 @@ Routine Description:
   //
   while (TRUE) {
     //
-    // Calculate the number of remained cases
+    // Calculate the number of remaining test cases
     //
     GetTestCaseRemainNum(&Remain);
-    SctPrint(L"  Remained test cases: %d\n", Remain);
+    SctPrint(L"  Remaining test cases: %d\n", Remain);
 
     //
     // Send assertion to remotion computer in passive mode to inform case begin.
-- 
2.23.0.rc1

Re: [edk2-test] [PATCH 1/1] uefi-sct/SctPkg: fix typo 'Remained test cases'

[Eric Jin]

Hi Heinrich Schuchardt,

According to https://github.com/tianocore/tianocore.github.io/wiki/Commit-Message-Format
The statement "Contributed-under:..." need be removed.
With that: Reviewed-by: Eric Jin <eric.jin@intel.com>

If no object, I will help to push with this change by end of this week. 

-----Original Message-----
From: Heinrich Schuchardt <xypron.glpk@gmx.de> 
Sent: Tuesday, September 3, 2019 5:53 PM
To: devel@edk2.groups.io
Cc: Jin, Eric <eric.jin@intel.com>; Supreeth Venkatesh <supreeth.venkatesh@arm.com>; Stephano Cetola <stephano.cetola@linux.intel.com>; Heinrich Schuchardt <xypron.glpk@gmx.de>
Subject: [edk2-test] [PATCH 1/1] uefi-sct/SctPkg: fix typo 'Remained test cases'

%s/Remained/Remaining/g

Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
---
 .../SctPkg/TestInfrastructure/SCT/Framework/Execute/Execute.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/uefi-sct/SctPkg/TestInfrastructure/SCT/Framework/Execute/Execute.c b/uefi-sct/SctPkg/TestInfrastructure/SCT/Framework/Execute/Execute.c
index 9e7f672e..6fd36914 100644
--- a/uefi-sct/SctPkg/TestInfrastructure/SCT/Framework/Execute/Execute.c
+++ b/uefi-sct/SctPkg/TestInfrastructure/SCT/Framework/Execute/Execute.c
@@ -608,10 +608,10 @@ Routine Description:
   //

   while (TRUE) {

     //

-    // Calculate the number of remained cases

+    // Calculate the number of remaining test cases

     //

     GetTestCaseRemainNum(&Remain);

-    SctPrint(L"  Remained test cases: %d\n", Remain);

+    SctPrint(L"  Remaining test cases: %d\n", Remain);

 

     //

     // Send assertion to remotion computer in passive mode to inform case begin.

-- 
2.23.0.rc1

Re: [edk2-test] [PATCH 1/1] uefi-sct/SctPkg: fix typo 'Remained test cases'

[Heinrich Schuchardt]

On 9/4/19 4:27 AM, Jin, Eric wrote:
> Hi Heinrich Schuchardt,
>
> According to https://github.com/tianocore/tianocore.github.io/wiki/Commit-Message-Format
> The statement "Contributed-under:..." need be removed.
> With that: Reviewed-by: Eric Jin <eric.jin@intel.com>
>
> If no object, I will help to push with this change by end of this week.
>

If that contributed-under is not needed anymore, that is great. Please,
feel free to remove it when pushing.

Best regards

Heinrich

Re: [edk2-test] [PATCH 1/1] uefi-sct/SctPkg: fix typo 'Remained test cases'

[Eric Jin]

Pushed at a916582a12c414775a87c65718b7ebb0756f3fb5

-----Original Message-----
From: Heinrich Schuchardt <xypron.glpk@gmx.de> 
Sent: Wednesday, September 4, 2019 2:37 PM
To: Jin, Eric <eric.jin@intel.com>; devel@edk2.groups.io
Cc: Supreeth Venkatesh <supreeth.venkatesh@arm.com>; Stephano Cetola <stephano.cetola@linux.intel.com>
Subject: Re: [edk2-test] [PATCH 1/1] uefi-sct/SctPkg: fix typo 'Remained test cases'

On 9/4/19 4:27 AM, Jin, Eric wrote:
> Hi Heinrich Schuchardt,
>
> According to 
> https://github.com/tianocore/tianocore.github.io/wiki/Commit-Message-F
> ormat The statement "Contributed-under:..." need be removed.
> With that: Reviewed-by: Eric Jin <eric.jin@intel.com>
>
> If no object, I will help to push with this change by end of this week.
>

If that contributed-under is not needed anymore, that is great. Please, feel free to remove it when pushing.

Best regards

Heinrich