Re: [edk2-devel] [PATCH v2 1/2] OvmfPkg/IntelGvtGopDxe: Intel GVT-g GOP Implementation.

["Rebecca Cran" <rebecca@bsdio.com>]

On 3/5/2021 6:19 AM, Laszlo Ersek wrote:

> (3) There's a whole lot of style issues in the code, and I absolutely
> don't see myself identifying every single one of those for you, in a
> 4000+ line driver.
>
> (EFI_D_xxx macro usage, line wrapping issues with multi-line function
> calls, comment style problems, an assumption of varargs support with
> function-like macros on all edk2 toolchains, building the driver only
> for X64, ...)

The other style issue I noticed was the leading double underscores in 
the include guards - e.g.:

diff --git a/OvmfPkg/IntelGvtGopDxe/Common.h b/OvmfPkg/IntelGvtGopDxe/Common.h
new file mode 100644
index 000000000000..cf30752eb8f3
--- /dev/null
+++ b/OvmfPkg/IntelGvtGopDxe/Common.h
@@ -0,0 +1,45 @@
+/** @file
+  Component name for the QEMU video controller.
+
+  Copyright (c) 2021, Intel Corporation. All rights reserved.<BR>
+
+  SPDX-License-Identifier: BSD-2-Clause-Patent
+
+**/
+
+#ifndef __COMMON_H_

-- 
Rebecca Cran