From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out01.mta.xmission.com (out01.mta.xmission.com [166.70.13.231]) by mx.groups.io with SMTP id smtpd.web09.4197.1615524173620507451 for ; Thu, 11 Mar 2021 20:42:53 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@bsdio.com header.s=xmission header.b=ISPfxvll; spf=none, err=SPF record not found (domain: bsdio.com, ip: 166.70.13.231, mailfrom: rebecca@bsdio.com) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=simple/simple; d=bsdio.com; s=xmission; h=Subject:Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Sender:Reply-To:Content-ID :Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To: Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe :List-Post:List-Owner:List-Archive; bh=40qndbJ3En4mNNovu85VyGHwBfAkZLD3JeBK1PSh71Q=; b=ISPfxvllVaKmKy/auqqTU/9cJ7 TQryk+jZyTYinhkqYCaS3Uf6aqy7D5l6FddhXJpDg1wRiSEv+HaCoEjEDtdEE4V07lDQiaPTq8ZqL x2GWqr1D1Yk+QO2XgmPrzCrKN0xhQBYsKuqMKp5pts9JtNVXiJJkte5vcoTjCNWJnSU0=; Received: from in02.mta.xmission.com ([166.70.13.52]) by out01.mta.xmission.com with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1lKZdQ-00HCzo-Hx; Thu, 11 Mar 2021 21:42:48 -0700 Received: from mta4.zcs.xmission.com ([166.70.13.68]) by in02.mta.xmission.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1lKZdP-004jzO-QH; Thu, 11 Mar 2021 21:42:48 -0700 Received: from localhost (localhost [127.0.0.1]) by mta4.zcs.xmission.com (Postfix) with ESMTP id 9FA6A501867; Thu, 11 Mar 2021 21:42:47 -0700 (MST) X-Amavis-Modified: Mail body modified (using disclaimer) - mta4.zcs.xmission.com Received: from mta4.zcs.xmission.com ([127.0.0.1]) by localhost (mta4.zcs.xmission.com [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id Xoygx5chlIYC; Thu, 11 Mar 2021 21:42:47 -0700 (MST) Received: from [10.0.10.120] (c-174-52-16-57.hsd1.ut.comcast.net [174.52.16.57]) by mta4.zcs.xmission.com (Postfix) with ESMTPSA id 5C6F2501846; Thu, 11 Mar 2021 21:42:47 -0700 (MST) To: devel@edk2.groups.io, lersek@redhat.com, colin.xu@intel.com Cc: Gerd Hoffmann , Alex Williamson References: <714af4f188644d03cbb93eb7621c34a6386dff32.1614924813.git.colin.xu@intel.com> <60a24d26-e332-c907-61fe-648957708793@redhat.com> From: "Rebecca Cran" Message-ID: <1d2bf78f-6194-fe3e-0afe-6ebd3aa30839@bsdio.com> Date: Thu, 11 Mar 2021 21:42:46 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <60a24d26-e332-c907-61fe-648957708793@redhat.com> X-XM-SPF: eid=1lKZdP-004jzO-QH;;;mid=<1d2bf78f-6194-fe3e-0afe-6ebd3aa30839@bsdio.com>;;;hst=in02.mta.xmission.com;;;ip=166.70.13.68;;;frm=rebecca@bsdio.com;;;spf=none X-SA-Exim-Connect-IP: 166.70.13.68 X-SA-Exim-Mail-From: rebecca@bsdio.com X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on sa06.xmission.com X-Spam-Level: * X-Spam-Status: No, score=1.3 required=8.0 tests=ALL_TRUSTED,BAYES_50, DCC_CHECK_NEGATIVE,NICE_REPLY_A,T_TM2_M_HEADER_IN_MSG,T_TooManySym_01, T_TooManySym_02,TooManyTo_001,TooManyTo_002,XMSubLong autolearn=disabled version=3.4.2 X-Spam-Report: * -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP * 0.8 BAYES_50 BODY: Bayes spam probability is 40 to 60% * [score: 0.5000] * 0.3 TooManyTo_001 Multiple "To" Header Recipients 2x (uncommon) * 0.5 TooManyTo_002 Multiple "To" Header Recipients 3x (uncommon) * 0.7 XMSubLong Long Subject * 0.0 T_TM2_M_HEADER_IN_MSG BODY: No description available. * -0.0 DCC_CHECK_NEGATIVE Not listed in DCC * [sa06 1397; IP=ok Body=1 Fuz1=1] [Fuz2=1] * 0.0 T_TooManySym_02 5+ unique symbols in subject * 0.0 T_TooManySym_01 4+ unique symbols in subject * -0.0 NICE_REPLY_A Looks like a legit reply (A) X-Spam-DCC: XMission; sa06 1397; IP=ok Body=1 Fuz1=1 Fuz2=1 X-Spam-Combo: *;devel@edk2.groups.io, lersek@redhat.com, colin.xu@intel.com X-Spam-Relay-Country: X-Spam-Timing: total 303 ms - load_scoreonly_sql: 0.11 (0.0%), signal_user_changed: 14 (4.5%), b_tie_ro: 12 (4.0%), parse: 1.25 (0.4%), extract_message_metadata: 4.9 (1.6%), get_uri_detail_list: 0.92 (0.3%), tests_pri_-1000: 3.0 (1.0%), tests_pri_-950: 1.37 (0.5%), tests_pri_-900: 1.11 (0.4%), tests_pri_-90: 53 (17.5%), check_bayes: 52 (17.0%), b_tokenize: 6 (2.0%), b_tok_get_all: 6 (2.1%), b_comp_prob: 2.4 (0.8%), b_tok_touch_all: 34 (11.1%), b_finish: 0.83 (0.3%), tests_pri_0: 211 (69.6%), check_dkim_signature: 0.79 (0.3%), check_dkim_adsp: 63 (20.7%), poll_dns_idle: 56 (18.4%), tests_pri_10: 2.9 (1.0%), tests_pri_500: 8 (2.7%), rewrite_mail: 0.00 (0.0%) Subject: Re: [edk2-devel] [PATCH v2 1/2] OvmfPkg/IntelGvtGopDxe: Intel GVT-g GOP Implementation. X-SA-Exim-Version: 4.2.1 (built Sat, 08 Feb 2020 21:53:50 +0000) X-SA-Exim-Scanned: Yes (on in02.mta.xmission.com) Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US On 3/5/2021 6:19 AM, Laszlo Ersek wrote: > (3) There's a whole lot of style issues in the code, and I absolutely > don't see myself identifying every single one of those for you, in a > 4000+ line driver. > > (EFI_D_xxx macro usage, line wrapping issues with multi-line function > calls, comment style problems, an assumption of varargs support with > function-like macros on all edk2 toolchains, building the driver only > for X64, ...) The other style issue I noticed was the leading double underscores in the include guards - e.g.: diff --git a/OvmfPkg/IntelGvtGopDxe/Common.h b/OvmfPkg/IntelGvtGopDxe/Common.h new file mode 100644 index 000000000000..cf30752eb8f3 --- /dev/null +++ b/OvmfPkg/IntelGvtGopDxe/Common.h @@ -0,0 +1,45 @@ +/** @file + Component name for the QEMU video controller. + + Copyright (c) 2021, Intel Corporation. All rights reserved.
+ + SPDX-License-Identifier: BSD-2-Clause-Patent + +**/ + +#ifndef __COMMON_H_ -- Rebecca Cran