From: "Paolo Bonzini" <pbonzini@redhat.com>
To: Laszlo Ersek <lersek@redhat.com>,
Igor Druzhinin <igor.druzhinin@citrix.com>,
devel@edk2.groups.io
Cc: jordan.l.justen@intel.com, ard.biesheuvel@arm.com,
anthony.perard@citrix.com, julien@xen.org,
Ray Ni <ray.ni@intel.com>
Subject: Re: [PATCH] OvmfPkg: End timer interrupt later to avoid stack overflow under load
Date: Wed, 17 Jun 2020 15:51:28 +0200 [thread overview]
Message-ID: <1d4cd50f-9479-0361-2d23-edda83037243@redhat.com> (raw)
In-Reply-To: <ee7d61de-ed38-acc4-1666-cd886d76cc14@redhat.com>
On 16/06/20 20:42, Laszlo Ersek wrote:
> (Hmmm... maybe the hypervisor *has* to queue the timer interrupts,
> otherwise some of them would simply be lost, and the guest would lose
> track of time.)
Yes, there are various kinds of coalescing of interrupts that
hypervisors perform to help the guest keep track of time. This is
especially true of the PIT and RTC; newer OSes track time directly from
the TSC, the HPET or the APIC timer so they tolerate lost ticks much better.
That said, Igor's patch seems correct to me. In fact, I'd even move
DisableInterrupts before gBS->RestoreTPL unless there's a good reason
not to do so.
Paolo
next prev parent reply other threads:[~2020-06-17 13:51 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-16 2:49 [PATCH] OvmfPkg: End timer interrupt later to avoid stack overflow under load Igor Druzhinin
2020-06-16 18:42 ` Laszlo Ersek
2020-06-17 3:16 ` Igor Druzhinin
2020-06-17 12:44 ` Laszlo Ersek
2020-06-17 13:51 ` Paolo Bonzini [this message]
2020-06-17 15:46 ` Laszlo Ersek
2020-06-17 16:59 ` Paolo Bonzini
2020-06-17 17:23 ` Igor Druzhinin
2020-06-18 8:36 ` Laszlo Ersek
2020-06-18 8:44 ` Laszlo Ersek
2020-06-18 12:10 ` [edk2-devel] " Laszlo Ersek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1d4cd50f-9479-0361-2d23-edda83037243@redhat.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox