From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: redhat.com, ip: 209.132.183.28, mailfrom: lersek@redhat.com) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by groups.io with SMTP; Thu, 11 Jul 2019 05:17:08 -0700 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 7564781F01; Thu, 11 Jul 2019 12:17:08 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-117-231.ams2.redhat.com [10.36.117.231]) by smtp.corp.redhat.com (Postfix) with ESMTP id E864660BFC; Thu, 11 Jul 2019 12:17:06 +0000 (UTC) Subject: Re: [edk2-devel] [PATCH v2 2/3] MdePkg/BaseLib.h: Update IA32_CR4 structure for 5-level paging To: "Kinney, Michael D" , "devel@edk2.groups.io" , "Dong, Eric" , "Ni, Ray" Cc: Leif Lindholm , "Gao, Liming" References: <20190703065416.116816-1-ray.ni@intel.com> <20190703065416.116816-3-ray.ni@intel.com> <23baa040-63a2-3d8f-f75c-91b1d2c0e3ac@redhat.com> From: "Laszlo Ersek" Message-ID: <1d5cdc0f-67ed-6a69-5e69-bba98fff0a65@redhat.com> Date: Thu, 11 Jul 2019 14:17:06 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.25]); Thu, 11 Jul 2019 12:17:08 +0000 (UTC) Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 07/10/19 21:38, Kinney, Michael D wrote: > Laszlo, > > I agree with your feedback. Process must be followed. > > I also agree that it may make sense to add some more maintainers > to the MdePkg, especially for some of the content in MdePkg that > is closely related to the UefiCpuPkg content. Should we ask Ray & Eric to submit a suitable patch for Maintainers.txt (MdePkg) right now, or should we wait until Leif's & Hao's work on the "wildcard path association" feature (for Maintainers.txt) completes? > I have reviewed this patch to the BaseLib.h. The new LA57 bit > added to IA32_CR4 matches the documentation in the white paper > referenced in the series. > > Reviewed-by: Michael D Kinney Thanks! Laszlo > >> -----Original Message----- >> From: Laszlo Ersek [mailto:lersek@redhat.com] >> Sent: Wednesday, July 10, 2019 10:17 AM >> To: devel@edk2.groups.io; Dong, Eric >> ; Ni, Ray >> Cc: Leif Lindholm ; Gao, Liming >> ; Kinney, Michael D >> >> Subject: Re: [edk2-devel] [PATCH v2 2/3] >> MdePkg/BaseLib.h: Update IA32_CR4 structure for 5-level >> paging >> >> Ray, Eric, >> >> (+Liming, +Mike, +Leif) >> >> On 07/09/19 03:04, Dong, Eric wrote: >>> Reviewed-by: Eric Dong >>> >>>> -----Original Message----- >>>> From: Ni, Ray >>>> Sent: Wednesday, July 3, 2019 2:54 PM >>>> To: devel@edk2.groups.io >>>> Cc: Dong, Eric ; Laszlo Ersek >>>> >>>> Subject: [PATCH v2 2/3] MdePkg/BaseLib.h: Update >> IA32_CR4 structure >>>> for 5-level paging >>>> >>>> 5-level paging is documented in white paper: >>>> >> https://software.intel.com/sites/default/files/managed/2b >> /80/5- >>>> level_paging_white_paper.pdf >>>> >>>> Commit f8113e25001e715390127f23e2197252cbd6d1a2 >>>> changed Cpuid.h already. >>>> >>>> This patch updates IA32_CR4 structure to include LA57 >> field. >>>> >>>> Signed-off-by: Ray Ni >>>> Cc: Eric Dong >>>> Regression-tested-by: Laszlo Ersek >>>> --- >>>> MdePkg/Include/Library/BaseLib.h | 3 ++- >>>> 1 file changed, 2 insertions(+), 1 deletion(-) >>>> >>>> diff --git a/MdePkg/Include/Library/BaseLib.h >>>> b/MdePkg/Include/Library/BaseLib.h >>>> index ebd7dd274c..a22bfc9fad 100644 >>>> --- a/MdePkg/Include/Library/BaseLib.h >>>> +++ b/MdePkg/Include/Library/BaseLib.h >>>> @@ -5324,7 +5324,8 @@ typedef union { >>>> UINT32 OSXMMEXCPT:1; ///< Operating System >> Support for >>>> ///< Unmasked SIMD >> Floating Point >>>> ///< Exceptions. >>>> - UINT32 Reserved_0:2; ///< Reserved. >>>> + UINT32 Reserved_2:1; ///< Reserved. >>>> + UINT32 LA57:1; ///< Linear Address >> 57bit. >>>> UINT32 VMXE:1; ///< VMX Enable >>>> UINT32 Reserved_1:18; ///< Reserved. >>>> } Bits; >> >> I'm sorry but you will have to revert this patch series >> immediately. >> None of the MdePkg maintainers have approved this patch - >> - commit 7c5010c7f88b. >> >> In the first place, Mike and Liming were never CC'd on >> the patch, so they may not have noticed it, even. >> >> The situation is very similar to the recent SM3 crypto >> series that I had to revert myself. An MdePkg patch was >> pushed without package owner review. >> >> Can you guys please revert this series immediately, >> without me having to do it? >> >> >> If we think that MdePkg should have more "M" folks, in >> order to distribute the review load better, then we >> should address that problem first. Ignoring rules just >> because that's more convenient is not acceptable. >> >> Thanks, >> Laszlo