From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (EUR04-HE1-obe.outbound.protection.outlook.com [40.107.7.71]) by mx.groups.io with SMTP id smtpd.web08.29964.1639507716415171344 for ; Tue, 14 Dec 2021 10:48:37 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=lh5NhVh+; spf=pass (domain: arm.com, ip: 40.107.7.71, mailfrom: sami.mujawar@arm.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dXyOIENDPhXVNaJs2N24RO+YuWceG9kyfKfdW1i30Pw=; b=lh5NhVh+2mLN0io6zRx7huJ0xry7qKZ9SA5j42J9wV6NfUNNoJPFBBLka7uWGONgn0J9ddF6abd+/VsQoRFG/d1vepsXGOUQxPR8wCLJNPW2UoNyfVg9XG52JQ3Je8cLXK9U8C7m5q8wfX89cTUoAEwpDBcHTkge/nQarRct9Jg= Received: from DU2PR04CA0064.eurprd04.prod.outlook.com (2603:10a6:10:232::9) by AM0PR08MB4932.eurprd08.prod.outlook.com (2603:10a6:208:162::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4778.12; Tue, 14 Dec 2021 18:48:31 +0000 Received: from DB5EUR03FT039.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:232:cafe::42) by DU2PR04CA0064.outlook.office365.com (2603:10a6:10:232::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4778.16 via Frontend Transport; Tue, 14 Dec 2021 18:48:31 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DB5EUR03FT039.mail.protection.outlook.com (10.152.21.120) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4778.12 via Frontend Transport; Tue, 14 Dec 2021 18:48:31 +0000 Received: ("Tessian outbound 1cd1a01725a6:v110"); Tue, 14 Dec 2021 18:48:31 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 6f95d3084a007a0c X-CR-MTA-TID: 64aa7808 Received: from da697b388061.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id C2D7E38E-F624-441F-8E62-1A595D8DC281.1; Tue, 14 Dec 2021 18:48:20 +0000 Received: from EUR02-VE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id da697b388061.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 14 Dec 2021 18:48:20 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CAtFaaDk/WO6JFD6nvBHDb158Pv6ZlqMPIV1QTUdNL58qims6eV6+KVlj+CGFmtoa1VI+GQCXvItCZUYgfTfMlAZ5nhDQ27juGWEdsKKjzk6oN4+gJ/azRlJJK1h9iekFXelhcLhbe5YK4jWRb6STwRTlYOwCNul5mJ/ZDABr4f+J2e5BoBJp87VEJFAgNpbEUvbOyQAdvkEi30pmgLxbmMvagGPvdBnCr5cJ63dhLuobIGXXgWsRqSIBVDoGex5M5zLRUS2ov+JB2VpN5ca2kLK4wdvK3e4K9E4zcGwcfP2gmR/iCMAtMwV+zwlB0NGZR4NL02GOypDe7UpUS/Tng== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=dXyOIENDPhXVNaJs2N24RO+YuWceG9kyfKfdW1i30Pw=; b=fagGVf+Imk7ohxNuobz4jk/o1TBohKm1D9eCWji+Xxxms4zP85NMCMXXJOC5zN37FTnOHv0ZQI3d14AtRJtiJginpeYcrlVj/erPKRAs83e+zlzYSLHM40OwKS+5ysFegYIAA+dB5evT/Z28ix5MpFazfHYnES2dzJSuNy+EhDbACBWURa2c/8ba1DpJXeVtt1JPRuOZHh9v/z268I7pWdLucMeWwe+7Gewe9kV6HEBTW6OidlR6ZOlXVi+r7mSqbxH08LxRh61MyqvCPY4Yf+sUz6ZksIi5WtvgWt+VEVt8Kr3NercJYXB47U3wfazIQMWuIZ66ymAd2ptLR3npJg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dXyOIENDPhXVNaJs2N24RO+YuWceG9kyfKfdW1i30Pw=; b=lh5NhVh+2mLN0io6zRx7huJ0xry7qKZ9SA5j42J9wV6NfUNNoJPFBBLka7uWGONgn0J9ddF6abd+/VsQoRFG/d1vepsXGOUQxPR8wCLJNPW2UoNyfVg9XG52JQ3Je8cLXK9U8C7m5q8wfX89cTUoAEwpDBcHTkge/nQarRct9Jg= Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) by AM5PR0802MB2610.eurprd08.prod.outlook.com (2603:10a6:203:97::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4778.12; Tue, 14 Dec 2021 18:48:18 +0000 Received: from AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::bdcf:cfa6:b2bb:38ac]) by AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::bdcf:cfa6:b2bb:38ac%6]) with mapi id 15.20.4755.021; Tue, 14 Dec 2021 18:48:18 +0000 Subject: Re: [PATCH v3 0/5] Add DynamicPlatRepoLib To: Pierre.Gondois@arm.com, devel@edk2.groups.io Cc: Alexei Fedorov References: <20211209093251.1249368-1-Pierre.Gondois@arm.com> From: "Sami Mujawar" Message-ID: <1d6c33d5-5f05-5dfa-2666-962445ebdeeb@arm.com> Date: Tue, 14 Dec 2021 18:48:26 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.0.1 In-Reply-To: <20211209093251.1249368-1-Pierre.Gondois@arm.com> X-ClientProxiedBy: LO2P265CA0225.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:b::21) To AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) MIME-Version: 1.0 Received: from [10.1.196.43] (217.140.106.50) by LO2P265CA0225.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:b::21) with Microsoft SMTP Server (version=TLS1_2, cipher=) via Frontend Transport; Tue, 14 Dec 2021 18:48:18 +0000 X-MS-Office365-Filtering-Correlation-Id: 300d1f63-c2e3-4937-a5d1-08d9bf325353 X-MS-TrafficTypeDiagnostic: AM5PR0802MB2610:EE_|DB5EUR03FT039:EE_|AM0PR08MB4932:EE_ X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Oob-TLC-OOBClassifiers: OLM:5797;OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: De8Dv/SBq06TjzMjNLSU5E5PodhPqElcMLrbPZLnou+BndxWR5y9/lMJ/nFECjkzZYiyZyc9zE7hgzI0smsK79kozuqLhYBVS9tDQsVLHNkQNIC0KSbRX2l+6Bk7G/r4xSgSiHqqHjZFpoArE2JVZKpw5T7iHJR6Di0ABkK5wtHdo2M1iyMrkDc8diyHQ/JUd2Mjb7B4um3XNuesD0Fd57yzdHBzBE3ULqV3O7c00/8kLTaABc8cOU/aoEJ1UWCrr8xQpqxGPrffEk/3CaHbiDr/v3boncvKpjL6Rpqe2uvth6YKPqIn9GzKb/+XcsWpeIeUQ4aPS1iWsYu88E+neuEh8Jvb9p+0GNTWL6nl1gSw9DOTTlJp2ryxxLabVXkhtenYHBBrTAtGWQWBiiYx1btgjWsOgQGH0D4LSV3os6wspYGVmvBz+6e7WarlflxYadquJEbebCxq0ZWdvZ5eJmXRaRDKjgwoy+osaAO/BvSVQ2N7wmMrFF0aWUBulQAzmoCsAqRpvpLvJ4d1eS7MzKrU76ylghQacwewPuHt9VBm0WE5DkJBf5PR3R2hLQecG9WiMczJApb9xv7G6mPKuMyk2liSTWeWEbhHuh2yvtzlymSuQsYeK3A4rcIk4MtTx5gNtrQVGMwbebi12827HFe/cuYmc/gq04omW/CaNPyprWG/AnsOP2HlrJquFpLkQh6uTa7ReWF7YuArENyVVA+cf82kHgF4pIiVpolUoDSt3YHnbae2Tza8+0DOS/sLwp9jSbqevIgnqw6vo3Le/Kr9Y0TbOFLmw3+0hDT/dmC+HT07F7EhIRocvYiom6RjbJ4Mn7z1yBmxXeafhCdXFBO4VcCnKuakJuwgHsJz+f/L/6EqvSY+YhOOtI5YqD0mzgJ9nCvbgfp3yCoyw2PZ6w== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB6806.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(966005)(2616005)(956004)(6486002)(508600001)(36756003)(66946007)(53546011)(52116002)(38350700002)(316002)(31696002)(2906002)(86362001)(66476007)(8676002)(66556008)(8936002)(4326008)(31686004)(83380400001)(44832011)(186003)(26005)(16576012)(38100700002)(5660300002)(6666004)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR0802MB2610 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Return-Path: Sami.Mujawar@arm.com X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DB5EUR03FT039.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 8096d55c-3319-4c48-8a24-08d9bf324b59 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: vxfRSZXBRZFfk9W42nHid4gWUw6oM+oXV9S73YhTBT4ZEaqwo+mCQHdP14VAyp2XeuJqS1IkohhzaSrfuNAuBT6L40IV+wP8At3Th50jK32QC4mXHPTJ5NU/mh+HtlriSxnMxaANpiht/Z5rHAatygHYj+yynlqzsnn/7YZs6J1r4dMiiAZNw4iTXZjYEdByVDaCwFY0+3C1BHAOsMj3gPVxUtDT4M89/IrNg2O9mLvmK6827wllHXJAWasR78BZGJZIjJ5Q2rPZ/K2sc/7xMab9I84mjJjYwpp1WmxtJmWw5eR9OsikTU5XURiDBuBJ+pBtlAX7lvD+5/ENEpz8ewHICikyxJlP77w2TnQPsu+EH0ydNZDuffurWXKcwTdiI34+k8NtlgG2T8ahKRkw7TZhJyWkS+QgFaLCJyCHW6pWTt73CVJg/B4/3gAPZeEEK7NdC2u+fUWC/jc8heMQ3fh7WgCZPVNw92Uk39mW9zmNC9wZLq58+j4r+1StuvqI8E+Q6nhXk2PUZUdD9a1l4W0/J6kYYo+zmQIxtSELji0ChG8gIcUzxNjEihs5ZUTwBulVT4d3OhYJl10Rh+pVJSAfB4GMqfO/xarK6FsDOWlgkSbGcTH9e6923Lk5ZC/7FTnw/aeDMz15kj6tCWhruZGEXkpiy11iLf14hSp/T4xHIcffpC88uixvrW5tCBSgxueUSiJoRLEtPSLa70griJUN5klZLWfCsXH9zSSaF1MEidHtWvdnu83T0JuKI1/N8io0mRZdZ63Zq7K3XX3SlbowSbdBWr4M4nktGhq8PRTlMbnvKlRl7sybs3TSAvYlT2E6mSjSfDA7+crtNtg4up5Eql5Woze4m9Df1ObpnVGnyjWM4zH56Eg9YG1Udq/lmu1CsqItJTnGERoNB97kKARg6UVipnRfa0/pkIDpHbg= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(36840700001)(46966006)(40470700001)(8936002)(26005)(40460700001)(82310400004)(316002)(16576012)(8676002)(966005)(47076005)(186003)(2616005)(86362001)(6666004)(508600001)(53546011)(70206006)(31686004)(70586007)(36756003)(36860700001)(356005)(81166007)(336012)(4326008)(31696002)(2906002)(6486002)(83380400001)(5660300002)(956004)(44832011)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Dec 2021 18:48:31.6740 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 300d1f63-c2e3-4937-a5d1-08d9bf325353 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DB5EUR03FT039.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB4932 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable Content-Language: en-GB Pushed as 9006967c8d24..38f6d78c3b62 Regards, Sami Mujawar On 09/12/2021 09:32 AM, Pierre.Gondois@arm.com wrote: > From: Pierre Gondois > > v3: > - Run uncrustify and apply the required formatting. [Pierre] > - No other change with v2. [Pierre] > v2: > - Various small fixes (change status returned, reset values when > freeing memory, ...). [Sami] > > Ref:https://bugzilla.tianocore.org/show_bug.cgi?id=3D3743 > > The DynamicPlatRepoLib is library allowing to receive and then > give Configuration Manager (CM) objects. > After being initialized, a dynamic platform repository can receive > CMObjects. The library generates a token to uniquely identify the > CMObject in the repository. The dynamic platform repository must > then be 'finalized' before receiving CMObject queries. > > This library is complementary to the 'static' definition of > CMObjects (i.e. as C structs). It is particularly useful when > using a HwInfoParserLib that dynamically creates CMObjects > (from a device tree for instance). > > The changes can be seen at: https://github.com/PierreARM/edk2/tree/1788_A= dd_Dynamic_Plarform_Repository_Lib_v3 > > Pierre Gondois (5): > DynamicTablesPkg: Definition for DynamicPlatRepoLib interface > DynamicTablesPkg: DynamicPlatRepo: Add TokenGenerator > DynamicTablesPkg: DynamicPlatRepo: Add TokenFixer > DynamicTablesPkg: DynamicPlatRepo: Add TokenMapper > DynamicTablesPkg: Add DynamicPlatRepo library > > DynamicTablesPkg/DynamicTablesPkg.dec | 3 + > DynamicTablesPkg/DynamicTablesPkg.dsc | 1 + > .../Include/Library/DynamicPlatRepoLib.h | 114 ++++ > .../DynamicPlatRepoLib/CmObjectTokenFixer.c | 165 ++++++ > .../DynamicPlatRepoLib/CmObjectTokenFixer.h | 52 ++ > .../DynamicPlatRepoLib/DynamicPlatRepo.c | 521 ++++++++++++++++++ > .../DynamicPlatRepoInternal.h | 78 +++ > .../DynamicPlatRepoLib/DynamicPlatRepoLib.inf | 33 ++ > .../DynamicPlatRepoLib/TokenGenerator.c | 29 + > .../DynamicPlatRepoLib/TokenGenerator.h | 26 + > .../Common/DynamicPlatRepoLib/TokenMapper.c | 224 ++++++++ > .../Common/DynamicPlatRepoLib/TokenMapper.h | 123 +++++ > 12 files changed, 1369 insertions(+) > create mode 100644 DynamicTablesPkg/Include/Library/DynamicPlatRepoLib.= h > create mode 100644 DynamicTablesPkg/Library/Common/DynamicPlatRepoLib/C= mObjectTokenFixer.c > create mode 100644 DynamicTablesPkg/Library/Common/DynamicPlatRepoLib/C= mObjectTokenFixer.h > create mode 100644 DynamicTablesPkg/Library/Common/DynamicPlatRepoLib/D= ynamicPlatRepo.c > create mode 100644 DynamicTablesPkg/Library/Common/DynamicPlatRepoLib/D= ynamicPlatRepoInternal.h > create mode 100644 DynamicTablesPkg/Library/Common/DynamicPlatRepoLib/D= ynamicPlatRepoLib.inf > create mode 100644 DynamicTablesPkg/Library/Common/DynamicPlatRepoLib/T= okenGenerator.c > create mode 100644 DynamicTablesPkg/Library/Common/DynamicPlatRepoLib/T= okenGenerator.h > create mode 100644 DynamicTablesPkg/Library/Common/DynamicPlatRepoLib/T= okenMapper.c > create mode 100644 DynamicTablesPkg/Library/Common/DynamicPlatRepoLib/T= okenMapper.h > > -- > 2.25.1 IMPORTANT NOTICE: The contents of this email and any attachments are confid= ential and may also be privileged. If you are not the intended recipient, p= lease notify the sender immediately and do not disclose the contents to any= other person, use it for any purpose, or store or copy the information in = any medium. Thank you.