From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id B15BDD811B1 for ; Thu, 11 Jan 2024 09:42:12 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=x4rP9sVLq63MrCxUq5sV3MmtZLPofNrNjDRWdU2nk+U=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1704966131; v=1; b=W4Ad+/DTPBvV7obCGBaiieg+d0xt6iE0MsnCFKihC90iN0vBCGpa0myY/I2JgGtE9pvC38wJ xY4R+Ce2w1GxqW5JE6uLlS4CrRdT3qOTAqmHP3uw76M40xoFmDtmCxJaH3R88p8vE3O+S8WnySE Xr8+Jwjp/3nmRkPVKKFdGauE= X-Received: by 127.0.0.2 with SMTP id AcE4YY7687511xDrAninde0L; Thu, 11 Jan 2024 01:42:11 -0800 X-Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.groups.io with SMTP id smtpd.web11.8178.1704966130569076970 for ; Thu, 11 Jan 2024 01:42:10 -0800 X-Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-558-Y3kmsxpIPU6F8m9uhVZwWw-1; Thu, 11 Jan 2024 04:42:06 -0500 X-MC-Unique: Y3kmsxpIPU6F8m9uhVZwWw-1 X-Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 6118E1C068CC; Thu, 11 Jan 2024 09:42:06 +0000 (UTC) X-Received: from [10.39.193.20] (unknown [10.39.193.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 7B9C5C15E6A; Thu, 11 Jan 2024 09:42:05 +0000 (UTC) Message-ID: <1d841eb8-5c82-6ea1-6ed0-b5f9a032e978@redhat.com> Date: Thu, 11 Jan 2024 10:42:04 +0100 MIME-Version: 1.0 Subject: Re: [edk2-devel] [PATCH] UefiCpuPkg: change name of gMpInformationHobGuid2 To: Dun Tan , devel@edk2.groups.io Cc: Ray Ni , Rahul Kumar , Gerd Hoffmann References: <20240111090055.1721-1-dun.tan@intel.com> From: "Laszlo Ersek" In-Reply-To: <20240111090055.1721-1-dun.tan@intel.com> X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.8 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,lersek@redhat.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: J3BbnUUPNB3VSK65srwkqIkZx7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b="W4Ad+/DT"; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=redhat.com (policy=none) On 1/11/24 10:00, Dun Tan wrote: > Change name of gMpInformationHobGuid2 to > gMpInformation2HobGuid. It's to align with > the file name MpInformation2.h and the > structure name MP_INFORMATION2_HOB_DATA. >=20 > Signed-off-by: Dun Tan > Cc: Ray Ni > Cc: Laszlo Ersek > Cc: Rahul Kumar > Cc: Gerd Hoffmann > --- > UefiCpuPkg/CpuMpPei/CpuMpPei.c | 8 ++++---- > UefiCpuPkg/CpuMpPei/CpuMpPei.inf | 2 +- > UefiCpuPkg/Include/Guid/MpInformation2.h | 2 +- > UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.c | 6 +++--- > UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.inf | 2 +- > UefiCpuPkg/UefiCpuPkg.dec | 2 +- > 6 files changed, 11 insertions(+), 11 deletions(-) >=20 > diff --git a/UefiCpuPkg/CpuMpPei/CpuMpPei.c b/UefiCpuPkg/CpuMpPei/CpuMpPe= i.c > index 93919be94f..2ce4d6ab50 100644 > --- a/UefiCpuPkg/CpuMpPei/CpuMpPei.c > +++ b/UefiCpuPkg/CpuMpPei/CpuMpPei.c > @@ -566,7 +566,7 @@ GetProcessorCoreType ( > } > =20 > /** > - Create gMpInformationHobGuid2. > + Create gMpInformation2HobGuid. > **/ > VOID > BuildMpInformationHob ( > @@ -618,13 +618,13 @@ BuildMpInformationHob ( > // > // Create MP_INFORMATION2_HOB. when the max HobLength 0xFFF8 is not en= ough, there > // will be a MP_INFORMATION2_HOB series in the HOB list. > - // In the HOB list, there is a gMpInformationHobGuid2 with 0 value Num= berOfProcessors > + // In the HOB list, there is a gMpInformation2HobGuid with 0 value Num= berOfProcessors > // fields to indicate it's the last MP_INFORMATION2_HOB. > // > while (NumberOfProcessorsInHob !=3D 0) { > NumberOfProcessorsInHob =3D MIN (NumberOfProcessors - ProcessorIndex= , MaxProcessorsPerHob); > MpInformation2HobData =3D BuildGuidHob ( > - &gMpInformationHobGuid2, > + &gMpInformation2HobGuid, > sizeof (MP_INFORMATION2_HOB_DATA) + size= of (MP_INFORMATION2_ENTRY) * NumberOfProcessorsInHob > ); > ASSERT (MpInformation2HobData !=3D NULL); > @@ -744,7 +744,7 @@ InitializeCpuMpWorker ( > ASSERT_EFI_ERROR (Status); > =20 > // > - // Create gMpInformationHobGuid2 > + // Create gMpInformation2HobGuid > // > BuildMpInformationHob (); > =20 > diff --git a/UefiCpuPkg/CpuMpPei/CpuMpPei.inf b/UefiCpuPkg/CpuMpPei/CpuMp= Pei.inf > index 812fa179bd..9ab2623bd0 100644 > --- a/UefiCpuPkg/CpuMpPei/CpuMpPei.inf > +++ b/UefiCpuPkg/CpuMpPei/CpuMpPei.inf > @@ -50,7 +50,7 @@ > =20 > [Guids] > gEdkiiMigratedFvInfoGuid #= # SOMETIMES_CONSUMES ## HOB > - gMpInformationHobGuid2 ## PRODUCES > + gMpInformation2HobGuid ## PRODUCES > =20 > [Ppis] > gEfiPeiMpServicesPpiGuid ## PRODUCES > diff --git a/UefiCpuPkg/Include/Guid/MpInformation2.h b/UefiCpuPkg/Includ= e/Guid/MpInformation2.h > index 43185a4b01..2d9266f061 100644 > --- a/UefiCpuPkg/Include/Guid/MpInformation2.h > +++ b/UefiCpuPkg/Include/Guid/MpInformation2.h > @@ -53,6 +53,6 @@ typedef struct { > #define GET_MP_INFORMATION_ENTRY(MpInfoHobData, Index) \ > (MP_INFORMATION2_ENTRY *)((UINTN)&((MP_INFORMATION2_HOB_DATA *)(MpIn= foHobData))->Entry + (MpInfoHobData)->EntrySize * Index) > =20 > -extern EFI_GUID gMpInformationHobGuid2; > +extern EFI_GUID gMpInformation2HobGuid; > =20 > #endif > diff --git a/UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.c b/UefiCpuPkg/PiSm= mCpuDxeSmm/PiSmmCpuDxeSmm.c > index 9b230772cb..cd394826ff 100644 > --- a/UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.c > +++ b/UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.c > @@ -776,7 +776,7 @@ GetMpInformation ( > HobIndex =3D 0; > HobCount =3D 0; > =20 > - FirstMpInfo2Hob =3D GetFirstGuidHob (&gMpInformationHobGuid2); > + FirstMpInfo2Hob =3D GetFirstGuidHob (&gMpInformation2HobGuid); > ASSERT (FirstMpInfo2Hob !=3D NULL); > GuidHob =3D FirstMpInfo2Hob; > while (GuidHob !=3D NULL) { > @@ -792,7 +792,7 @@ GetMpInformation ( > =20 > HobCount++; > *NumberOfCpus +=3D MpInformation2HobData->NumberOfProcessors; > - GuidHob =3D GetNextGuidHob (&gMpInformationHobGuid2, GET_NEXT= _HOB (GuidHob)); > + GuidHob =3D GetNextGuidHob (&gMpInformation2HobGuid, GET_NEXT= _HOB (GuidHob)); > } > =20 > ASSERT (*NumberOfCpus <=3D PcdGet32 (PcdCpuMaxLogicalProcessorNumber))= ; > @@ -820,7 +820,7 @@ GetMpInformation ( > GuidHob =3D FirstMpInfo2Hob; > while (HobIndex < HobCount) { > MpInfo2Hobs[HobIndex++] =3D GET_GUID_HOB_DATA (GuidHob); > - GuidHob =3D GetNextGuidHob (&gMpInformationHobGuid2,= GET_NEXT_HOB (GuidHob)); > + GuidHob =3D GetNextGuidHob (&gMpInformation2HobGuid,= GET_NEXT_HOB (GuidHob)); > } > =20 > ProcessorInfo =3D (EFI_PROCESSOR_INFORMATION *)AllocatePool (sizeof (E= FI_PROCESSOR_INFORMATION) * (*MaxNumberOfCpus)); > diff --git a/UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.inf b/UefiCpuPkg/Pi= SmmCpuDxeSmm/PiSmmCpuDxeSmm.inf > index 793220aba3..a018954ed7 100644 > --- a/UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.inf > +++ b/UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.inf > @@ -120,7 +120,7 @@ > gEdkiiPiSmmMemoryAttributesTableGuid ## CONSUMES ## SystemTable > gEfiMemoryAttributesTableGuid ## CONSUMES ## SystemTable > gSmmBaseHobGuid ## CONSUMES > - gMpInformationHobGuid2 ## CONSUMES # Assume the HOB = must has been created > + gMpInformation2HobGuid ## CONSUMES # Assume the HOB = must has been created > =20 > [FeaturePcd] > gUefiCpuPkgTokenSpaceGuid.PcdCpuSmmDebug ## CO= NSUMES > diff --git a/UefiCpuPkg/UefiCpuPkg.dec b/UefiCpuPkg/UefiCpuPkg.dec > index cc785a3222..571b59b36f 100644 > --- a/UefiCpuPkg/UefiCpuPkg.dec > +++ b/UefiCpuPkg/UefiCpuPkg.dec > @@ -89,7 +89,7 @@ > gSmmBaseHobGuid =3D { 0xc2217ba7, 0x03bb, 0x4f63, {0xa6, 0x47, 0x= 7c, 0x25, 0xc5, 0xfc, 0x9d, 0x73 }} > =20 > ## Include/Guid/MpInformation2.h > - gMpInformationHobGuid2 =3D { 0x417a7f64, 0xf4e9, 0x4b32, {0x84= , 0x6a, 0x5c, 0xc4, 0xd8, 0x62, 0x18, 0x79 }} > + gMpInformation2HobGuid =3D { 0x417a7f64, 0xf4e9, 0x4b32, {0x84= , 0x6a, 0x5c, 0xc4, 0xd8, 0x62, 0x18, 0x79 }} > =20 > [Protocols] > ## Include/Protocol/SmmCpuService.h Reviewed-by: Laszlo Ersek -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#113612): https://edk2.groups.io/g/devel/message/113612 Mute This Topic: https://groups.io/mt/103658826/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/19134562= 12/xyzzy [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-