From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id DC5F8AC026F for ; Sat, 3 Feb 2024 00:59:09 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=UzGd70yHFwAH5CCFGKaMnVQkN0+bmpi/6dAz/cNAqg8=; c=relaxed/simple; d=groups.io; h=DKIM-Filter:Message-ID:Date:MIME-Version:User-Agent:Subject:From:To:Cc:Reply-To:References:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1706921948; v=1; b=eON6mFodj3YcDOMXOUl2Dx9RDh3/SWj4SJo6tq4k3FG0VyXffrVtXbd+5ukVCgjAmKs1/zpQ sqVCcvHqg+/OP/T2L7oKTjugz0Zlyi/Wo4cMnud81OmrP1q10wu32RC/AHr1ypmrf3v/sKNmjbW 6izFSrAPhqloS30LoeAfj6Yo= X-Received: by 127.0.0.2 with SMTP id xKH7YY7687511xjamUgxJrwB; Fri, 02 Feb 2024 16:59:08 -0800 X-Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mx.groups.io with SMTP id smtpd.web10.9043.1706921947887850056 for ; Fri, 02 Feb 2024 16:59:07 -0800 X-Received: from [10.137.194.171] (unknown [131.107.160.171]) by linux.microsoft.com (Postfix) with ESMTPSA id 59BF120B2000; Fri, 2 Feb 2024 16:59:07 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 59BF120B2000 Message-ID: <1d8fd126-2bb1-4dc4-bd2a-d2552eebe068@linux.microsoft.com> Date: Fri, 2 Feb 2024 16:59:07 -0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [edk2-devel] AArch64 with HeapGuard: page allocations wrongly aligned From: "Oliver Smith-Denny" To: devel@edk2.groups.io, rebecca@os.amperecomputing.com Cc: Leif Lindholm , Ard Biesheuvel , Jian J Wang , Liming Gao , Dandan Bi Reply-To: devel@edk2.groups.io,osde@linux.microsoft.com References: <05f6388b-155e-427d-8e34-0ac571e97fb8@os.amperecomputing.com> <24affef7-eb96-4a82-b9d4-b616eb90024d@os.amperecomputing.com> <17AB84FD31479E00.28523@groups.io> <0a589fed-02f1-4598-bbbc-98bad0e8b04f@linux.microsoft.com> <14dac152-dfea-4ad3-bd52-300990bd1be8@os.amperecomputing.com> <09a8622e-be60-46e2-8e96-447dacb8c12f@linux.microsoft.com> <9696df58-283c-447d-b801-c3bb57b3787d@os.amperecomputing.com> <17ACD713D9397BBF.18300@groups.io> In-Reply-To: <17ACD713D9397BBF.18300@groups.io> Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: mca70PNjM79SUoUjTpdFrmVkx7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=eON6mFod; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=linux.microsoft.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On 1/22/2024 5:53 PM, Oliver Smith-Denny wrote:> I was able to repro=20 your bug (by just turning on page guards on > ArmVirtQemu, allocating runtime mem and freeing it). I think you > are the first person to free runtime mem on ARM64 with page guards > enabled (and to care when it failed :). >=20 > The heap guard code is not written with ARM64 in mind (nor is much of > the codebase, of course). Specifically in this case the heap guard code > only wishes to preserve 4 KB alignment, it knows nothing of ARM64's > runtime page granularity required. >=20 > Let me take a look at this, I'm working on a solution here, but I want > to test this out further. I'll try to send a patch later this week or > next. Ok, got sidetracked, but got back to this. Rebecca, can you create a bugzilla for this and try this patch: https://github.com/tianocore/edk2/pull/5339. I want to get some feedback on it and your testing before I send out a patch for it. However, it did fix my repro case where I was failing to free runtime memory with page guard enabled, so I believe it should fix your case. I need to fix some minor things like patch check, etc. I also did my testing on a slightly old version of master, so may need a minor touch up. Thanks, Oliver -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#115073): https://edk2.groups.io/g/devel/message/115073 Mute This Topic: https://groups.io/mt/103810212/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-