From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: None (no SPF record) identity=mailfrom; client-ip=192.55.52.93; helo=mga11.intel.com; envelope-from=ryszard.knop@linux.intel.com; receiver=edk2-devel@lists.01.org Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 1B41B211BD612 for ; Wed, 30 Jan 2019 07:41:48 -0800 (PST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 30 Jan 2019 07:41:47 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,540,1539673200"; d="scan'208";a="295696959" Received: from linux.intel.com ([10.54.29.200]) by orsmga005.jf.intel.com with ESMTP; 30 Jan 2019 07:41:47 -0800 Received: from torii (torii.igk.intel.com [10.102.24.20]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by linux.intel.com (Postfix) with ESMTPS id 64144580550; Wed, 30 Jan 2019 07:41:45 -0800 (PST) Message-ID: <1df82010f739fc37fe92d6af56e8ae693046477b.camel@linux.intel.com> From: Ryszard Knop To: Ard Biesheuvel , edk2-devel@lists.01.org Cc: kamil.kacperski@intel.com, eric.jin@intel.com, pawel.orlowski@intel.com, michael.d.kinney@intel.com, harry.l.hsiung@intel.com Date: Wed, 30 Jan 2019 16:41:43 +0100 In-Reply-To: <20181115023353.20159-2-ard.biesheuvel@linaro.org> References: <20181115023353.20159-1-ard.biesheuvel@linaro.org> <20181115023353.20159-2-ard.biesheuvel@linaro.org> Organization: Intel Corporation User-Agent: Evolution 3.30.4 Mime-Version: 1.0 Subject: Re: [PATCH edk2-staging 01/20] IntelUndiPkg/XGigUndiDxe: create GCC alternatives for MSFT build options X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 30 Jan 2019 15:41:48 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:41:48 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:41:48 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:41:48 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:41:48 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:41:48 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:41:48 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:41:48 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:41:48 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:41:48 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:41:48 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:41:48 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:41:48 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:41:48 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:41:48 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:41:48 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:41:48 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:41:48 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:41:48 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:41:48 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:41:48 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:41:48 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:41:48 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:41:48 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:41:48 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:41:48 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:41:48 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:41:48 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:41:48 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:41:48 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:41:48 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:41:48 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:41:48 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:41:48 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:41:48 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:41:48 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:41:48 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:41:48 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:41:48 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:41:48 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:41:48 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:41:48 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:41:48 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:41:48 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:41:48 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:41:48 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:41:48 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:41:48 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:41:48 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:41:48 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:41:48 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:41:48 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:41:48 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:41:48 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:41:48 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:41:48 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:41:48 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:41:48 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:41:48 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:41:48 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:41:48 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:41:48 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:41:48 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:41:48 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:41:48 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:41:48 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:41:48 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:41:48 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:41:48 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:41:48 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:41:48 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:41:48 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:41:48 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:41:48 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:41:48 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:41:48 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:41:48 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:41:48 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:41:48 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:41:48 -0000 X-List-Received-Date: Wed, 30 Jan 2019 15:41:48 -0000 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Reviewed-by: Ryszard Knop On Wed, 2018-11-14 at 18:33 -0800, ard.biesheuvela wrote: > Prefix the existing MSFT-only build option overrides with MSFT: and > create the GCC: counterparts so we can build this code with GCC as > well. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ard Biesheuvel > --- > IntelUndiPkg/XGigUndiDxe/XGigUndiDxe.inf | 13 +++++++++---- > 1 file changed, 9 insertions(+), 4 deletions(-) > > diff --git a/IntelUndiPkg/XGigUndiDxe/XGigUndiDxe.inf > b/IntelUndiPkg/XGigUndiDxe/XGigUndiDxe.inf > index 9e0e4aff0885..ab9c64dac7e8 100644 > --- a/IntelUndiPkg/XGigUndiDxe/XGigUndiDxe.inf > +++ b/IntelUndiPkg/XGigUndiDxe/XGigUndiDxe.inf > @@ -44,19 +44,24 @@ UNLOAD_IMAGE = UnloadXGigUndiDriver > > [BuildOptions.common] > > -*_*_*_CC_FLAGS = /FAcs /D MDEPKG_NDEBUG /D UNDI_10G > +MSFT:*_*_*_CC_FLAGS = /FAcs /D MDEPKG_NDEBUG /D UNDI_10G > +GCC:*_*_*_CC_FLAGS = -DUNDI_10G > +GCC:RELEASE_*_*_CC_FLAGS = -DMDEPKG_NDEBUG > > [BuildOptions.X64] > > -*_*_*_CC_FLAGS = /D EFIX64 > +MSFT:*_*_*_CC_FLAGS = /D EFIX64 > +GCC:*_*_*_CC_FLAGS = -DEFIX64 > > [BuildOptions.IPF] > > -*_*_*_CC_FLAGS = /D EFI64 > +MSFT:*_*_*_CC_FLAGS = /D EFI64 > +GCC:*_*_*_CC_FLAGS = -DEFI64 > > [BuildOptions.IA32] > > -*_*_*_CC_FLAGS = /D EFI32 > +MSFT:*_*_*_CC_FLAGS = /D EFI32 > +GCC:*_*_*_CC_FLAGS = -DEFI32 > > [sources.common] > InventoryStrings.uni