Re: [edk2-devel] [PATCH V4 0/2] MdeModulePkg: Make the screen seamless

["Laszlo Ersek" <lersek@redhat.com>]

On 06/13/19 08:58, Wu, Hao A wrote:
>> -----Original Message-----
>> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
>> Wu, Hao A
>> Sent: Monday, May 27, 2019 10:15 AM
>> To: Gao, Zhichao; devel@edk2.groups.io
>> Cc: Wang, Jian J; Ni, Ray; Zeng, Star; Gao, Liming; Sean Brogan; Michael
>> Turner; Bret Barkelew; Laszlo Ersek
>> Subject: Re: [edk2-devel] [PATCH V4 0/2] MdeModulePkg: Make the screen
>> seamless
>>
>> For my understanding, the series looks like a feature rather than bug to me.
>> I suggest to hold this one until the stable tag is created.
> 
> 
> Pushed via commits e85cfa2fa4..0a35997643.

Thanks for handling this!
Laszlo

> 
> Best Regards,
> Hao Wu
> 
> 
>>
>> Best Regards,
>> Hao Wu
>>
>>
>>> -----Original Message-----
>>> From: Gao, Zhichao
>>> Sent: Friday, May 24, 2019 10:40 AM
>>> To: devel@edk2.groups.io
>>> Cc: Wang, Jian J; Wu, Hao A; Ni, Ray; Zeng, Star; Gao, Liming; Sean Brogan;
>>> Michael Turner; Bret Barkelew; Laszlo Ersek
>>> Subject: [PATCH V4 0/2] MdeModulePkg: Make the screen seamless
>>>
>>> For now most platforms support display function at PEI phase.
>>> But the conspliter and graphics console driver would clear the
>>> screen at BDS connect console phase. Maybe some platforms would
>>> show logo in the next or maybe not. For consumers, it looks like
>>> the screen flashed.
>>> So change the behavior of graphics console devices while connect
>>> console devices to maintain seamless screen from PEI.
>>>
>>> Test has done on MinPlatform Kabylake-RVP3 which support PEI
>>> display.
>>>
>>> V2:
>>> Make the SetMode not clear the screen only at the first boot during
>>> the first conncettion of graphics device.
>>>
>>> V3:
>>> Abandon V2. Directly set the output mode without clear the screen
>>> while initialize the graphics console device. Add clear screen operation
>>> in stop function of graphics console device.
>>>
>>> V4:
>>> Fix incorrect mode check in V3.
>>> Initialize the mode to an invalid mode. If no perfer mode is found, it
>>> is better to initialize its text mode to an invalid one.
>>> Remove the ClearScreen fuction in the BindingStop function in V3.
>>> The graphics output driver may disconnect before graphics console, that
>>> may cause a system exception because of using released resource.
>>> Impact: the screen would not be cleared after reconnect the graphics
>> device
>>> thru software, such as 'reconnect -r' in shell.
>>>
>>> Cc: Jian J Wang <jian.j.wang@intel.com>
>>> Cc: Hao Wu <hao.a.wu@intel.com>
>>> Cc: Ray Ni <ray.ni@intel.com>
>>> Cc: Star Zeng <star.zeng@intel.com>
>>> Cc: Liming Gao <liming.gao@intel.com>
>>> Cc: Sean Brogan <sean.brogan@microsoft.com>
>>> Cc: Michael Turner <Michael.Turner@microsoft.com>
>>> Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
>>> Cc: Laszlo Ersek <lersek@redhat.com>
>>>
>>> Aaron Antone (1):
>>>   MdeModulePkg/ConSplitterDxe: Optimize the
>>> ConSplitterTextOutSetMode
>>>
>>> Zhichao Gao (1):
>>>   MdeModulePkg/GraphicsConsoleDxe: Initialize the output mode
>>>
>>>  .../Console/ConSplitterDxe/ConSplitter.c      | 33 ++++++++++-----
>>>  .../Console/ConSplitterDxe/ConSplitter.h      |  4 +-
>>>  .../GraphicsConsoleDxe/GraphicsConsole.c      | 42 ++++++++++++++-----
>>>  .../GraphicsConsoleDxe/GraphicsConsoleDxe.inf |  2 +
>>>  4 files changed, 59 insertions(+), 22 deletions(-)
>>>
>>> --
>>> 2.21.0.windows.1
>>
>>
>> 
>