From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: redhat.com, ip: 209.132.183.28, mailfrom: lersek@redhat.com) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by groups.io with SMTP; Thu, 13 Jun 2019 03:01:05 -0700 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id E80A23003E4F; Thu, 13 Jun 2019 10:00:54 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-116-219.ams2.redhat.com [10.36.116.219]) by smtp.corp.redhat.com (Postfix) with ESMTP id 089FD54195; Thu, 13 Jun 2019 10:00:48 +0000 (UTC) Subject: Re: [edk2-devel] [PATCH V4 0/2] MdeModulePkg: Make the screen seamless To: "Wu, Hao A" , "devel@edk2.groups.io" , "Gao, Zhichao" Cc: "Wang, Jian J" , "Ni, Ray" , "Zeng, Star" , "Gao, Liming" , Sean Brogan , Michael Turner , Bret Barkelew References: <20190524024009.31600-1-zhichao.gao@intel.com> From: "Laszlo Ersek" Message-ID: <1e23cd36-e4a3-3fbc-5912-835f3ccafe15@redhat.com> Date: Thu, 13 Jun 2019 12:00:47 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.42]); Thu, 13 Jun 2019 10:01:00 +0000 (UTC) Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 06/13/19 08:58, Wu, Hao A wrote: >> -----Original Message----- >> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of >> Wu, Hao A >> Sent: Monday, May 27, 2019 10:15 AM >> To: Gao, Zhichao; devel@edk2.groups.io >> Cc: Wang, Jian J; Ni, Ray; Zeng, Star; Gao, Liming; Sean Brogan; Michael >> Turner; Bret Barkelew; Laszlo Ersek >> Subject: Re: [edk2-devel] [PATCH V4 0/2] MdeModulePkg: Make the screen >> seamless >> >> For my understanding, the series looks like a feature rather than bug to me. >> I suggest to hold this one until the stable tag is created. > > > Pushed via commits e85cfa2fa4..0a35997643. Thanks for handling this! Laszlo > > Best Regards, > Hao Wu > > >> >> Best Regards, >> Hao Wu >> >> >>> -----Original Message----- >>> From: Gao, Zhichao >>> Sent: Friday, May 24, 2019 10:40 AM >>> To: devel@edk2.groups.io >>> Cc: Wang, Jian J; Wu, Hao A; Ni, Ray; Zeng, Star; Gao, Liming; Sean Brogan; >>> Michael Turner; Bret Barkelew; Laszlo Ersek >>> Subject: [PATCH V4 0/2] MdeModulePkg: Make the screen seamless >>> >>> For now most platforms support display function at PEI phase. >>> But the conspliter and graphics console driver would clear the >>> screen at BDS connect console phase. Maybe some platforms would >>> show logo in the next or maybe not. For consumers, it looks like >>> the screen flashed. >>> So change the behavior of graphics console devices while connect >>> console devices to maintain seamless screen from PEI. >>> >>> Test has done on MinPlatform Kabylake-RVP3 which support PEI >>> display. >>> >>> V2: >>> Make the SetMode not clear the screen only at the first boot during >>> the first conncettion of graphics device. >>> >>> V3: >>> Abandon V2. Directly set the output mode without clear the screen >>> while initialize the graphics console device. Add clear screen operation >>> in stop function of graphics console device. >>> >>> V4: >>> Fix incorrect mode check in V3. >>> Initialize the mode to an invalid mode. If no perfer mode is found, it >>> is better to initialize its text mode to an invalid one. >>> Remove the ClearScreen fuction in the BindingStop function in V3. >>> The graphics output driver may disconnect before graphics console, that >>> may cause a system exception because of using released resource. >>> Impact: the screen would not be cleared after reconnect the graphics >> device >>> thru software, such as 'reconnect -r' in shell. >>> >>> Cc: Jian J Wang >>> Cc: Hao Wu >>> Cc: Ray Ni >>> Cc: Star Zeng >>> Cc: Liming Gao >>> Cc: Sean Brogan >>> Cc: Michael Turner >>> Cc: Bret Barkelew >>> Cc: Laszlo Ersek >>> >>> Aaron Antone (1): >>> MdeModulePkg/ConSplitterDxe: Optimize the >>> ConSplitterTextOutSetMode >>> >>> Zhichao Gao (1): >>> MdeModulePkg/GraphicsConsoleDxe: Initialize the output mode >>> >>> .../Console/ConSplitterDxe/ConSplitter.c | 33 ++++++++++----- >>> .../Console/ConSplitterDxe/ConSplitter.h | 4 +- >>> .../GraphicsConsoleDxe/GraphicsConsole.c | 42 ++++++++++++++----- >>> .../GraphicsConsoleDxe/GraphicsConsoleDxe.inf | 2 + >>> 4 files changed, 59 insertions(+), 22 deletions(-) >>> >>> -- >>> 2.21.0.windows.1 >> >> >> >