From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124])
 by mx.groups.io with SMTP id smtpd.web12.6018.1624533191428912374
 for <devel@edk2.groups.io>;
 Thu, 24 Jun 2021 04:13:11 -0700
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=KOvsz3wj;
 spf=pass (domain: redhat.com, ip: 216.205.24.124, mailfrom: lersek@redhat.com)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1624533190;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=QmaQqtziLuoOsXYL/2+nlMOgMMHf7B+an2NEvinXxsU=;
	b=KOvsz3wj1wPdDY2ouUGOIQqOyk2uk19NZoIqPuGEqymjoMk3sqV5kWk0GZkncCvZD1BCLV
	C87cNO58n6yoX+nxT9dYhE2RXCE78qbu5D+5bp7334zDh39Q+teTO8FiFVbZrMnTO+qgRN
	xF93+WhGHBC2wRDiaM9facL33aGuNeM=
Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com
 [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id
 us-mta-255-FOm7P2PxO4KOmb2ArOGXEQ-1; Thu, 24 Jun 2021 07:13:07 -0400
X-MC-Unique: FOm7P2PxO4KOmb2ArOGXEQ-1
Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 9DEC0A40C3;
	Thu, 24 Jun 2021 11:13:05 +0000 (UTC)
Received: from lacos-laptop-7.usersys.redhat.com (ovpn-114-106.ams2.redhat.com [10.36.114.106])
	by smtp.corp.redhat.com (Postfix) with ESMTPS id EA82A84621;
	Thu, 24 Jun 2021 11:13:03 +0000 (UTC)
Subject: Re: [edk2-devel] [PATCH v1 2/5] ArmVirtPkg: Add DSDT ACPI table for Kvmtool firmware
To: devel@edk2.groups.io, pierre.gondois@arm.com,
 Sami Mujawar <sami.mujawar@arm.com>
Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>,
 Leif Lindholm <leif@nuviainc.com>, Akanksha Jain <akanksha.jain2@arm.com>,
 Alexandru Elisei <alexandru.elisei@arm.com>
References: <20210623140640.16754-1-Pierre.Gondois@arm.com>
 <20210623140640.16754-3-Pierre.Gondois@arm.com>
From: "Laszlo Ersek" <lersek@redhat.com>
Message-ID: <1e3fd675-7bd0-7a37-f65d-c58463d086cd@redhat.com>
Date: Thu, 24 Jun 2021 13:13:02 +0200
MIME-Version: 1.0
In-Reply-To: <20210623140640.16754-3-Pierre.Gondois@arm.com>
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13
Authentication-Results: relay.mimecast.com;
	auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=lersek@redhat.com
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit

On 06/23/21 16:06, PierreGondois wrote:
> From: Sami Mujawar <sami.mujawar@arm.com>
> 
> Most ACPI tables for Kvmtool firmware are dynamically
> generated. The AML code is also generated at runtime
> for most components in appropriate SSDTs.
> 
> Although there may not be much to describe in the DSDT,
> the DSDT table is mandatory.
> 
> Therefore, add an empty stub for DSDT.
> 
> Signed-off-by: Sami Mujawar <sami.mujawar@arm.com>
> Signed-off-by: Pierre Gondois <Pierre.Gondois@arm.com>
> ---
>  .../KvmtoolCfgMgrDxe/AslTables/Dsdt.asl       | 19 +++++++++++++++++++
>  1 file changed, 19 insertions(+)
>  create mode 100644 ArmVirtPkg/KvmtoolCfgMgrDxe/AslTables/Dsdt.asl
> 
> diff --git a/ArmVirtPkg/KvmtoolCfgMgrDxe/AslTables/Dsdt.asl b/ArmVirtPkg/KvmtoolCfgMgrDxe/AslTables/Dsdt.asl
> new file mode 100644
> index 000000000000..8467d1ede4ec
> --- /dev/null
> +++ b/ArmVirtPkg/KvmtoolCfgMgrDxe/AslTables/Dsdt.asl
> @@ -0,0 +1,19 @@
> +/** @file
> +  Differentiated System Description Table Fields (DSDT)
> +
> +  Copyright (c) 2021, ARM Ltd. All rights reserved.<BR>
> +    SPDX-License-Identifier: BSD-2-Clause-Patent
> +
> +**/
> +
> +DefinitionBlock ("DsdtTable.aml", "DSDT", 1, "ARMLTD", "ARM-KVMT", 1) {
> +  Scope (_SB) {
> +    // Most ACPI tables for Kvmtool firmware are
> +    // dynamically generated. The AML code is also
> +    // generated at runtime for most components in
> +    // appropriate SSDTs.
> +    // Although there may not be much to describe
> +    // in the DSDT, the DSDT table is mandatory.
> +    // Therefore, add an empty stub for DSDT.
> +  } // Scope (_SB)
> +}
> 

Please insert empty // lines at the top and bottom of the comment block,
to stick more closely with the edk2 coding style.

Reviewed-by: Laszlo Ersek <lersek@redhat.com>