Re: [PATCH v4 0/8] OvmfPkg/VirtioNetDxe: map host address to device address

[Laszlo Ersek <lersek@redhat.com>]

On 09/15/17 02:10, Laszlo Ersek wrote:
> On 09/14/17 23:22, Brijesh Singh wrote:
>> Repo: https://github.com/codomania/edk2
>> Branch: virtionet-4
>>
>> Changes since v3:
>>  * changes to address v3 feedback
>>
>> Brijesh Singh (8):
>>   OvmfPkg/VirtioNetDxe: add helper VirtioNetUninitRing()
>>   OvmfPkg/VirtioNetDxe: map VRINGs using VirtioRingMap()
>>   OvmfPkg/VirtioNetDxe: alloc RxBuf using AllocateSharedPages()
>>   OvmfPkg/VirtioNetDxe: dynamically alloc transmit header
>>   OvmfPkg/VirtioNetDxe: update TechNotes
>>   OvmfPkg/VirtioNetDxe: add Tx packet map/unmap helper functions
>>   OvmfPkg/VirtioNetDxe: map caller-supplied Tx packet to device-address
>>   OvmfPkg/VirtioNetDxe: negotiate VIRTIO_F_IOMMU_PLATFORM
>>
>>  OvmfPkg/VirtioNetDxe/VirtioNet.inf      |   1 +
>>  OvmfPkg/VirtioNetDxe/VirtioNet.h        |  57 ++++-
>>  OvmfPkg/VirtioNetDxe/SnpGetStatus.c     |  43 +++-
>>  OvmfPkg/VirtioNetDxe/SnpInitialize.c    | 213 +++++++++++++---
>>  OvmfPkg/VirtioNetDxe/SnpReceive.c       |   5 +-
>>  OvmfPkg/VirtioNetDxe/SnpSharedHelpers.c | 258 +++++++++++++++++++-
>>  OvmfPkg/VirtioNetDxe/SnpShutdown.c      |   4 +-
>>  OvmfPkg/VirtioNetDxe/SnpTransmit.c      |  27 +-
>>  OvmfPkg/VirtioNetDxe/TechNotes.txt      |  28 ++-
>>  9 files changed, 566 insertions(+), 70 deletions(-)
>>
> 
> I've done the following tests:
> 
>   arch     virtio transport  SEV  driver model test [1]  PXE boot test [2]
>   -------  ----------------  ---  ---------------------  -----------------
>   IA32     legacy PCI        -    PASS                   PASS [3]
>   IA32     modern PCI        -    PASS                   PASS [3]
>   X64      legacy PCI        -    PASS                   PASS
>   X64      modern PCI        no   PASS                   PASS
>   AARCH64  virtio-mmio       -    PASS                   PASS
>   X64      modern PCI        yes  PASS [4]               PASS
> 
> [1] driver model test:
>     - ifconfig/dhcp, ping
>     - shell disconnect / connect
>     - ifconfig/dhcp, ping
> 
> [2] PXE boot test:
>     - OVMF -> shim -> grub -> kernel

I shouldn't forget the initrd's here either; those were also loaded, of
course.

Thanks
Laszlo

>     - see kernel messages
> 
> [3] I didn't have a 32-bit shim.efi, so I only verified the first (i.e.,
>     OVMF -> shim) download
> 
> [4] I repeated this test separately with verbose debug messages enabled.
>     It was amazing to watch the log while running several pings after
>     each other. After pinging, I booted the OS and verified from the log
>     that all areas were re-encrypted.
> 
> Regression-tested-by: Laszlo Ersek <lersek@redhat.com>
> Tested-by: Laszlo Ersek <lersek@redhat.com>
> 
> Series pushed as commit range b30abe7df464..f60ed5ab7fb3.
> 
> Thank you!
> Laszlo
>