From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id EC1F820945BE0 for ; Thu, 14 Sep 2017 17:11:28 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 1BF8DC047B91; Fri, 15 Sep 2017 00:14:28 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 1BF8DC047B91 Authentication-Results: ext-mx07.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx07.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=lersek@redhat.com Received: from lacos-laptop-7.usersys.redhat.com (ovpn-121-80.rdu2.redhat.com [10.10.121.80]) by smtp.corp.redhat.com (Postfix) with ESMTP id 510355D963; Fri, 15 Sep 2017 00:14:27 +0000 (UTC) From: Laszlo Ersek To: Brijesh Singh Cc: edk2-devel@lists.01.org References: <20170914212247.124937-1-brijesh.singh@amd.com> <581a568d-b0ce-34a1-8e52-95adf14c03e0@redhat.com> Message-ID: <1e4267dc-0133-e833-f805-8381ef82c52e@redhat.com> Date: Fri, 15 Sep 2017 02:14:26 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <581a568d-b0ce-34a1-8e52-95adf14c03e0@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.31]); Fri, 15 Sep 2017 00:14:28 +0000 (UTC) Subject: Re: [PATCH v4 0/8] OvmfPkg/VirtioNetDxe: map host address to device address X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 15 Sep 2017 00:11:29 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 09/15/17 02:10, Laszlo Ersek wrote: > On 09/14/17 23:22, Brijesh Singh wrote: >> Repo: https://github.com/codomania/edk2 >> Branch: virtionet-4 >> >> Changes since v3: >> * changes to address v3 feedback >> >> Brijesh Singh (8): >> OvmfPkg/VirtioNetDxe: add helper VirtioNetUninitRing() >> OvmfPkg/VirtioNetDxe: map VRINGs using VirtioRingMap() >> OvmfPkg/VirtioNetDxe: alloc RxBuf using AllocateSharedPages() >> OvmfPkg/VirtioNetDxe: dynamically alloc transmit header >> OvmfPkg/VirtioNetDxe: update TechNotes >> OvmfPkg/VirtioNetDxe: add Tx packet map/unmap helper functions >> OvmfPkg/VirtioNetDxe: map caller-supplied Tx packet to device-address >> OvmfPkg/VirtioNetDxe: negotiate VIRTIO_F_IOMMU_PLATFORM >> >> OvmfPkg/VirtioNetDxe/VirtioNet.inf | 1 + >> OvmfPkg/VirtioNetDxe/VirtioNet.h | 57 ++++- >> OvmfPkg/VirtioNetDxe/SnpGetStatus.c | 43 +++- >> OvmfPkg/VirtioNetDxe/SnpInitialize.c | 213 +++++++++++++--- >> OvmfPkg/VirtioNetDxe/SnpReceive.c | 5 +- >> OvmfPkg/VirtioNetDxe/SnpSharedHelpers.c | 258 +++++++++++++++++++- >> OvmfPkg/VirtioNetDxe/SnpShutdown.c | 4 +- >> OvmfPkg/VirtioNetDxe/SnpTransmit.c | 27 +- >> OvmfPkg/VirtioNetDxe/TechNotes.txt | 28 ++- >> 9 files changed, 566 insertions(+), 70 deletions(-) >> > > I've done the following tests: > > arch virtio transport SEV driver model test [1] PXE boot test [2] > ------- ---------------- --- --------------------- ----------------- > IA32 legacy PCI - PASS PASS [3] > IA32 modern PCI - PASS PASS [3] > X64 legacy PCI - PASS PASS > X64 modern PCI no PASS PASS > AARCH64 virtio-mmio - PASS PASS > X64 modern PCI yes PASS [4] PASS > > [1] driver model test: > - ifconfig/dhcp, ping > - shell disconnect / connect > - ifconfig/dhcp, ping > > [2] PXE boot test: > - OVMF -> shim -> grub -> kernel I shouldn't forget the initrd's here either; those were also loaded, of course. Thanks Laszlo > - see kernel messages > > [3] I didn't have a 32-bit shim.efi, so I only verified the first (i.e., > OVMF -> shim) download > > [4] I repeated this test separately with verbose debug messages enabled. > It was amazing to watch the log while running several pings after > each other. After pinging, I booted the OS and verified from the log > that all areas were re-encrypted. > > Regression-tested-by: Laszlo Ersek > Tested-by: Laszlo Ersek > > Series pushed as commit range b30abe7df464..f60ed5ab7fb3. > > Thank you! > Laszlo >