public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Marvin Häuser" <mhaeuser@posteo.de>
To: devel@edk2.groups.io, fanjianfeng@byosoft.com.cn
Cc: Hao A Wu <hao.a.wu@intel.com>
Subject: Re: [edk2-devel] SLDP: Usage of PE library context by debugger?
Date: Mon, 02 Aug 2021 05:47:58 +0000	[thread overview]
Message-ID: <1e44ed09-016e-40bc-b03d-da6f231e687e@localhost> (raw)
In-Reply-To: <2021080211280782338912@byosoft.com.cn>

02.08.2021 06:51:39 Jeff Fan <fanjianfeng@byosoft.com.cn>:

> Marvin,
> 
> ImageBase was saved in DR2 to help HOST debugger to locate the image 
> base more easily, even though the HOST debugger could find the image 
> base through searching the DOS image signagure.
> 
> The reason choosing DR1 and DR2 to save PDB & ImageBase contexts is 
> just implementation only. And it could co-work with Debug Agent Lib 
> implementation and SIMCS.  I am not sure whether is could co-work with 
> INTEl System Debugging tools or not.

Good day Jeff,

Thanks for your response!

I've read that Intel System Debugger superseded the UDK debugging tool, 
maybe that was incorrect though. I use GDB. :)

> I don't understand why the new PeCoffLib implementation would break the 
> existing debugging tools?Could you explain it more details?

Please refer to the mail from Ray and my response. It is not the Image 
base address that is saved in DR2, but the PeCoffLib context address, 
and my new library simply has a new context structure for various 
reasons.

Best regards,
Marvin

> 
> ----------------------------------------
> 
> Jeff
> fanjianfeng@byosoft.com.cn
> 
>  
> *From:* Marvin Häuser[mhaeuser@posteo.de]
> *Date:* 2021-08-01 01:21
> *To:* devel@edk2.groups.io
> *CC:* Hao A Wu[hao.a.wu@intel.com]
> *Subject:* [edk2-devel] SLDP: Usage of PE library context by debugger?
> Good day everyone,
>  
> While refining the port of SourceLevelDebugPkg to my newly proposed
> PeCoffLib rework (RFC upcoming), I noticed that the address of the PE
> Image context is written to DR2 [1]. Because the UDK and Intel System
> Studio debugging tools are closed source, I cannot verify what happens
> to this value. Does the host read the library context and retrieve data
> from it? If not, why is its address written to DR2? If so, this would
> mean the new PeCoffLib implementation breaks the existing debugging
> tools. The following questions would arise:
>  
> 1) Which data are retrieved from the context structure? For GDB, I 
> think
> only the Image address and symbol file path are required (to load the
> symbols), while PDB is saved in DR1 already.
> 2) Are there any plans to provide detailed documentation of the
> host/client communication protocol?
> 3) Are there any plans to provide an open source debugger, or at least
> the EDK II communication protocol portion?
>  
> Thank you for your time!
>  
> Best regards,
> Marvin
>  
>  
> [1]
> https://github.com/tianocore/edk2/blob/610bcc69ed3d1e8c016332a1862465d41d95dd6c/SourceLevelDebugPkg/Library/PeCoffExtraActionLibDebug/PeCoffExtraActionLib.c#L126
>  
>  
>  
>  
>  
> 


      reply	other threads:[~2021-08-02  5:48 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-31 17:21 SLDP: Usage of PE library context by debugger? Marvin Häuser
2021-08-02  3:09 ` [edk2-devel] " Ni, Ray
2021-08-02  5:36   ` Marvin Häuser
2021-08-02  4:51 ` Jeff Fan
2021-08-02  5:47   ` Marvin Häuser [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1e44ed09-016e-40bc-b03d-da6f231e687e@localhost \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox