From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124])
 by mx.groups.io with SMTP id smtpd.web08.6568.1604420810281438508
 for <devel@edk2.groups.io>;
 Tue, 03 Nov 2020 08:26:50 -0800
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=U0DAIRg2;
 spf=pass (domain: redhat.com, ip: 63.128.21.124, mailfrom: lersek@redhat.com)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1604420809;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=DoaqcMPPsx4UknvfuLfaOldheYiX/6LwHbYFscVJwZo=;
	b=U0DAIRg2cR0gIFuIFAUKf7OSqW4bBU/48P/GccoG+Mpu7Mvf8J4Can66dfwooNyLDJjfJj
	21jRmz8CoHFy6fwTd3qAqGrffTSR7gugu24cm1EBl+LOMUtdmhZY5Q7bMU4WzLctm2yscI
	8MebraIzUUIIbFpTO+CsvzggozbsODg=
Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com
 [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id
 us-mta-594-veoxFgpfN2GghIRluaGJpw-1; Tue, 03 Nov 2020 11:26:47 -0500
X-MC-Unique: veoxFgpfN2GghIRluaGJpw-1
Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 61B94803654;
	Tue,  3 Nov 2020 16:26:46 +0000 (UTC)
Received: from lacos-laptop-7.usersys.redhat.com (ovpn-112-129.ams2.redhat.com [10.36.112.129])
	by smtp.corp.redhat.com (Postfix) with ESMTP id 413785D9DD;
	Tue,  3 Nov 2020 16:26:45 +0000 (UTC)
Subject: Re: [edk2-devel] [PATCH v3 03/11] OvmfPkg/VmgExitLib: Implement new VmgExitLib interfaces
To: devel@edk2.groups.io, thomas.lendacky@amd.com
Cc: Brijesh Singh <brijesh.singh@amd.com>,
 Jordan Justen <jordan.l.justen@intel.com>,
 Ard Biesheuvel <ard.biesheuvel@arm.com>
References: <cover.1603981082.git.thomas.lendacky@amd.com>
 <0e7695dce56e749e80d5df1e484cc4ac8011717c.1603981082.git.thomas.lendacky@amd.com>
From: "Laszlo Ersek" <lersek@redhat.com>
Message-ID: <1e45a7d1-33fe-c49e-58da-02adb0407265@redhat.com>
Date: Tue, 3 Nov 2020 17:26:44 +0100
MIME-Version: 1.0
In-Reply-To: <0e7695dce56e749e80d5df1e484cc4ac8011717c.1603981082.git.thomas.lendacky@amd.com>
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14
Authentication-Results: relay.mimecast.com;
	auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=lersek@redhat.com
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit

On 10/29/20 15:17, Lendacky, Thomas wrote:
> From: Tom Lendacky <thomas.lendacky@amd.com>
> 
> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3008
> 
> The VmgExitLib library added two new interfaces, VmgSetOffsetValid() and
> VmgIsOffsetValid(), that must now be implemented in the OvmfPkg version
> of the library.
> 
> Implement VmgSetOffsetValid() and VmgIsOffsetValid() and update existing
> code, that is directly accessing ValidBitmap, to use the new interfaces.
> 
> Cc: Jordan Justen <jordan.l.justen@intel.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>
> Cc: Tom Lendacky <thomas.lendacky@amd.com>
> Cc: Brijesh Singh <brijesh.singh@amd.com>
> Reviewed-by: Laszlo Ersek <lersek@redhat.com>
> Signed-off-by: Tom Lendacky <thomas.lendacky@amd.com>
> ---
>  OvmfPkg/Library/VmgExitLib/VmgExitLib.c       |  54 +++++++++
>  OvmfPkg/Library/VmgExitLib/VmgExitVcHandler.c | 118 +++++---------------
>  2 files changed, 85 insertions(+), 87 deletions(-)

Looks OK.