Re: [edk2-devel] [PATCH v7 0/1] ShellPkg/DynamicCommand: add HttpDynamicCommand

["Laszlo Ersek" <lersek@redhat.com>]

Hi Vladimir,

On 08/25/20 19:20, Vladimir Olovyannikov via groups.io wrote:
> Signed-off-by: Vladimir Olovyannikov <vladimir.olovyannikov@broadcom.com>
> Reviewed-by: Maciej Rabeda <maciej.rabeda@linux.intel.com>
> Cc: Zhichao Gao <zhichao.gao@intel.com>
> Cc: Maciej Rabeda <maciej.rabeda@linux.intel.com>
> Cc: Jiaxin Wu <jiaxin.wu@intel.com>
> Cc: Siyuan Fu <siyuan.fu@intel.com>
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> Cc: Nd <nd@arm.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Cc: Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>
> 
> This patchset introduces an http client utilizing EDK2 HTTP protocol, to
> allow fast image downloading from http/https servers.
> HTTP download speed is usually faster than tftp.
> The client is based on the same approach as tftp dynamic command, and
> uses the same UEFI Shell command line parameters. This makes it easy
> integrating http into existing UEFI Shell scripts.
> Note that to enable HTTP download, feature Pcd
> gEfiNetworkPkgTokenSpaceGuid.PcdAllowHttpConnections must be set to TRUE.
> 
> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2860
> 
> PATCH v7 changes:
> Address Laszlo' and Maciej's comments:
>   - Remove openssl submodule change accidentally added to the v6 patchset;
>   - Fix code style issues in the code overlooked in the previous patchset.

I'm currently working on some VCPU hotplug fixes for the upcoming
release. Before I return to your HttpDynamicCommand patch, I'll also
have to re-read my earlier comments for it. (In fact I can't tell
off-hand if I had remaining requests for your patch, or not -- hence the
need for re-reading my earlier comments.) It could take some time --
thanks for your patience.

Thanks,
Laszlo