From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.81]) by mx.groups.io with SMTP id smtpd.web11.12953.1598450162609636297 for ; Wed, 26 Aug 2020 06:56:02 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=FZbWBZdl; spf=pass (domain: redhat.com, ip: 207.211.31.81, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1598450161; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=a46uaqin338BLf35uxQ60Ir/Cz5h9p3FklT5DyOMkwI=; b=FZbWBZdlQ5+NWOeCM1/3hL0vKhDGqNeoNySm1b5Re57LRzXhlh5GCSak6YkO1s3af4ymRW njM1bcI5wfdPBouFWYFyxiVr02YzkVUPQ6V2NI9axql4pemfUTJj1Jylih/NmBdi8+44P0 yHg0dbpmX5q+zBYKxZDANLm3MUXG68k= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-191-U4szBr43OfuQqV5dGGy-pw-1; Wed, 26 Aug 2020 09:55:54 -0400 X-MC-Unique: U4szBr43OfuQqV5dGGy-pw-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id CDED810ABDBC; Wed, 26 Aug 2020 13:55:44 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-114-182.ams2.redhat.com [10.36.114.182]) by smtp.corp.redhat.com (Postfix) with ESMTP id A25F970488; Wed, 26 Aug 2020 13:55:42 +0000 (UTC) Subject: Re: [edk2-devel] [PATCH v7 0/1] ShellPkg/DynamicCommand: add HttpDynamicCommand To: devel@edk2.groups.io, vladimir.olovyannikov@broadcom.com Cc: Maciej Rabeda , Zhichao Gao , Jiaxin Wu , Siyuan Fu , Ray Ni , Liming Gao , Nd , Samer El-Haj-Mahmoud References: <20200825172049.30912-1-vladimir.olovyannikov@broadcom.com> From: "Laszlo Ersek" Message-ID: <1e618ae0-230b-effb-f9df-9957fcd0d19f@redhat.com> Date: Wed, 26 Aug 2020 15:55:41 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Firefox/52.0 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20200825172049.30912-1-vladimir.olovyannikov@broadcom.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=lersek@redhat.com X-Mimecast-Spam-Score: 0.002 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Hi Vladimir, On 08/25/20 19:20, Vladimir Olovyannikov via groups.io wrote: > Signed-off-by: Vladimir Olovyannikov > Reviewed-by: Maciej Rabeda > Cc: Zhichao Gao > Cc: Maciej Rabeda > Cc: Jiaxin Wu > Cc: Siyuan Fu > Cc: Ray Ni > Cc: Liming Gao > Cc: Nd > Cc: Laszlo Ersek > Cc: Samer El-Haj-Mahmoud > > This patchset introduces an http client utilizing EDK2 HTTP protocol, to > allow fast image downloading from http/https servers. > HTTP download speed is usually faster than tftp. > The client is based on the same approach as tftp dynamic command, and > uses the same UEFI Shell command line parameters. This makes it easy > integrating http into existing UEFI Shell scripts. > Note that to enable HTTP download, feature Pcd > gEfiNetworkPkgTokenSpaceGuid.PcdAllowHttpConnections must be set to TRUE. > > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2860 > > PATCH v7 changes: > Address Laszlo' and Maciej's comments: > - Remove openssl submodule change accidentally added to the v6 patchset; > - Fix code style issues in the code overlooked in the previous patchset. I'm currently working on some VCPU hotplug fixes for the upcoming release. Before I return to your HttpDynamicCommand patch, I'll also have to re-read my earlier comments for it. (In fact I can't tell off-hand if I had remaining requests for your patch, or not -- hence the need for re-reading my earlier comments.) It could take some time -- thanks for your patience. Thanks, Laszlo