From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (NAM12-DM6-obe.outbound.protection.outlook.com [40.107.243.134]) by mx.groups.io with SMTP id smtpd.web10.17058.1684742626273010994 for ; Mon, 22 May 2023 01:03:46 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="no key for verify" header.i=@amperemail.onmicrosoft.com header.s=selector1-amperemail-onmicrosoft-com header.b=ekz80Y9O; spf=pass (domain: os.amperecomputing.com, ip: 40.107.243.134, mailfrom: tinhnguyen@os.amperecomputing.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gZQnse82QEE2fLqWvpFkuQnSTHc0Pz2LVatfstsOdbxXkEVzJzV9+CZUyAvhgMruSDv5Cd0Y8FIydpS107eTqBSsRb9faH8TFDXNynNBXFX6BF/fQVQa0aP/w8P6g/3vi1Mz2qwWVXrSZ85x3w1PfW7fm/CLRIjxhxJI6VZEC2rGW6fFRrhyVfwQajI69Yv3sTQmzof8YG3CNBiAJMpvg05ydbMgTd4EyonacgYKP9AHCdXRoO0t2t6SNBsNiOxuU9w0l5BfJ7LHLaBO7AeOi2uCsWB7+Q8qIPYtS5YhJN1BS9r+cVyPSJKWnb9VmPMDipoZKRGnA43taYNiNOkAvg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=xP7QHqf+CWIEJTCMCHs9kAy1Er0u8UwYwXQLvtD/+KI=; b=P7InhUehTKLVB31MmeB9VnBg38RX8u6mzCZZ94L0HhwnDCkCoNZTsHYSXow6OJ1CEaUpzvcJyM+1PFMdXOBz41YTL8cJ+5Clj/2NdiNEJasr6YCs8ZoeUczgtDkvFpYIla0Wm950YR5MonZIwrxHWfV5xUPL/ipF2vFy/dCVBhiVM9QhYi5SqpOXxpa71UQfJR48vjqATeqVOxlbRSfruz8CBYc2V466OS8ILkmSQW+tg7GbGiuloWTg7yaIgPU8NwhbF3mYoMT40sf9bXcxvh66ORYogRIMmAGaLB3xng2Mco/SJffw4UTWTjyfklSk9EUya5alkCUqPEDu5JE/MA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=os.amperecomputing.com; dmarc=pass action=none header.from=amperemail.onmicrosoft.com; dkim=pass header.d=amperemail.onmicrosoft.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amperemail.onmicrosoft.com; s=selector1-amperemail-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xP7QHqf+CWIEJTCMCHs9kAy1Er0u8UwYwXQLvtD/+KI=; b=ekz80Y9OV27kHevgKKIwppYHB8jhBXDcP62VAnyonBesu0aaFlCv4LP7/Hh2DXpQfOEEPNXLW09Ic/7om1pLxW5ICrJ6ItlTGg5zyddbLe+2FiXnA9Rw8lTjob0PYY1hJdH36ighb3/26eLiDAw2MiNfPpDMtltKX0UYMM6htFM= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amperemail.onmicrosoft.com; Received: from DM5PR0102MB3336.prod.exchangelabs.com (2603:10b6:4:9f::11) by BN7PR01MB3667.prod.exchangelabs.com (2603:10b6:406:81::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6411.28; Mon, 22 May 2023 08:03:42 +0000 Received: from DM5PR0102MB3336.prod.exchangelabs.com ([fe80::fefc:e2a9:e823:fe42]) by DM5PR0102MB3336.prod.exchangelabs.com ([fe80::fefc:e2a9:e823:fe42%7]) with mapi id 15.20.6411.027; Mon, 22 May 2023 08:03:42 +0000 Message-ID: <1e7e676d-642c-6634-d8eb-b7fc7effe7a5@amperemail.onmicrosoft.com> Date: Mon, 22 May 2023 15:03:31 +0700 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [edk2-platforms][PATCH 2/3] AmpereAltraPkg: Fix PCIe link training sequence To: Minh Nguyen , devel@edk2.groups.io Cc: patches@amperecomputing.com, quic_llindhol@quicinc.com, ardb+tianocore@kernel.org, nhi@os.amperecomputing.com, tinhnguyen@os.amperecomputing.com References: <20230511075143.2690207-1-minhnguyen1@os.amperecomputing.com> <20230511075143.2690207-3-minhnguyen1@os.amperecomputing.com> From: "Tinh Nguyen" In-Reply-To: <20230511075143.2690207-3-minhnguyen1@os.amperecomputing.com> X-ClientProxiedBy: SG2PR06CA0200.apcprd06.prod.outlook.com (2603:1096:4:1::32) To DM5PR0102MB3336.prod.exchangelabs.com (2603:10b6:4:9f::11) Return-Path: tinhnguyen@os.amperecomputing.com MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM5PR0102MB3336:EE_|BN7PR01MB3667:EE_ X-MS-Office365-Filtering-Correlation-Id: 4fefb013-9697-44a0-d964-08db5a9b0e94 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: /tBkY4NNfEy556VQnXVXTn1GPeU+FvJeoCrCDjwPQKECrTHyrLyoSwnvzsYH1pcHUGGX9MRvOHML0EoSmZ7IKK7ZHUXkfPnz5VvCTeeZaNnoeUawFujN5F0gWaAwkFFlEdDOG72H7fT9SxKaUtYZHh5rG9nJ4HFMHJRRW/artk5GCEnAZLaR7aqeVOuda5SL0XtxsS24s5EMYFwOY5YXIFWorcjRcbWgGCjdUWnhakdrHAo/k8X+DIpNtuBjRr5+KWyDOWEfKjoM4gB8Cabf1EMRYQoGGdd6BjpRrahBwGiNE3kwvYAHPeNmc8rMvf87pwTsoaowm7U/gPflj7gJBMhldGBftV0ZzYlwfyEv+L+7tStr6on0XzNtymY08+6iwZvqZL9N4AEOJOb9fvsSCw8OEdsvlz0qx9TUZ/5FKXHziY0Ycmx0vGJGiAN+eSGONb8YJKVm89T+h5YYFwiKWvN6Lc3Uksenl69gDXyf69cyNYTXNT37dEh4ufYBNDayEmwatqsahLYCvND3Lk1vlnunpva2bmXENr03rpHCQUiO29ttnk8mzLSTZA2SksdtAaJE9rTYLhiT4fHbMl9NWl7rAZ5PvtlXVApqi7eGZf5e9DaQuJte3n3MOWhAfXUtmNr+2Q5izNha7pTfL2TE8g== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM5PR0102MB3336.prod.exchangelabs.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(366004)(396003)(136003)(39850400004)(346002)(376002)(451199021)(8676002)(8936002)(5660300002)(83380400001)(186003)(26005)(53546011)(6512007)(6506007)(42882007)(2616005)(31696002)(107886003)(38100700002)(38350700002)(83170400001)(41300700001)(6666004)(6486002)(52116002)(66476007)(66556008)(66946007)(316002)(4326008)(478600001)(19627235002)(2906002)(31686004)(43740500002);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?L0ExVWgwSVdzQVBaWSt4WkZJenAvTTBJTkRQZWtDbVpMYUhvdUtJZWN6Z0VQ?= =?utf-8?B?TUFnL0NuVWhoZi9XdTRNb09vMFM5MG15eHZaaFJ6eTEwdk9VRHpuNnFLSEY3?= =?utf-8?B?REJRWVA0NG00SkpRTWI3WGRTTFFzYmFqNHd5Zzh6Nnp1bUoxdnV3TEppQUFV?= =?utf-8?B?RmJyYmtNMUcxZDlHZ3NBNm41K0tLTEdOUmZwaVNQTjM4M1pMMlBuRWp3Z1ov?= =?utf-8?B?c2VlcS81MkE3OGNtOStmVTJLcXBTZExaYTlCVXBWTm1NdGtUN1EwYm5BSmxa?= =?utf-8?B?M3ZvRktjaDhjc0syZytxeUh5dW0vUTM4cjlISnZtQXlReUZneVhvMkZjcGRy?= =?utf-8?B?Z2FGY1Y0Z1NnUmpKbkhCUnUzamovY0JKaUhLUE1DNno4OTVQZjZubDMyWjlU?= =?utf-8?B?UzI1dGtqQi9rNkIxWk8wLzlaaDliUXo5amZzZG1PYW9Fc0RhM0ZCcEhDK29n?= =?utf-8?B?VGo4d2lRQXRzWi9maitJT1VnZUhhRHkxc3pXcGZ5bGhDcWZvSWFRZlV6cHlT?= =?utf-8?B?eDRtQXFQK1VsdFFTMFNWaHZCY3BpZkl1UXNiajZXVldCL3VJcDdSYmlkSStV?= =?utf-8?B?d1JuZUlrRGhDbk9wUXlyM2hldTZpaS94K3E4OFY3MHhqZzliSE42MCtocndv?= =?utf-8?B?TWV2ZnpDS1JUZEhIS1VmRFBIWlpDY0RUNGhwa0E0eS80bzVEWnlWUEdZa3hU?= =?utf-8?B?QXdENGpKWWdmbmdDbHk0eGdXMGtIQmd6dS81MjJrcWtES2xSbTVsaHFGTDZv?= =?utf-8?B?TEEreUh0NUsvdTVibzI3bVFBaHNrcmNvL2RHTm9INFQ3SmYwT0FRNEdxWVQ3?= =?utf-8?B?dVhQenlNdDFHVU1Nei9JUWtYQWJFWWE4WStFSmN0TGRGeVZPMitoTlk2eHpU?= =?utf-8?B?K0xmcUlwUE5yVkhPMTg3SkQyTlFrSHk0UE5zSTBKdWJjdUw1aDAzajBFSGxV?= =?utf-8?B?MFNhR2kzd1lQT2dqRWM2cmpBUHlEeXVIaTZwRTl4dy9EUDBNVE9vMzZDcGVH?= =?utf-8?B?WnFCNkluaTZPbm9GU256ZTl3TTM2VGpHaGxWaFExNTVXRzRUbUpCTDR3ZEZr?= =?utf-8?B?dWhWYndyNjFJeW5sZzluNWJLNlVZbUtRUzJHaEFwd2VBU0sxUDRscHdhS1Z2?= =?utf-8?B?Vm9WWng2M24wS3BJTHdLQjhOU1FncHZNODVVYXVRSURQTTVMVHlxR0dJekpz?= =?utf-8?B?b3RQMjV0KzRhb3ZUNFVBbUlJNTZncmJYRGEvSW0xenlVZHlmNzVmRTRUSVFH?= =?utf-8?B?YWZkK3Y2eE9PVFZQRitMMmNyaVRhcS9CeGZmamNwVzJqMzNtbHFKWnVHVHRC?= =?utf-8?B?UEVBMnllS1dXSEJhY1Bnb0RWekdTN3JwNTlBRzBhYU1rTGo3RHhFaTQzWEw0?= =?utf-8?B?M0p5R3Zsd3ArY0U5Z1U0bmNYTjFUOWF4Y1RXNVZLVDlmZVhrbHY4QnU5aW10?= =?utf-8?B?SlpFb2lEUDE5M0lucVJuWjZFUFkrUE9scEQvK1VBVStrSStMc3ZmR0QxZ3p5?= =?utf-8?B?ZmJqQlNkdk9ORXdHb1diR2F5U1M5NnFuL2tlOUlVcHZGQ0VpTzZRNFl2V1ZF?= =?utf-8?B?cUFNYWgwU3kyWXV2bFFZdDZka2o1VWpVUHdOM2M3ZDZOcG5DajB2dEQ1WjBm?= =?utf-8?B?RnVaYnN6ZndKcDFHZHUvTktZUnowQjJPTExuY2JyKysvcjQvNkNWRDlneEtS?= =?utf-8?B?QVBBMXFrckFmUTFTTVB4VnNLbTB1TklFQThvNUlGWG1vYzVxbjNPZGxPS29W?= =?utf-8?B?WW15VDg3L3pFRWVXaVkrdXlFcUk5OEJ0QkNkeTZWdHc4Y3JFVjZ0V1VBczhU?= =?utf-8?B?aVpNLzUvKzdLWDV6ZDV3dCtmbVpyb3ZkMXEvUisvTEh3NVZEblEwbEJQbmsy?= =?utf-8?B?NFYwTUhCa3psS0pkQjlnSHhDell3S2N0L2JmZHJYTjRzVitWcytPQnVQWnNq?= =?utf-8?B?MHEyZm1LSVhCUXN4L3cwd2NlVTg1a0Q1aFNHSlJlQVhYTytwdFhzYkJKRi9u?= =?utf-8?B?c0luUlpXV1RROTVpSFJVSFp4L2tHUmtndGlWd2JxSlV0MktwbmEzelZNQ2Rq?= =?utf-8?B?b0lFczVlcmpIS3lPNWx6anlBdzhaOWdrZVNZOS9nckUvaVFoUGJTZ2VpVFc0?= =?utf-8?B?UjhTcFhaWnZxTFdoTDc0YlU0YmtTTGwzalJwMkRTdG1yRFdBUlJBV05CWWNh?= =?utf-8?Q?XYceNVbevDLYuW5nELUPHE8=3D?= X-OriginatorOrg: amperemail.onmicrosoft.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4fefb013-9697-44a0-d964-08db5a9b0e94 X-MS-Exchange-CrossTenant-AuthSource: DM5PR0102MB3336.prod.exchangelabs.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 May 2023 08:03:41.9739 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3bc2b170-fd94-476d-b0ce-4229bdc904a7 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: hiKDXozW1UiBstoxaT7NX8LzMDZEDy31rnytl4lAM6cq37QDgrNSPzJmfrauE+l/kWdUUVElWa3s5cZw88iTa2Bhl/0uojZuI0miDH6Jh7/+980AGgA57kD9d6RhZrvM X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN7PR01MB3667 Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Reviewed-by: Tinh Nguyen @Leif, @Ard, Please help us to merge this series Thanks, - Tinh On 11/05/2023 14:51, Minh Nguyen wrote: > Currently, the implementation starts link training and put device > out-of-reset right away. This make LinkStat and BlockEventStat registers > indicate that link is not up yet (LinkStat: 0x300 and BlockEventStat: 0x0). > This fix will start link training after putting device out-of-reset. > The values of LinkStat and BlockEventStat registers after this fix are > respectively 0x1103 and 0x1 (Link is up). > > Signed-off-by: Minh Nguyen > --- > Silicon/Ampere/AmpereAltraPkg/Library/Ac01PcieLib/PcieCore.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/Silicon/Ampere/AmpereAltraPkg/Library/Ac01PcieLib/PcieCore.c b/Silicon/Ampere/AmpereAltraPkg/Library/Ac01PcieLib/PcieCore.c > index f7c8defc1906..d797442d9fbc 100644 > --- a/Silicon/Ampere/AmpereAltraPkg/Library/Ac01PcieLib/PcieCore.c > +++ b/Silicon/Ampere/AmpereAltraPkg/Library/Ac01PcieLib/PcieCore.c > @@ -1177,12 +1177,12 @@ Ac01PcieCoreSetupRC ( > // Assert PERST low to reset endpoint > BoardPcieAssertPerst (RootComplex, PcieIndex, FALSE); > > + // Complete the PERST pulse > + BoardPcieAssertPerst (RootComplex, PcieIndex, TRUE); > + > // Start link training > StartLinkTraining (RootComplex, PcieIndex, TRUE); > > - // Complete the PERST pulse > - BoardPcieAssertPerst (RootComplex, PcieIndex, TRUE); > - > // Lock programming of config space > EnableDbiAccess (RootComplex, PcieIndex, FALSE); >