Re: [Patch 0/2] Update CPUID related definition.

[Laszlo Ersek <lersek@redhat.com>]

On 12/03/18 07:30, Eric Dong wrote:
> Update CPUID definition to follow SDM 2018'11 version, changes Include:
> 1. Add new fields to the existed data structure, impact CPUIDs include:
>   1. CPUID_THERMAL_POWER_MANAGEMENT                                 0x06
>        CPUID_THERMAL_POWER_MANAGEMENT_EAX
>   2. CPUID_STRUCTURED_EXTENDED_FEATURE_FLAGS                        0x07
>        CPUID_STRUCTURED_EXTENDED_FEATURE_FLAGS_EBX
>        CPUID_STRUCTURED_EXTENDED_FEATURE_FLAGS_ECX
>   3. CPUID_ARCHITECTURAL_PERFORMANCE_MONITORING  0x0A
>        CPUID_ARCHITECTURAL_PERFORMANCE_MONITORING_EDX
>   4. CPUID_EXTENDED_STATE                                           0x0D
>        CPUID_EXTENDED_STATE_MAIN_LEAF_EAX
>        CPUID_EXTENDED_STATE_SUB_LEAF_ECX
>   5. CPUID_INTEL_RDT_ALLOCATION                                     0x10
>        CPUID_INTEL_RDT_ALLOCATION_ENUMERATION_SUB_LEAF_EBX
>   6. CPUID_INTEL_SGX                                                0x12
>        CPUID_INTEL_SGX_CAPABILITIES_0_SUB_LEAF_EAX
> 
> 2. Add new data structures which not existed before, impact CPUID includes:
>   1. CPUID_STRUCTURED_EXTENDED_FEATURE_FLAGS                        0x07
>        CPUID_STRUCTURED_EXTENDED_FEATURE_FLAGS_EDX
> 
> 3. Remove fields which defined before, impact CPUID includes:
>   1. CPUID_INTEL_RDT_ALLOCATION                                     0x10
>        CPUID_INTEL_RDT_ALLOCATION_L3_CACHE_SUB_LEAF                        0x01
>          CPUID_INTEL_RDT_ALLOCATION_L3_CACHE_SUB_LEAF_ECX
> 
> 4. Add new sub leaf which not existed before, impact CPUID includes:
>   1. CPUID_INTEL_RDT_ALLOCATION                                     0x10
>        CPUID_INTEL_RDT_ALLOCATION_MEMORY_BANDWIDTH_SUB_LEAF                0x03
> 
> 5. Add new CPUIDs which not exist before, new CPUIDs include:
>   1. CPUID_DETERMINISTIC_ADDRESS_TRANSLATION_PARAMETERS             0x18
>   2. CPUID_V2_EXTENDED_TOPOLOGY_ENUMERATION                         0x1F
> 
> Also update Cpuid application in UefiCpuPkg/Application folder.
> 
> Cc: Ruiyu Ni <ruiyu.ni@intel.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Eric Dong <eric.dong@intel.com>
> 
> Eric Dong (2):
>   UefiCpuPkg/Cpuid.h: Sync CPUID definition to latest SDM.
>   UefiCpuPkg/Cpuid: Add code to support new definition.
> 
>  UefiCpuPkg/Application/Cpuid/Cpuid.c | 147 ++++++++-
>  UefiCpuPkg/Include/Register/Cpuid.h  | 620 +++++++++++++++++++++++++++++++++--
>  2 files changed, 739 insertions(+), 28 deletions(-)
> 

Acked-by: Laszlo Ersek <lersek@redhat.com>